From: Julien Grall <julien@xen.org>
To: Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <jgrall@amazon.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
Costin Lupu <costin.lupu@cs.pub.ro>
Subject: Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5
Date: Tue, 13 Jul 2021 15:38:01 +0100 [thread overview]
Message-ID: <c0a7de56-de7b-3451-8cc5-ccb73c78ba42@xen.org> (raw)
In-Reply-To: <69c62b4c-b46f-9eab-8dfd-742c07423424@suse.com>
Hi Juergen,
On 13/07/2021 15:23, Juergen Gross wrote:
> On 13.07.21 16:19, Julien Grall wrote:
>> Hi Jan,
>>
>> On 13/07/2021 15:14, Jan Beulich wrote:
>>>> And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*.
>>>
>>> Even that doesn't seem right to me, at least in principle. There
>>> shouldn't
>>> be a build time setting when it may vary at runtime. IOW on Arm I
>>> think a
>>> runtime query to the hypervisor would be needed instead.
>>
>> Yes, we want to be able to use the same userspace/OS without
>> rebuilding to a specific hypervisor page size.
>
> This define is used for accessing data of other domains. See the define
> for XEN_PAGE_SIZE in xen/include/public/io/ring.h
>
> So it should be a constant (minimal) page size for all hypervisors and
> guests of an architecture.
Do you mean the maximum rather than minimal? If you use the minimal
(4KB), then you would not be able to map the page in the stage-2 if the
hypervisor is using 64KB.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2021-07-13 14:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 9:20 [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5 Julien Grall
2021-07-13 9:25 ` Andrew Cooper
2021-07-13 9:27 ` Juergen Gross
2021-07-13 9:31 ` Julien Grall
2021-07-13 10:35 ` Juergen Gross
2021-07-13 9:35 ` Andrew Cooper
2021-07-13 11:21 ` Julien Grall
2021-07-13 11:23 ` Andrew Cooper
2021-07-13 11:53 ` Julien Grall
2021-07-13 12:39 ` Andrew Cooper
2021-07-13 13:00 ` Julien Grall
2021-07-13 13:46 ` Costin Lupu
2021-07-13 14:00 ` Juergen Gross
2021-07-13 14:14 ` Jan Beulich
2021-07-13 14:19 ` Julien Grall
2021-07-13 14:23 ` Jan Beulich
2021-07-13 14:33 ` Julien Grall
2021-07-13 15:52 ` Jan Beulich
2021-07-13 16:15 ` Julien Grall
2021-07-13 16:27 ` Jan Beulich
2021-07-13 16:33 ` Julien Grall
2021-07-14 6:11 ` Jan Beulich
2021-07-14 8:51 ` Julien Grall
2021-07-13 14:23 ` Juergen Gross
2021-07-13 14:28 ` Jan Beulich
2021-07-13 14:33 ` Juergen Gross
2021-07-13 14:38 ` Julien Grall [this message]
2021-07-13 15:09 ` Juergen Gross
2021-07-13 15:15 ` Julien Grall
2021-07-13 15:20 ` Juergen Gross
2021-07-16 18:28 ` Costin Lupu
2021-07-27 13:36 ` Andrew Cooper
2021-07-30 9:18 ` Costin Lupu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0a7de56-de7b-3451-8cc5-ccb73c78ba42@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=costin.lupu@cs.pub.ro \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.