From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 02/15] drm/i915: Handle cursor updating active_planes correctly. Date: Thu, 20 Sep 2018 11:56:56 +0200 Message-ID: References: <20180919135644.14182-1-maarten.lankhorst@linux.intel.com> <20180919135644.14182-3-maarten.lankhorst@linux.intel.com> <20180920001248.GG31331@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA2486E57A for ; Thu, 20 Sep 2018 09:57:02 +0000 (UTC) In-Reply-To: <20180920001248.GG31331@mdroper-desk.amr.corp.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjAtMDktMTggb20gMDI6MTIgc2NocmVlZiBNYXR0IFJvcGVyOgo+IE9uIFdlZCwgU2VwIDE5 LCAyMDE4IGF0IDAzOjU2OjMxUE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+PiBX aGlsZSB3ZSBtYXkgbm90IHVwZGF0ZSBuZXdfY3J0Y19zdGF0ZSwgd2UgbWF5IGNsZWFyIGFjdGl2 ZV9wbGFuZXMKPj4gaWYgdGhlIG5ldyBjdXJzb3IgdXBkYXRlIHN0YXRlIHdpbGwgZGlzYWJsZSB0 aGUgY3Vyc29yLCBidXQgd2UgZmFpbAo+PiBhZnRlci4gSWYgdGhpcyBpcyBpbW1lZGlhdGVseSBm b2xsb3dlZCBieSBhIG1vZGVzZXQgZGlzYWJsZSwgd2UgbWF5Cj4+IHNvb24gbm90IGRpc2FibGUg dGhlIHBsYW5lcyBjb3JyZWN0bHkgd2hlbiB3ZSBzdGFydCBkZXBlbmRpbmcgb24KPj4gYWN0aXZl X3BsYW5lcy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4u bGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBGaXhlczogYjJiNTU1MDJkNjgzYyAoImRybS9p OTE1OiBQYXNzIHByb3BlciBvbGQvbmV3IHN0YXRlcyB0bwo+IGludGVsX3BsYW5lX2F0b21pY19j aGVja193aXRoX3N0YXRlKCkiKQo+Cj4gSSB0aGluaz8gIFNvIGJhc2ljYWxseSB3ZSB3ZXJlIGNs b2JiZXJpbmcgdGhlIGN1cnJlbnQgY3N0YXRlJ3MKPiBhY3RpdmVfcGxhbmVzIGZpZWxkIChhbmQg YW55dGhpbmcgZWxzZSBpbiBjc3RhdGUgdGhhdAo+IGludGVsX3BsYW5lX2F0b21pY19jaGVja193 aXRoX3N0YXRlKCkgbWlnaHQgdG91Y2ggaW4gdGhlIGZ1dHVyZSkgaWYgdGhlCj4gYXRvbWljIHRy YW5zYWN0aW9uIGZhaWxlZC4KClRoaXMgaXMgaW4gdGhlb3J5IGEgZml4LCBidXQgdXAgdW50aWwg bm93IHdlIGRvbid0IGRlcGVuZCBvbiBpdC4gSXQgb25seQpzdGFydHMgbWF0dGVyaW5nIGZ1cnRo ZXIgZG93biB3aGVyZSB3ZSBzdGFydCB0byB1cGRhdGluZy9kaXNhYmxpbmcgcGxhbmVzCmJhc2Vk IG9uIHRoaXMgZmllbGQuCgpUaGlzIGlzIHdoeSBJIGRpZG4ndCBhZGQgLWZpeGVzLgoKPj4gLS0t Cj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyNSArKysrKysrKysr KysrKysrKy0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgOCBk ZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBpbmRl eCAyYWMzODFlYjgxMDMuLjdhN2ZmMWQ3NjAzMSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+PiBAQCAtMTM1MTcsMTQgKzEzNTE3LDE2IEBAIGludGVsX2xlZ2FjeV9j dXJzb3JfdXBkYXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+PiAgCXN0cnVjdCBkcm1fcGxh bmVfc3RhdGUgKm9sZF9wbGFuZV9zdGF0ZSwgKm5ld19wbGFuZV9zdGF0ZTsKPj4gIAlzdHJ1Y3Qg aW50ZWxfcGxhbmUgKmludGVsX3BsYW5lID0gdG9faW50ZWxfcGxhbmUocGxhbmUpOwo+PiAgCXN0 cnVjdCBkcm1fZnJhbWVidWZmZXIgKm9sZF9mYjsKPj4gLQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUg KmNydGNfc3RhdGUgPSBjcnRjLT5zdGF0ZTsKPj4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq Y3J0Y19zdGF0ZSA9Cj4+ICsJCXRvX2ludGVsX2NydGNfc3RhdGUoY3J0Yy0+c3RhdGUpOwo+PiAr CXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZTsKPj4gIAo+PiAgCS8qCj4+ ICAJICogV2hlbiBjcnRjIGlzIGluYWN0aXZlIG9yIHRoZXJlIGlzIGEgbW9kZXNldCBwZW5kaW5n LAo+PiAgCSAqIHdhaXQgZm9yIGl0IHRvIGNvbXBsZXRlIGluIHRoZSBzbG93cGF0aAo+PiAgCSAq Lwo+PiAtCWlmICghY3J0Y19zdGF0ZS0+YWN0aXZlIHx8IG5lZWRzX21vZGVzZXQoY3J0Y19zdGF0 ZSkgfHwKPj4gLQkgICAgdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjX3N0YXRlKS0+dXBkYXRlX3Bp cGUpCj4+ICsJaWYgKCFjcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSB8fCBuZWVkc19tb2Rlc2V0KCZj cnRjX3N0YXRlLT5iYXNlKSB8fAo+PiArCSAgICBjcnRjX3N0YXRlLT51cGRhdGVfcGlwZSkKPj4g IAkJZ290byBzbG93Owo+PiAgCj4+ICAJb2xkX3BsYW5lX3N0YXRlID0gcGxhbmUtPnN0YXRlOwo+ PiBAQCAtMTM1NTQsNiArMTM1NTYsMTIgQEAgaW50ZWxfbGVnYWN5X2N1cnNvcl91cGRhdGUoc3Ry dWN0IGRybV9wbGFuZSAqcGxhbmUsCj4+ICAJaWYgKCFuZXdfcGxhbmVfc3RhdGUpCj4+ICAJCXJl dHVybiAtRU5PTUVNOwo+PiAgCj4+ICsJbmV3X2NydGNfc3RhdGUgPSB0b19pbnRlbF9jcnRjX3N0 YXRlKGludGVsX2NydGNfZHVwbGljYXRlX3N0YXRlKGNydGMpKTsKPj4gKwlpZiAoIW5ld19jcnRj X3N0YXRlKSB7Cj4+ICsJCXJldCA9IC1FTk9NRU07Cj4+ICsJCWdvdG8gb3V0X2ZyZWU7Cj4+ICsJ fQo+PiArCj4+ICAJZHJtX2F0b21pY19zZXRfZmJfZm9yX3BsYW5lKG5ld19wbGFuZV9zdGF0ZSwg ZmIpOwo+PiAgCj4+ICAJbmV3X3BsYW5lX3N0YXRlLT5zcmNfeCA9IHNyY194Owo+PiBAQCAtMTM1 NjUsOSArMTM1NzMsOCBAQCBpbnRlbF9sZWdhY3lfY3Vyc29yX3VwZGF0ZShzdHJ1Y3QgZHJtX3Bs YW5lICpwbGFuZSwKPj4gIAluZXdfcGxhbmVfc3RhdGUtPmNydGNfdyA9IGNydGNfdzsKPj4gIAlu ZXdfcGxhbmVfc3RhdGUtPmNydGNfaCA9IGNydGNfaDsKPj4gIAo+PiAtCXJldCA9IGludGVsX3Bs YW5lX2F0b21pY19jaGVja193aXRoX3N0YXRlKHRvX2ludGVsX2NydGNfc3RhdGUoY3J0Yy0+c3Rh dGUpLAo+PiAtCQkJCQkJICB0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPnN0YXRlKSwgLyogRklY TUUgbmVlZCBhIG5ldyBjcnRjIHN0YXRlPyAqLwo+PiAtCQkJCQkJICB0b19pbnRlbF9wbGFuZV9z dGF0ZShwbGFuZS0+c3RhdGUpLAo+PiArCXJldCA9IGludGVsX3BsYW5lX2F0b21pY19jaGVja193 aXRoX3N0YXRlKGNydGNfc3RhdGUsIG5ld19jcnRjX3N0YXRlLAo+PiArCQkJCQkJICB0b19pbnRl bF9wbGFuZV9zdGF0ZShvbGRfcGxhbmVfc3RhdGUpLAo+PiAgCQkJCQkJICB0b19pbnRlbF9wbGFu ZV9zdGF0ZShuZXdfcGxhbmVfc3RhdGUpKTsKPj4gIAlpZiAocmV0KQo+PiAgCQlnb3RvIG91dF9m cmVlOwo+PiBAQCAtMTM1ODgsMTEgKzEzNTk1LDExIEBAIGludGVsX2xlZ2FjeV9jdXJzb3JfdXBk YXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+PiAgCj4+ICAJLyogU3dhcCBwbGFuZSBzdGF0 ZSAqLwo+PiAgCXBsYW5lLT5zdGF0ZSA9IG5ld19wbGFuZV9zdGF0ZTsKPj4gKwljcnRjX3N0YXRl LT5hY3RpdmVfcGxhbmVzID0gbmV3X2NydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXM7Cj4gQXQgdGhl IG1vbWVudCB0aGlzIGlzIHRoZSBvbmx5IGNydGNfc3RhdGUgZmllbGQgdGhhdCBvdXIgcGxhbmUg Y2hlY2sKPiBtaWdodCB1cGRhdGUgZm9yIGEgY3Vyc29yLCBidXQgaXMgdGhlcmUgYSByZWFzb24g d2h5IHdlIGRvbid0IGp1c3Qgc3dhcAo+IGluIHRoZSBuZXcgc3RhdGUgYW5kIGRlc3Ryb3kgdGhl IG9sZCBvbmUgZmFydGhlciBkb3duPyAgSWYgb3VyIGRyaXZlcgo+IGV2ZXIgZGlkIHN0YXJ0IHVw ZGF0aW5nIG90aGVyIGZpZWxkcywgaXQgd291bGQgYmUgcmVhbGx5IGVhc3kgdG8KPiBvdmVybG9v ayB0aGUgbmVlZCB0byBjb3B5IHRob3NlIG5ldyBmaWVsZHMgb3ZlciBoZXJlLiAgSSByZWFsaXpl IGEgbG90Cj4gb2YgdGhlIGxpa2VseSBjYW5kaWRhdGVzIGZvciBmaWVsZHMgdGhhdCBwbGFuZSBj aGVjayBtaWdodCB3YW50IHRvCj4gdXBkYXRlIChlLmcuLCB3YXRlcm1hcmsgc3R1ZmYpIHdvdWxk IGFsc28gZGlzcXVhbGlmeSB1cyBmcm9tIHRha2luZyB0aGlzCj4gbGVnYWN5IGN1cnNvciBmYXN0 cGF0aCBpbiB0aGUgZmlyc3QgcGxhY2UsIGJ1dCBJJ20gYSBiaXQgbmVydm91cyBhYm91dAo+IGFz c3VtaW5nIHRoYXQgd2UnbGwgbmV2ZXIgYmUgdXBkYXRpbmcgYW55IG90aGVyIGZpZWxkcyBhdCBh bGwuCgpJIHdpc2ghIFRoaXMgd2FzIHdoYXQgSSBmaXJzdCB0cmllZC4gVGhlbiByZWFsaXplZCBp dCB3YXMgYSB2ZXJ5IHZlcnkgYmFkIGlkZWEuCldlIHdhaXQgZm9yIHBsYW5lX3N0YXRlLT5od19k b25lIHRvIGJlIHNldCwgYnV0IGFuIGF0b21pYyB1cGRhdGUgbWF5IGJlIGluCnByb2dyZXNzLiBJ biB3aGljaCBjYXNlIG91ciBvbGRfY3J0Y19zdGF0ZSBpcyBpdHMgbmV3X2NydGNfc3RhdGUuCgpJ ZiB3ZSBzdGFydCBmcmVlaW5nIHRoYXQuLiByZWFsbHkgYmFkIHRoaW5ncyBoYXBwZW4uIChUTSkK CkknbGwgYWRkIGEgY29tbWVudCBoZXJlIHRvIGV4cGxhaW4gd2h5IHdlIG9ubHkgdXBkYXRlIGNy dGNfc3RhdGUuCgpJbiB0aGVvcnkgaXQgY291bGQgYmUgYSBwcm9ibGVtIHRoYXQgd2UgdXBkYXRl IGNydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXMgbGlmZSwKYnV0IHRoZSBwbGFjZSB0aGF0IHdpbGwg ZGVwZW5kIG9uIGl0IGNoZWNrcyBpZiB0aGUgcGxhbmUgaXMgcGFydCBvZiB0aGUgYXRvbWljCmNv bW1pdCwgYW5kIHdlIHJ1bGVkIG91dCB0aGF0J3MgdGhlIGNhc2UuIFNvIGV2ZW4gaWYgd2UgY2hh bmdlIGl0LCBlaXRoZXIgdmFsdWUKd2lsbCBjYXVzZSB0aGUgc2FtZSBiZWhhdmlvciB3aGVuIHJ1 bm5pbmcgdGhlIGF0b21pYyBwbGFuZSB1cGRhdGUgcGFydC4gV2UndmUKYWxyZWFkeSBydWxlZCBv dXQgbW9kZXNldHMsIHNvIHdlIHdvbid0IHJhY2Ugd2l0aCBkaXNhYmxpbmcgYWxsIHBsYW5lcy4K Cn5NYWFydGVuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK