From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 0/8] Add Marvell NETA PMD Date: Fri, 14 Sep 2018 17:20:58 +0100 Message-ID: References: <1535718368-15803-1-git-send-email-amo@semihalf.com> <1535720386-18775-1-git-send-email-amo@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: mw@semihalf.com, zr@semihalf.com, tdu@semihalf.com, nsamsono@marvell.com To: Andrzej Ostruszka , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6136FA49 for ; Fri, 14 Sep 2018 18:21:02 +0200 (CEST) In-Reply-To: <1535720386-18775-1-git-send-email-amo@semihalf.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote: > This patch series introduces new PMD for Marvell NETA adapters (MVNETA). > See the documentation for more info. > > It is split for easier reviewing. > > v3: > No changes against v2, just resubmitting again to have clean patch > set after my faulty format-patch. My apologies for the noise. > > v2: > * fixed couple of checkpatch warnings > * removed '\n' from MVNETA_LOG invocations (appended by the macro) > * removed unused MVNETA_MUSDK_DMA_MEMSIZE define > * changed one printf into MVNETA_LOG > * removed __func__ from one MVNETA_LOG invocation (inserted > automatically by the macro) > * minor grammar/spelling correction in comments > * removed license text from file with SPDX tag (mvneta.rst) > * removed misleading part of comment for mvneta_shadow_txq > * changed authorship of the patches to the original author > > Natalie Samsonov (1): > net/mvneta: add reset statistics callback > > Zyta Szpak (7): > net/mvneta: add neta PMD skeleton > net/mvneta: add Rx/Tx support > net/mvneta: support for setting of MTU > net/mvneta: add link update > net/mvneta: support for promiscuous > net/mvneta: add MAC filtering > net/mvneta: add support for basic stats Hi Andrzej, Patchset is mostly looks good to me, there is no major issue but I have commented on some minor issues. Can you also set a web page patch to add new hardware to supported hw list: http://core.dpdk.org/supported/ https://git.dpdk.org/tools/dpdk-web/