From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BED4C33CA9 for ; Mon, 13 Jan 2020 16:34:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D23FA207FD for ; Mon, 13 Jan 2020 16:34:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D23FA207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir2fn-0004YW-MM for qemu-devel@archiver.kernel.org; Mon, 13 Jan 2020 11:34:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51374) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir2dw-0002w1-UL for qemu-devel@nongnu.org; Mon, 13 Jan 2020 11:32:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ir2dv-0002m3-U7 for qemu-devel@nongnu.org; Mon, 13 Jan 2020 11:32:44 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:47331) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ir2dr-0002YI-2O; Mon, 13 Jan 2020 11:32:39 -0500 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MNKuI-1j2dFT0RrO-00OpyZ; Mon, 13 Jan 2020 17:32:33 +0100 Subject: Re: [PATCH v1 12/59] virtfs-proxy-helper.c: remove 'err_out' label in setugid() To: Markus Armbruster , Greg Kurz References: <20200106182425.20312-1-danielhb413@gmail.com> <20200106182425.20312-13-danielhb413@gmail.com> <20200107105113.7a443d51@bahia.lan> <87wo9vxu9n.fsf@dusky.pond.sub.org> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: Date: Mon, 13 Jan 2020 17:32:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <87wo9vxu9n.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:ypA1KnPbK5bjGxgGSpvb8UUDlhYrll+k3yczFeSCRUUsKD665Zh nimD7aFv+Ezw6HBiTCq5g/UerArzGmLaWRTWXRz/F0SSy9LzgclCAb2UHsxkuhm2qal6TCe NmoYXqYYHIFjN+a2nFZlqCKlWt5ekInPu8PaCkMHj9/dE0m/4+PjrKt2CW8kPzxb/POk8A1 Fn7yjwhBKVhPM7QjrFBiQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:017bUvLla0M=:9peFF5EsxvxIhPoR+6EIXv ug/LRs5juokRX60MOhsVifhWV6KUXwF1dbzoyPTz1NxAMjCRIdP2Q7esf0OdOP4QQwndYuQBX Ja0SytbbxMCLYLriqP4plfBHLq/+ZR+QXDKINr4pCXPVGrWQ2rQCxaXfPArkYIOsOaqzbFYg7 aTP8utKQppZo4cPuFIyYpvxJ0J9D1/8jcCD8qIJxkzWtUvQdrWuZm9u9jwq9BgVplKF8YtwZR CHICJjOS65Ay5LvpNRLqWb8lATTN9RVwEDKQc78KjJ0ClWwLkHB/u/TRH5ipxZAuir8lrCy81 4jbN304nmmTlgx1juZ6ey4wmLoyIyEzFTz0SCLf7aPf3A8oVfNrywbEdin6FsTadmcHS3QJ4z Gp4yT33T+pVA9rC6q/RYKCArxW48j+1wxcAOFCX0XWRiNvs7Mvu8lS/Z7+tq09wpB/9Pp1YkA gsvks/OOJFhoFUyBZHz438+W+JWt/k6QKnPmNV12sXkfv3BNIYbgxpdRxep5qISTKdi5MQxtA 6smxe5CJPVRB+/2kRb5hgcmUMW1EsCeZnv02J9xjnEOD/Q1P2cHPSeUCVizd36ehO7V5yhIjG SPOCnmbGQ3ciG7XX+YUW0nLWt4HxCsGj8VDjPSyjhHEz9s5swYeBuJRny8svm97sR1o5V1SlC fQB+in6eUClBBjrXNnZdZrC5n0QWXk7XF6by89E6HUaP4eS6dVVOy9pjFbyNppqiWaWB6rp/+ GCtlvpMdwRXsyBfrekEz7ITFazs7oIpKji713uVhH7CZOz+A3yWdO8WP43YbfieZMTog6yo52 PEBgpzVZWTKi4JHgOTzX2adRURAnMRbj0CvAp4v461BLYnP6R8aXzrjw97u2Z73f3QI+2TP4D aZwTNOb8m8vSxNAUDFLH03wBUxVKnnN4k7QTNizKE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.130 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Daniel Henrique Barboza , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 13/01/2020 à 16:15, Markus Armbruster a écrit : > Greg Kurz writes: > >> On Mon, 6 Jan 2020 15:23:38 -0300 >> Daniel Henrique Barboza wrote: >> >>> 'err_out' can be removed and be replaced by 'return -errno' >>> in its only instance in the function. >>> >>> CC: Greg Kurz >>> Signed-off-by: Daniel Henrique Barboza >>> --- >> >> I don't really mind, but I confirm this doesn't change behavior. >> >> Acked-by: Greg Kurz >> >> What's the plan to get this and the other 9p related patches merged ? >> Through the trivial tree or each subsystem tree ? > > I guess qemu-trivial will eventually pick up whatever hasn't been merged > by maintainers. > > [...] > Yes, but the difficulty will be to sort which ones of the 59 patches series to collect... Thanks, Laurent