From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD39C433EF for ; Sat, 21 May 2022 16:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352045AbiEUQil (ORCPT ); Sat, 21 May 2022 12:38:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbiEUQii (ORCPT ); Sat, 21 May 2022 12:38:38 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0203262BDF for ; Sat, 21 May 2022 09:38:34 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id g16so12661462lja.3 for ; Sat, 21 May 2022 09:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=ubEdKOLxNSsh97bDo7kpC8y1FqAK+i/uT0ov6eXAI2o=; b=VGOpXYtocMKIeshgklWD1Zo9cIZadjw/jBv0T7SITGnfSw+kY7kyswsQG+yKDOPdIL lgbOfYW4tytV2kcy9vuPjd1SIFXGAdT0RBbbSvFh+vlWmikbE0fhup438dTlu81UrMd1 2ZjPKcME4smlcKI0In8IqM6w/ffUsdXEjJ3xK1yYr0BPOerlii2ms/hIZixBjf8jwAue EFgO8Mj9dhK4TkCHLycE1wR2gkSB23Tgxtl612CMU+p9bfxBlIpcRplIQ7eMihOoZbvx Iple/oQOgga471BAYxfPyoTU+4ZAAVOP71yOR9Cudi0h3whHn+xwG1XL52goc/glgHsH fSQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=ubEdKOLxNSsh97bDo7kpC8y1FqAK+i/uT0ov6eXAI2o=; b=d0aWed/OIexIKB0gxDbZ9+SrQztIh+rTJVtapirXtyZwg1PUw63XtXjGoiTC23N2q+ A0+UXK4P5ekkiK67/pS5tI74v3WJ5fljV7HSJd351r7iPFMA/hTbwm3fh79Jn870G+p+ nSLK3iQEfJAu2EGbrMkRJQdWSLtCOr8WujN/Eg1vlFS0PzPUpUY0o4zvHoaVTdPGSU6S B+uq8F4v1XMaxgQ2mpNUrf26TYxFYNhiWNKu9sDWGZ/pF+qvEC10+9T14hMSCr8wY3Fu Id19XTi7hGJitZqnVsnuQA4uC+41mllUB0RQiZxDh/27UM+MfpNCyg/P9NITK4OQEP5J V/2w== X-Gm-Message-State: AOAM533G7AWMpRLw2uZDkYoR1WzkGI7cgfShwhIhpIrxYyPYF/OE0J97 0t8aJfoj+5syOoDs+VvWyN7RVw== X-Google-Smtp-Source: ABdhPJzocSGKezCk9kwFPkKlXP5XOqvNaFEMyyKnjUP6VYzzkVVlmn1aqPy6DwNNJlGzTduXCzbs1w== X-Received: by 2002:a2e:b053:0:b0:253:dd50:b93f with SMTP id d19-20020a2eb053000000b00253dd50b93fmr4948944ljl.277.1653151113204; Sat, 21 May 2022 09:38:33 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.185]) by smtp.gmail.com with ESMTPSA id h7-20020ac250c7000000b0047255d21174sm1116566lfm.163.2022.05.21.09.38.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 09:38:32 -0700 (PDT) Message-ID: Date: Sat, 21 May 2022 19:38:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Vasily Averin Subject: [PATCH mm v2 6/9] memcg: enable accounting for percpu allocation of struct cgroup_rstat_cpu To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org struct cgroup_rstat_cpu is percpu allocated for each new cgroup and can consume a significant portion of all allocated memory on nodes with a large number of CPUs. Common part of the cgroup creation: Allocs Alloc $1*$2 Sum Allocation number size -------------------------------------------- 16 ~ 352 5632 5632 KERNFS 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) 1 192 192 10504 (__d_alloc+0x29) 2 72 144 10648 (avc_alloc_node+0x27) 2 64 128 10776 (percpu_ref_init+0x6a) 1 64 64 10840 (memcg_list_lru_alloc+0x21a) percpu: 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f 2 12 24 312 call_site=percpu_ref_init+0x23 1 6 6 318 call_site=__percpu_counter_init+0x22 '+' -- to be accounted, '~' -- partially accounted Signed-off-by: Vasily Averin --- kernel/cgroup/rstat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c index 24b5c2ab5598..f76cb63ae2e0 100644 --- a/kernel/cgroup/rstat.c +++ b/kernel/cgroup/rstat.c @@ -257,7 +257,8 @@ int cgroup_rstat_init(struct cgroup *cgrp) /* the root cgrp has rstat_cpu preallocated */ if (!cgrp->rstat_cpu) { - cgrp->rstat_cpu = alloc_percpu(struct cgroup_rstat_cpu); + cgrp->rstat_cpu = alloc_percpu_gfp(struct cgroup_rstat_cpu + GFP_KERNEL_ACCOUNT); if (!cgrp->rstat_cpu) return -ENOMEM; } -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Averin Subject: [PATCH mm v2 6/9] memcg: enable accounting for percpu allocation of struct cgroup_rstat_cpu Date: Sat, 21 May 2022 19:38:31 +0300 Message-ID: References: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=ubEdKOLxNSsh97bDo7kpC8y1FqAK+i/uT0ov6eXAI2o=; b=VGOpXYtocMKIeshgklWD1Zo9cIZadjw/jBv0T7SITGnfSw+kY7kyswsQG+yKDOPdIL lgbOfYW4tytV2kcy9vuPjd1SIFXGAdT0RBbbSvFh+vlWmikbE0fhup438dTlu81UrMd1 2ZjPKcME4smlcKI0In8IqM6w/ffUsdXEjJ3xK1yYr0BPOerlii2ms/hIZixBjf8jwAue EFgO8Mj9dhK4TkCHLycE1wR2gkSB23Tgxtl612CMU+p9bfxBlIpcRplIQ7eMihOoZbvx Iple/oQOgga471BAYxfPyoTU+4ZAAVOP71yOR9Cudi0h3whHn+xwG1XL52goc/glgHsH fSQg== Content-Language: en-US In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" To: Andrew Morton Cc: kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org struct cgroup_rstat_cpu is percpu allocated for each new cgroup and can consume a significant portion of all allocated memory on nodes with a large number of CPUs. Common part of the cgroup creation: Allocs Alloc $1*$2 Sum Allocation number size -------------------------------------------- 16 ~ 352 5632 5632 KERNFS 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) 1 192 192 10504 (__d_alloc+0x29) 2 72 144 10648 (avc_alloc_node+0x27) 2 64 128 10776 (percpu_ref_init+0x6a) 1 64 64 10840 (memcg_list_lru_alloc+0x21a) percpu: 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f 2 12 24 312 call_site=percpu_ref_init+0x23 1 6 6 318 call_site=__percpu_counter_init+0x22 '+' -- to be accounted, '~' -- partially accounted Signed-off-by: Vasily Averin --- kernel/cgroup/rstat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c index 24b5c2ab5598..f76cb63ae2e0 100644 --- a/kernel/cgroup/rstat.c +++ b/kernel/cgroup/rstat.c @@ -257,7 +257,8 @@ int cgroup_rstat_init(struct cgroup *cgrp) /* the root cgrp has rstat_cpu preallocated */ if (!cgrp->rstat_cpu) { - cgrp->rstat_cpu = alloc_percpu(struct cgroup_rstat_cpu); + cgrp->rstat_cpu = alloc_percpu_gfp(struct cgroup_rstat_cpu + GFP_KERNEL_ACCOUNT); if (!cgrp->rstat_cpu) return -ENOMEM; } -- 2.36.1