All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>,
	Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
	George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH V2] xen/hvm: fix hypervisor crash with hvm_save_one()
Date: Wed, 3 May 2017 10:48:38 +0100	[thread overview]
Message-ID: <c0d72244-dafa-ef49-c8bd-c5bb1914a757@arm.com> (raw)
In-Reply-To: <5908C5290200007800155F51@prv-mh.provo.novell.com>

Hi Jan,

On 02/05/17 16:43, Jan Beulich wrote:
>>>> On 02.05.17 at 17:21, <rcojocaru@bitdefender.com> wrote:
>> hvm_save_cpu_ctxt() returns success without writing any data into
>> hvm_domain_context_t when all VCPUs are offline. This can then crash
>> the hypervisor (with FATAL PAGE FAULT) in hvm_save_one() via the
>> "off < (ctxt.cur - sizeof(*desc))" for() test, where ctxt.cur remains 0,
>> causing an underflow which leads the hypervisor to go off the end of the
>> ctxt buffer.
>>
>> This has been broken since Xen 4.4 (c/s e019c606f59).
>
> And I think we want this in 4.9, but you didn't Cc Julien ...

I agree:

Release-Acked-by: Julien Grall <julien.grall@arm.com>

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-05-03  9:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02 15:21 [PATCH V2] xen/hvm: fix hypervisor crash with hvm_save_one() Razvan Cojocaru
2017-05-02 15:41 ` Jan Beulich
2017-05-02 16:10   ` Razvan Cojocaru
2017-05-02 15:43 ` Jan Beulich
2017-05-03  9:48   ` Julien Grall [this message]
2017-05-02 16:02 ` Tim Deegan
2017-05-02 16:11   ` Andrew Cooper
2017-05-02 16:15     ` Razvan Cojocaru
2017-05-03  6:31     ` Jan Beulich
2017-05-03  9:15       ` Tim Deegan
2017-05-03  9:20         ` Razvan Cojocaru
2017-05-03  9:21         ` Tim Deegan
2017-05-03  9:30           ` Jan Beulich
2017-05-03 10:44             ` Razvan Cojocaru
2017-05-03 12:00               ` Andrew Cooper
2017-05-03 12:11                 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0d72244-dafa-ef49-c8bd-c5bb1914a757@arm.com \
    --to=julien.grall@arm.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.