All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Johannes Holland <johannes.holland@infineon.com>
Cc: jarkko@kernel.org, linux-integrity@vger.kernel.org,
	linux-kernel@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca
Subject: Re: [PATCH] tpm: increase timeout for kselftests
Date: Tue, 10 May 2022 13:56:54 +0200	[thread overview]
Message-ID: <c0daa593-5494-6d40-969b-f7ed09e87d99@molgen.mpg.de> (raw)
In-Reply-To: <20220510111607.22984-1-johannes.holland@infineon.com>

Dear Johannes,


Thank you for your patch.

Am 10.05.22 um 13:16 schrieb Johannes Holland:


Should you resend, maybe be more specific in the commit message summary. 
Maybe:

Double timeout for kselftests to 10 min

> Due to CreatePrimary commands which need to create RSA keys of
> increasing size, the timeout value need to be raised, as well.

need*s*?

> Default is 300s.

Mention 600 ms somewhere?

> Signed-off-by: Johannes Holland <johannes.holland@infineon.com>
> ---
> A timeout of anything below 600s still lead to occasional timeouts for
> me. Therefore, I propose 600s as a new value.

I’d say, this should go into the commit message. Maybe even say, what 
devices you are testing with.


Kind regards,

Paul


>   tools/testing/selftests/tpm2/settings | 2 ++
>   1 file changed, 2 insertions(+)
>   create mode 100644 tools/testing/selftests/tpm2/settings
> 
> diff --git a/tools/testing/selftests/tpm2/settings b/tools/testing/selftests/tpm2/settings
> new file mode 100644
> index 000000000000..919bc3803f03
> --- /dev/null
> +++ b/tools/testing/selftests/tpm2/settings
> @@ -0,0 +1,2 @@
> +timeout=600
> +

  reply	other threads:[~2022-05-10 11:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 11:16 [PATCH] tpm: increase timeout for kselftests Johannes Holland
2022-05-10 11:56 ` Paul Menzel [this message]
2022-05-11 15:14 ` Jarkko Sakkinen
2022-05-20 13:28   ` Stefan Mahnke-Hartmann
2022-05-23 19:59     ` Jarkko Sakkinen
2022-06-20 14:45       ` Stefan Mahnke-Hartmann
2022-06-26  6:18         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0daa593-5494-6d40-969b-f7ed09e87d99@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=johannes.holland@infineon.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.