From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7611BC432C1 for ; Tue, 24 Sep 2019 17:12:17 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EA1521906 for ; Tue, 24 Sep 2019 17:12:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA1521906 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iCoM1-0002B0-Sc; Tue, 24 Sep 2019 17:11:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iCoM1-0002Av-8h for xen-devel@lists.xenproject.org; Tue, 24 Sep 2019 17:11:57 +0000 X-Inumbo-ID: 685fb22c-deee-11e9-bf31-bc764e2007e4 Received: from mx1.suse.de (unknown [195.135.220.15]) by localhost (Halon) with ESMTPS id 685fb22c-deee-11e9-bf31-bc764e2007e4; Tue, 24 Sep 2019 17:11:55 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E210FAE6F; Tue, 24 Sep 2019 17:11:53 +0000 (UTC) Message-ID: From: Dario Faggioli To: =?ISO-8859-1?Q?J=FCrgen_Gro=DF?= , Jan Beulich Date: Tue, 24 Sep 2019 19:11:52 +0200 In-Reply-To: <6e7b8475-bd13-94fc-2715-1d8b4f510eb4@suse.com> References: <20190914085251.18816-1-jgross@suse.com> <20190914085251.18816-8-jgross@suse.com> <19409170-4a99-e336-dae3-b439db509111@suse.com> <6e7b8475-bd13-94fc-2715-1d8b4f510eb4@suse.com> Organization: SUSE User-Agent: Evolution 3.32.4 MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH v3 07/47] xen/sched: move per cpu scheduler private data into struct sched_resource X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Tim Deegan , Robert VanVossen , Julien Grall , Josh Whitehead , Meng Xu , xen-devel@lists.xenproject.org, Ian Jackson , Roger Pau =?ISO-8859-1?Q?Monn=E9?= Content-Type: multipart/mixed; boundary="===============4909103684933582483==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============4909103684933582483== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-YEQzm16YIPgIVbQQytmi" --=-YEQzm16YIPgIVbQQytmi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2019-09-24 at 13:41 +0200, J=C3=BCrgen Gro=C3=9F wrote: > On 19.09.19 17:27, Jan Beulich wrote: > > On 14.09.2019 10:52, Juergen Gross wrote: > > > =20 > > > -DECLARE_PER_CPU(struct schedule_data, schedule_data); > > > +#define curr_on_cpu(c) (get_sched_res(c)->curr) > >=20 > > By moving this a few lines down if could become an inline function > > as it seems, if (see above) its use as an lvalue is not intended. >=20 > I like that idea. Will change to inline function. >=20 Yes, definitely better. With this (turning to inline func) done: Reviewed-by: Dario Faggioli Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-YEQzm16YIPgIVbQQytmi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAl2KTlgACgkQFkJ4iaW4 c+78sBAAtMoVgcwJa8FoTd71N1j0rhe0jTn4uiqto2WcTY1fdzsdvtFwTagPKrY1 xkFpPv74UrFsByz1MwQUCPP2tl/mRKG5UJEPL4GVV1FU8juqpxh5IPQJ4WK2p0j6 mqJc8ysSF2829iCm/dDUGaY3y2pepBbkN0VE6dk82OrJjxxUEDyFwXTzCtJdXpzo +LEDnNyMWoTl5Y/73Et+b4XAbLiRvtH9dYe03iBefUGMDIElFZAiMqyGwErZ6iSR GiB/vKbFwmXeCN+5dO1TF3vMSkmaYwTsVrKic1wQz7FzKdnl82XAVHVevnPxphPS 2m2hL5u9cIXZsG/AFvqg3SSeILmWW30nOKEQKaP2DKFNfFto62+OZMn27I8DV7Dv PmGpeiHhLhsIwZXJwIuoSTKUnNSy02UfqrgimMDjz6jKecmJ2YfB1NJrUcOhwMPT cRxVJVQw9zgcV70W+JMsCUj2F0n4UzffS/UGNwJR6WGKwDtc7Oa37YL9y4i8wJpn SSs9kx8bY26tE3Nyvlrf6yW8TNrqkeHUPBx79nHhNhAtfIpHN8M6WRxfbd2CBQG3 05j9iNvM00AzGgerccL4et/U2gZXLORp656PeTQ5HKtnssf3Pr8q1sihOARay9wI B1CNDhWmGzzahk10zyY3KxVYdOco1QHN/9nhyUJqmQqgI+2fvsA= =Q/vn -----END PGP SIGNATURE----- --=-YEQzm16YIPgIVbQQytmi-- --===============4909103684933582483== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============4909103684933582483==--