* [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
@ 2020-07-22 12:38 ` Michel Dänzer
0 siblings, 0 replies; 16+ messages in thread
From: Michel Dänzer @ 2020-07-22 12:38 UTC (permalink / raw)
To: Leo Li, Nicholas Kazlauskas; +Cc: dri-devel, amd-gfx
From: Michel Dänzer <mdaenzer@redhat.com>
drm_atomic_crtc_check enforces that ::active can only be true if
::enable is as well.
Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 312c543b258f..dabef307a74f 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3415,21 +3415,12 @@ static bool modeset_required(struct drm_crtc_state *crtc_state,
struct dc_stream_state *new_stream,
struct dc_stream_state *old_stream)
{
- if (!drm_atomic_crtc_needs_modeset(crtc_state))
- return false;
-
- if (!crtc_state->enable)
- return false;
-
- return crtc_state->active;
+ return crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
}
static bool modereset_required(struct drm_crtc_state *crtc_state)
{
- if (!drm_atomic_crtc_needs_modeset(crtc_state))
- return false;
-
- return !crtc_state->enable || !crtc_state->active;
+ return !crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
}
static void amdgpu_dm_encoder_destroy(struct drm_encoder *encoder)
@@ -8108,8 +8099,7 @@ static int dm_update_crtc_state(struct amdgpu_display_manager *dm,
* We want to do dc stream updates that do not require a
* full modeset below.
*/
- if (!(enable && aconnector && new_crtc_state->enable &&
- new_crtc_state->active))
+ if (!(enable && aconnector && new_crtc_state->active))
return 0;
/*
* Given above conditions, the dc state cannot be NULL because:
--
2.28.0.rc0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
@ 2020-07-22 12:38 ` Michel Dänzer
0 siblings, 0 replies; 16+ messages in thread
From: Michel Dänzer @ 2020-07-22 12:38 UTC (permalink / raw)
To: Leo Li, Nicholas Kazlauskas; +Cc: dri-devel, amd-gfx
From: Michel Dänzer <mdaenzer@redhat.com>
drm_atomic_crtc_check enforces that ::active can only be true if
::enable is as well.
Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 312c543b258f..dabef307a74f 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3415,21 +3415,12 @@ static bool modeset_required(struct drm_crtc_state *crtc_state,
struct dc_stream_state *new_stream,
struct dc_stream_state *old_stream)
{
- if (!drm_atomic_crtc_needs_modeset(crtc_state))
- return false;
-
- if (!crtc_state->enable)
- return false;
-
- return crtc_state->active;
+ return crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
}
static bool modereset_required(struct drm_crtc_state *crtc_state)
{
- if (!drm_atomic_crtc_needs_modeset(crtc_state))
- return false;
-
- return !crtc_state->enable || !crtc_state->active;
+ return !crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
}
static void amdgpu_dm_encoder_destroy(struct drm_encoder *encoder)
@@ -8108,8 +8099,7 @@ static int dm_update_crtc_state(struct amdgpu_display_manager *dm,
* We want to do dc stream updates that do not require a
* full modeset below.
*/
- if (!(enable && aconnector && new_crtc_state->enable &&
- new_crtc_state->active))
+ if (!(enable && aconnector && new_crtc_state->active))
return 0;
/*
* Given above conditions, the dc state cannot be NULL because:
--
2.28.0.rc0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
2020-07-22 12:38 ` Michel Dänzer
@ 2020-07-22 12:51 ` Daniel Vetter
-1 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2020-07-22 12:51 UTC (permalink / raw)
To: Michel Dänzer; +Cc: Leo Li, amd-gfx list, Nicholas Kazlauskas, dri-devel
On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
>
> From: Michel Dänzer <mdaenzer@redhat.com>
>
> drm_atomic_crtc_check enforces that ::active can only be true if
> ::enable is as well.
>
> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
modeset vs modereset is a bit an inglorious name choice ... since this
seems to be glue code and not part of core dc, maybe rename to
enable_required/disable_required to keep it consistent with the
wording atomic helpers use? DC also seems to use reset for a lot of
other things already (state reset, like atomic, or gpu reset like
drm/scheduler's td_r_), so I think this would also help clarity from a
DC perspective.
Patch itself is good, above just an idea for another patch on top.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++-------------
> 1 file changed, 3 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 312c543b258f..dabef307a74f 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3415,21 +3415,12 @@ static bool modeset_required(struct drm_crtc_state *crtc_state,
> struct dc_stream_state *new_stream,
> struct dc_stream_state *old_stream)
> {
> - if (!drm_atomic_crtc_needs_modeset(crtc_state))
> - return false;
> -
> - if (!crtc_state->enable)
> - return false;
> -
> - return crtc_state->active;
> + return crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
> }
>
> static bool modereset_required(struct drm_crtc_state *crtc_state)
> {
> - if (!drm_atomic_crtc_needs_modeset(crtc_state))
> - return false;
> -
> - return !crtc_state->enable || !crtc_state->active;
> + return !crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
> }
>
> static void amdgpu_dm_encoder_destroy(struct drm_encoder *encoder)
> @@ -8108,8 +8099,7 @@ static int dm_update_crtc_state(struct amdgpu_display_manager *dm,
> * We want to do dc stream updates that do not require a
> * full modeset below.
> */
> - if (!(enable && aconnector && new_crtc_state->enable &&
> - new_crtc_state->active))
> + if (!(enable && aconnector && new_crtc_state->active))
> return 0;
> /*
> * Given above conditions, the dc state cannot be NULL because:
> --
> 2.28.0.rc0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
@ 2020-07-22 12:51 ` Daniel Vetter
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2020-07-22 12:51 UTC (permalink / raw)
To: Michel Dänzer; +Cc: Leo Li, amd-gfx list, Nicholas Kazlauskas, dri-devel
On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
>
> From: Michel Dänzer <mdaenzer@redhat.com>
>
> drm_atomic_crtc_check enforces that ::active can only be true if
> ::enable is as well.
>
> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
modeset vs modereset is a bit an inglorious name choice ... since this
seems to be glue code and not part of core dc, maybe rename to
enable_required/disable_required to keep it consistent with the
wording atomic helpers use? DC also seems to use reset for a lot of
other things already (state reset, like atomic, or gpu reset like
drm/scheduler's td_r_), so I think this would also help clarity from a
DC perspective.
Patch itself is good, above just an idea for another patch on top.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++-------------
> 1 file changed, 3 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 312c543b258f..dabef307a74f 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3415,21 +3415,12 @@ static bool modeset_required(struct drm_crtc_state *crtc_state,
> struct dc_stream_state *new_stream,
> struct dc_stream_state *old_stream)
> {
> - if (!drm_atomic_crtc_needs_modeset(crtc_state))
> - return false;
> -
> - if (!crtc_state->enable)
> - return false;
> -
> - return crtc_state->active;
> + return crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
> }
>
> static bool modereset_required(struct drm_crtc_state *crtc_state)
> {
> - if (!drm_atomic_crtc_needs_modeset(crtc_state))
> - return false;
> -
> - return !crtc_state->enable || !crtc_state->active;
> + return !crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
> }
>
> static void amdgpu_dm_encoder_destroy(struct drm_encoder *encoder)
> @@ -8108,8 +8099,7 @@ static int dm_update_crtc_state(struct amdgpu_display_manager *dm,
> * We want to do dc stream updates that do not require a
> * full modeset below.
> */
> - if (!(enable && aconnector && new_crtc_state->enable &&
> - new_crtc_state->active))
> + if (!(enable && aconnector && new_crtc_state->active))
> return 0;
> /*
> * Given above conditions, the dc state cannot be NULL because:
> --
> 2.28.0.rc0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
2020-07-22 12:51 ` Daniel Vetter
@ 2020-07-22 13:10 ` Kazlauskas, Nicholas
-1 siblings, 0 replies; 16+ messages in thread
From: Kazlauskas, Nicholas @ 2020-07-22 13:10 UTC (permalink / raw)
To: Daniel Vetter, Michel Dänzer; +Cc: Leo Li, amd-gfx list, dri-devel
On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
>>
>> From: Michel Dänzer <mdaenzer@redhat.com>
>>
>> drm_atomic_crtc_check enforces that ::active can only be true if
>> ::enable is as well.
>>
>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
Looks fine to me. The check is sufficiently old enough that I don't mind
relying on the core for this either.
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> modeset vs modereset is a bit an inglorious name choice ... since this
> seems to be glue code and not part of core dc, maybe rename to
> enable_required/disable_required to keep it consistent with the
> wording atomic helpers use? DC also seems to use reset for a lot of
> other things already (state reset, like atomic, or gpu reset like
> drm/scheduler's td_r_), so I think this would also help clarity from a
> DC perspective.
>
> Patch itself is good, above just an idea for another patch on top.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
That sounds like a reasonable idea to me. These are used more as a
stream_changed / stream_removed flag, but I don't think these helpers
really need to exist at all.
That could come as a follow up patch.
Regards,
Nicholas Kazlauskas
>> ---
>> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++-------------
>> 1 file changed, 3 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 312c543b258f..dabef307a74f 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -3415,21 +3415,12 @@ static bool modeset_required(struct drm_crtc_state *crtc_state,
>> struct dc_stream_state *new_stream,
>> struct dc_stream_state *old_stream)
>> {
>> - if (!drm_atomic_crtc_needs_modeset(crtc_state))
>> - return false;
>> -
>> - if (!crtc_state->enable)
>> - return false;
>> -
>> - return crtc_state->active;
>> + return crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
>> }
>>
>> static bool modereset_required(struct drm_crtc_state *crtc_state)
>> {
>> - if (!drm_atomic_crtc_needs_modeset(crtc_state))
>> - return false;
>> -
>> - return !crtc_state->enable || !crtc_state->active;
>> + return !crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
>> }
>>
>> static void amdgpu_dm_encoder_destroy(struct drm_encoder *encoder)
>> @@ -8108,8 +8099,7 @@ static int dm_update_crtc_state(struct amdgpu_display_manager *dm,
>> * We want to do dc stream updates that do not require a
>> * full modeset below.
>> */
>> - if (!(enable && aconnector && new_crtc_state->enable &&
>> - new_crtc_state->active))
>> + if (!(enable && aconnector && new_crtc_state->active))
>> return 0;
>> /*
>> * Given above conditions, the dc state cannot be NULL because:
>> --
>> 2.28.0.rc0
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
@ 2020-07-22 13:10 ` Kazlauskas, Nicholas
0 siblings, 0 replies; 16+ messages in thread
From: Kazlauskas, Nicholas @ 2020-07-22 13:10 UTC (permalink / raw)
To: Daniel Vetter, Michel Dänzer; +Cc: Leo Li, amd-gfx list, dri-devel
On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
>>
>> From: Michel Dänzer <mdaenzer@redhat.com>
>>
>> drm_atomic_crtc_check enforces that ::active can only be true if
>> ::enable is as well.
>>
>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
Looks fine to me. The check is sufficiently old enough that I don't mind
relying on the core for this either.
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> modeset vs modereset is a bit an inglorious name choice ... since this
> seems to be glue code and not part of core dc, maybe rename to
> enable_required/disable_required to keep it consistent with the
> wording atomic helpers use? DC also seems to use reset for a lot of
> other things already (state reset, like atomic, or gpu reset like
> drm/scheduler's td_r_), so I think this would also help clarity from a
> DC perspective.
>
> Patch itself is good, above just an idea for another patch on top.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
That sounds like a reasonable idea to me. These are used more as a
stream_changed / stream_removed flag, but I don't think these helpers
really need to exist at all.
That could come as a follow up patch.
Regards,
Nicholas Kazlauskas
>> ---
>> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++-------------
>> 1 file changed, 3 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 312c543b258f..dabef307a74f 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -3415,21 +3415,12 @@ static bool modeset_required(struct drm_crtc_state *crtc_state,
>> struct dc_stream_state *new_stream,
>> struct dc_stream_state *old_stream)
>> {
>> - if (!drm_atomic_crtc_needs_modeset(crtc_state))
>> - return false;
>> -
>> - if (!crtc_state->enable)
>> - return false;
>> -
>> - return crtc_state->active;
>> + return crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
>> }
>>
>> static bool modereset_required(struct drm_crtc_state *crtc_state)
>> {
>> - if (!drm_atomic_crtc_needs_modeset(crtc_state))
>> - return false;
>> -
>> - return !crtc_state->enable || !crtc_state->active;
>> + return !crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state);
>> }
>>
>> static void amdgpu_dm_encoder_destroy(struct drm_encoder *encoder)
>> @@ -8108,8 +8099,7 @@ static int dm_update_crtc_state(struct amdgpu_display_manager *dm,
>> * We want to do dc stream updates that do not require a
>> * full modeset below.
>> */
>> - if (!(enable && aconnector && new_crtc_state->enable &&
>> - new_crtc_state->active))
>> + if (!(enable && aconnector && new_crtc_state->active))
>> return 0;
>> /*
>> * Given above conditions, the dc state cannot be NULL because:
>> --
>> 2.28.0.rc0
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
2020-07-22 13:10 ` Kazlauskas, Nicholas
@ 2020-07-22 14:25 ` Michel Dänzer
-1 siblings, 0 replies; 16+ messages in thread
From: Michel Dänzer @ 2020-07-22 14:25 UTC (permalink / raw)
To: Kazlauskas, Nicholas, Daniel Vetter; +Cc: Leo Li, dri-devel, amd-gfx list
On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
> On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
>> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
>>>
>>> From: Michel Dänzer <mdaenzer@redhat.com>
>>>
>>> drm_atomic_crtc_check enforces that ::active can only be true if
>>> ::enable is as well.
>>>
>>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
>
> Looks fine to me. The check is sufficiently old enough that I don't mind
> relying on the core for this either.
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
>>
>> modeset vs modereset is a bit an inglorious name choice ... since this
>> seems to be glue code and not part of core dc, maybe rename to
>> enable_required/disable_required to keep it consistent with the
>> wording atomic helpers use? DC also seems to use reset for a lot of
>> other things already (state reset, like atomic, or gpu reset like
>> drm/scheduler's td_r_), so I think this would also help clarity from a
>> DC perspective.
>>
>> Patch itself is good, above just an idea for another patch on top.
>>
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Thanks for the reviews! I assume this will get picked up by a DC
developer or Alex/Christian.
> That sounds like a reasonable idea to me. These are used more as a
> stream_changed / stream_removed flag, but I don't think these helpers
> really need to exist at all.
>
> That could come as a follow up patch.
Yeah, I'm leaving that to you guys. :)
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
@ 2020-07-22 14:25 ` Michel Dänzer
0 siblings, 0 replies; 16+ messages in thread
From: Michel Dänzer @ 2020-07-22 14:25 UTC (permalink / raw)
To: Kazlauskas, Nicholas, Daniel Vetter; +Cc: Leo Li, dri-devel, amd-gfx list
On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
> On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
>> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
>>>
>>> From: Michel Dänzer <mdaenzer@redhat.com>
>>>
>>> drm_atomic_crtc_check enforces that ::active can only be true if
>>> ::enable is as well.
>>>
>>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
>
> Looks fine to me. The check is sufficiently old enough that I don't mind
> relying on the core for this either.
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
>>
>> modeset vs modereset is a bit an inglorious name choice ... since this
>> seems to be glue code and not part of core dc, maybe rename to
>> enable_required/disable_required to keep it consistent with the
>> wording atomic helpers use? DC also seems to use reset for a lot of
>> other things already (state reset, like atomic, or gpu reset like
>> drm/scheduler's td_r_), so I think this would also help clarity from a
>> DC perspective.
>>
>> Patch itself is good, above just an idea for another patch on top.
>>
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Thanks for the reviews! I assume this will get picked up by a DC
developer or Alex/Christian.
> That sounds like a reasonable idea to me. These are used more as a
> stream_changed / stream_removed flag, but I don't think these helpers
> really need to exist at all.
>
> That could come as a follow up patch.
Yeah, I'm leaving that to you guys. :)
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
2020-07-22 14:25 ` Michel Dänzer
@ 2020-07-22 15:19 ` Daniel Vetter
-1 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2020-07-22 15:19 UTC (permalink / raw)
To: Michel Dänzer; +Cc: Leo Li, dri-devel, Kazlauskas, Nicholas, amd-gfx list
On Wed, Jul 22, 2020 at 4:25 PM Michel Dänzer <michel@daenzer.net> wrote:
>
> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
> > On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
> >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
> >>>
> >>> From: Michel Dänzer <mdaenzer@redhat.com>
> >>>
> >>> drm_atomic_crtc_check enforces that ::active can only be true if
> >>> ::enable is as well.
> >>>
> >>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
> >
> > Looks fine to me. The check is sufficiently old enough that I don't mind
> > relying on the core for this either.
"active implies enabled" has been a hard assumption of atomic from day
1. So should work anywhere you have atomic.
-Daniel
> > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> >
> >>
> >> modeset vs modereset is a bit an inglorious name choice ... since this
> >> seems to be glue code and not part of core dc, maybe rename to
> >> enable_required/disable_required to keep it consistent with the
> >> wording atomic helpers use? DC also seems to use reset for a lot of
> >> other things already (state reset, like atomic, or gpu reset like
> >> drm/scheduler's td_r_), so I think this would also help clarity from a
> >> DC perspective.
> >>
> >> Patch itself is good, above just an idea for another patch on top.
> >>
> >> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Thanks for the reviews! I assume this will get picked up by a DC
> developer or Alex/Christian.
>
>
> > That sounds like a reasonable idea to me. These are used more as a
> > stream_changed / stream_removed flag, but I don't think these helpers
> > really need to exist at all.
> >
> > That could come as a follow up patch.
>
> Yeah, I'm leaving that to you guys. :)
>
>
> --
> Earthling Michel Dänzer | https://redhat.com
> Libre software enthusiast | Mesa and X developer
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
@ 2020-07-22 15:19 ` Daniel Vetter
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2020-07-22 15:19 UTC (permalink / raw)
To: Michel Dänzer; +Cc: Leo Li, dri-devel, Kazlauskas, Nicholas, amd-gfx list
On Wed, Jul 22, 2020 at 4:25 PM Michel Dänzer <michel@daenzer.net> wrote:
>
> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
> > On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
> >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
> >>>
> >>> From: Michel Dänzer <mdaenzer@redhat.com>
> >>>
> >>> drm_atomic_crtc_check enforces that ::active can only be true if
> >>> ::enable is as well.
> >>>
> >>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
> >
> > Looks fine to me. The check is sufficiently old enough that I don't mind
> > relying on the core for this either.
"active implies enabled" has been a hard assumption of atomic from day
1. So should work anywhere you have atomic.
-Daniel
> > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> >
> >>
> >> modeset vs modereset is a bit an inglorious name choice ... since this
> >> seems to be glue code and not part of core dc, maybe rename to
> >> enable_required/disable_required to keep it consistent with the
> >> wording atomic helpers use? DC also seems to use reset for a lot of
> >> other things already (state reset, like atomic, or gpu reset like
> >> drm/scheduler's td_r_), so I think this would also help clarity from a
> >> DC perspective.
> >>
> >> Patch itself is good, above just an idea for another patch on top.
> >>
> >> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Thanks for the reviews! I assume this will get picked up by a DC
> developer or Alex/Christian.
>
>
> > That sounds like a reasonable idea to me. These are used more as a
> > stream_changed / stream_removed flag, but I don't think these helpers
> > really need to exist at all.
> >
> > That could come as a follow up patch.
>
> Yeah, I'm leaving that to you guys. :)
>
>
> --
> Earthling Michel Dänzer | https://redhat.com
> Libre software enthusiast | Mesa and X developer
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
2020-07-22 14:25 ` Michel Dänzer
@ 2020-07-22 17:12 ` Alex Deucher
-1 siblings, 0 replies; 16+ messages in thread
From: Alex Deucher @ 2020-07-22 17:12 UTC (permalink / raw)
To: Michel Dänzer; +Cc: Leo Li, dri-devel, amd-gfx list, Kazlauskas, Nicholas
On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer <michel@daenzer.net> wrote:
>
> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
> > On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
> >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
> >>>
> >>> From: Michel Dänzer <mdaenzer@redhat.com>
> >>>
> >>> drm_atomic_crtc_check enforces that ::active can only be true if
> >>> ::enable is as well.
> >>>
> >>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
> >
> > Looks fine to me. The check is sufficiently old enough that I don't mind
> > relying on the core for this either.
> >
> > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> >
> >>
> >> modeset vs modereset is a bit an inglorious name choice ... since this
> >> seems to be glue code and not part of core dc, maybe rename to
> >> enable_required/disable_required to keep it consistent with the
> >> wording atomic helpers use? DC also seems to use reset for a lot of
> >> other things already (state reset, like atomic, or gpu reset like
> >> drm/scheduler's td_r_), so I think this would also help clarity from a
> >> DC perspective.
> >>
> >> Patch itself is good, above just an idea for another patch on top.
> >>
> >> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Thanks for the reviews! I assume this will get picked up by a DC
> developer or Alex/Christian.
Applied. Thanks!
Alex
>
>
> > That sounds like a reasonable idea to me. These are used more as a
> > stream_changed / stream_removed flag, but I don't think these helpers
> > really need to exist at all.
> >
> > That could come as a follow up patch.
>
> Yeah, I'm leaving that to you guys. :)
>
>
> --
> Earthling Michel Dänzer | https://redhat.com
> Libre software enthusiast | Mesa and X developer
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
@ 2020-07-22 17:12 ` Alex Deucher
0 siblings, 0 replies; 16+ messages in thread
From: Alex Deucher @ 2020-07-22 17:12 UTC (permalink / raw)
To: Michel Dänzer
Cc: Leo Li, dri-devel, amd-gfx list, Kazlauskas, Nicholas, Daniel Vetter
On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer <michel@daenzer.net> wrote:
>
> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
> > On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
> >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
> >>>
> >>> From: Michel Dänzer <mdaenzer@redhat.com>
> >>>
> >>> drm_atomic_crtc_check enforces that ::active can only be true if
> >>> ::enable is as well.
> >>>
> >>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
> >
> > Looks fine to me. The check is sufficiently old enough that I don't mind
> > relying on the core for this either.
> >
> > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> >
> >>
> >> modeset vs modereset is a bit an inglorious name choice ... since this
> >> seems to be glue code and not part of core dc, maybe rename to
> >> enable_required/disable_required to keep it consistent with the
> >> wording atomic helpers use? DC also seems to use reset for a lot of
> >> other things already (state reset, like atomic, or gpu reset like
> >> drm/scheduler's td_r_), so I think this would also help clarity from a
> >> DC perspective.
> >>
> >> Patch itself is good, above just an idea for another patch on top.
> >>
> >> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Thanks for the reviews! I assume this will get picked up by a DC
> developer or Alex/Christian.
Applied. Thanks!
Alex
>
>
> > That sounds like a reasonable idea to me. These are used more as a
> > stream_changed / stream_removed flag, but I don't think these helpers
> > really need to exist at all.
> >
> > That could come as a follow up patch.
>
> Yeah, I'm leaving that to you guys. :)
>
>
> --
> Earthling Michel Dänzer | https://redhat.com
> Libre software enthusiast | Mesa and X developer
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
2020-07-22 17:12 ` Alex Deucher
@ 2020-08-19 9:08 ` Michel Dänzer
-1 siblings, 0 replies; 16+ messages in thread
From: Michel Dänzer @ 2020-08-19 9:08 UTC (permalink / raw)
To: Alex Deucher; +Cc: Leo Li, amd-gfx list, dri-devel, Kazlauskas, Nicholas
On 2020-07-22 7:12 p.m., Alex Deucher wrote:
> On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer <michel@daenzer.net> wrote:
>> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
>>> On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
>>>> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
>>>>>
>>>>> From: Michel Dänzer <mdaenzer@redhat.com>
>>>>>
>>>>> drm_atomic_crtc_check enforces that ::active can only be true if
>>>>> ::enable is as well.
>>>>>
>>>>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
>>>
>>> Looks fine to me. The check is sufficiently old enough that I don't mind
>>> relying on the core for this either.
>>>
>>> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>>>
>>>>
>>>> modeset vs modereset is a bit an inglorious name choice ... since this
>>>> seems to be glue code and not part of core dc, maybe rename to
>>>> enable_required/disable_required to keep it consistent with the
>>>> wording atomic helpers use? DC also seems to use reset for a lot of
>>>> other things already (state reset, like atomic, or gpu reset like
>>>> drm/scheduler's td_r_), so I think this would also help clarity from a
>>>> DC perspective.
>>>>
>>>> Patch itself is good, above just an idea for another patch on top.
>>>>
>>>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>> Thanks for the reviews! I assume this will get picked up by a DC
>> developer or Alex/Christian.
>
> Applied. Thanks!
Thank you. Can't see it in the DRM changes for 5.9 though.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
@ 2020-08-19 9:08 ` Michel Dänzer
0 siblings, 0 replies; 16+ messages in thread
From: Michel Dänzer @ 2020-08-19 9:08 UTC (permalink / raw)
To: Alex Deucher
Cc: Leo Li, Daniel Vetter, amd-gfx list, dri-devel, Kazlauskas, Nicholas
On 2020-07-22 7:12 p.m., Alex Deucher wrote:
> On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer <michel@daenzer.net> wrote:
>> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
>>> On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
>>>> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
>>>>>
>>>>> From: Michel Dänzer <mdaenzer@redhat.com>
>>>>>
>>>>> drm_atomic_crtc_check enforces that ::active can only be true if
>>>>> ::enable is as well.
>>>>>
>>>>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
>>>
>>> Looks fine to me. The check is sufficiently old enough that I don't mind
>>> relying on the core for this either.
>>>
>>> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>>>
>>>>
>>>> modeset vs modereset is a bit an inglorious name choice ... since this
>>>> seems to be glue code and not part of core dc, maybe rename to
>>>> enable_required/disable_required to keep it consistent with the
>>>> wording atomic helpers use? DC also seems to use reset for a lot of
>>>> other things already (state reset, like atomic, or gpu reset like
>>>> drm/scheduler's td_r_), so I think this would also help clarity from a
>>>> DC perspective.
>>>>
>>>> Patch itself is good, above just an idea for another patch on top.
>>>>
>>>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>> Thanks for the reviews! I assume this will get picked up by a DC
>> developer or Alex/Christian.
>
> Applied. Thanks!
Thank you. Can't see it in the DRM changes for 5.9 though.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
2020-08-19 9:08 ` Michel Dänzer
@ 2020-08-19 13:55 ` Alex Deucher
-1 siblings, 0 replies; 16+ messages in thread
From: Alex Deucher @ 2020-08-19 13:55 UTC (permalink / raw)
To: Michel Dänzer; +Cc: Leo Li, amd-gfx list, dri-devel, Kazlauskas, Nicholas
On Wed, Aug 19, 2020 at 5:08 AM Michel Dänzer <michel@daenzer.net> wrote:
>
> On 2020-07-22 7:12 p.m., Alex Deucher wrote:
> > On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer <michel@daenzer.net> wrote:
> >> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
> >>> On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
> >>>> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
> >>>>>
> >>>>> From: Michel Dänzer <mdaenzer@redhat.com>
> >>>>>
> >>>>> drm_atomic_crtc_check enforces that ::active can only be true if
> >>>>> ::enable is as well.
> >>>>>
> >>>>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
> >>>
> >>> Looks fine to me. The check is sufficiently old enough that I don't mind
> >>> relying on the core for this either.
> >>>
> >>> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> >>>
> >>>>
> >>>> modeset vs modereset is a bit an inglorious name choice ... since this
> >>>> seems to be glue code and not part of core dc, maybe rename to
> >>>> enable_required/disable_required to keep it consistent with the
> >>>> wording atomic helpers use? DC also seems to use reset for a lot of
> >>>> other things already (state reset, like atomic, or gpu reset like
> >>>> drm/scheduler's td_r_), so I think this would also help clarity from a
> >>>> DC perspective.
> >>>>
> >>>> Patch itself is good, above just an idea for another patch on top.
> >>>>
> >>>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >>
> >> Thanks for the reviews! I assume this will get picked up by a DC
> >> developer or Alex/Christian.
> >
> > Applied. Thanks!
>
> Thank you. Can't see it in the DRM changes for 5.9 though.
Will show up for 5.10 as it didn't seem critical for 5.9.
Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks
@ 2020-08-19 13:55 ` Alex Deucher
0 siblings, 0 replies; 16+ messages in thread
From: Alex Deucher @ 2020-08-19 13:55 UTC (permalink / raw)
To: Michel Dänzer
Cc: Leo Li, Daniel Vetter, amd-gfx list, dri-devel, Kazlauskas, Nicholas
On Wed, Aug 19, 2020 at 5:08 AM Michel Dänzer <michel@daenzer.net> wrote:
>
> On 2020-07-22 7:12 p.m., Alex Deucher wrote:
> > On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer <michel@daenzer.net> wrote:
> >> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote:
> >>> On 2020-07-22 8:51 a.m., Daniel Vetter wrote:
> >>>> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@daenzer.net> wrote:
> >>>>>
> >>>>> From: Michel Dänzer <mdaenzer@redhat.com>
> >>>>>
> >>>>> drm_atomic_crtc_check enforces that ::active can only be true if
> >>>>> ::enable is as well.
> >>>>>
> >>>>> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
> >>>
> >>> Looks fine to me. The check is sufficiently old enough that I don't mind
> >>> relying on the core for this either.
> >>>
> >>> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> >>>
> >>>>
> >>>> modeset vs modereset is a bit an inglorious name choice ... since this
> >>>> seems to be glue code and not part of core dc, maybe rename to
> >>>> enable_required/disable_required to keep it consistent with the
> >>>> wording atomic helpers use? DC also seems to use reset for a lot of
> >>>> other things already (state reset, like atomic, or gpu reset like
> >>>> drm/scheduler's td_r_), so I think this would also help clarity from a
> >>>> DC perspective.
> >>>>
> >>>> Patch itself is good, above just an idea for another patch on top.
> >>>>
> >>>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >>
> >> Thanks for the reviews! I assume this will get picked up by a DC
> >> developer or Alex/Christian.
> >
> > Applied. Thanks!
>
> Thank you. Can't see it in the DRM changes for 5.9 though.
Will show up for 5.10 as it didn't seem critical for 5.9.
Alex
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2020-08-19 13:55 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 12:38 [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks Michel Dänzer
2020-07-22 12:38 ` Michel Dänzer
2020-07-22 12:51 ` Daniel Vetter
2020-07-22 12:51 ` Daniel Vetter
2020-07-22 13:10 ` Kazlauskas, Nicholas
2020-07-22 13:10 ` Kazlauskas, Nicholas
2020-07-22 14:25 ` Michel Dänzer
2020-07-22 14:25 ` Michel Dänzer
2020-07-22 15:19 ` Daniel Vetter
2020-07-22 15:19 ` Daniel Vetter
2020-07-22 17:12 ` Alex Deucher
2020-07-22 17:12 ` Alex Deucher
2020-08-19 9:08 ` Michel Dänzer
2020-08-19 9:08 ` Michel Dänzer
2020-08-19 13:55 ` Alex Deucher
2020-08-19 13:55 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.