From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752140AbdFUNxL (ORCPT ); Wed, 21 Jun 2017 09:53:11 -0400 Received: from mail-dm3nam03on0089.outbound.protection.outlook.com ([104.47.41.89]:10592 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750999AbdFUNxE (ORCPT ); Wed, 21 Jun 2017 09:53:04 -0400 Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v7 07/36] x86/mm: Don't use phys_to_virt in ioremap() if SME is active To: Thomas Gleixner Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, xen-devel@lists.xen.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Brijesh Singh , Toshimitsu Kani , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matt Fleming , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , Jonathan Corbet , Joerg Roedel , "Michael S. Tsirkin" , Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Borislav Petkov , Andy Lutomirski , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , Paolo Bonzini References: <20170616184947.18967.84890.stgit@tlendack-t1.amdoffice.net> <20170616185104.18967.7867.stgit@tlendack-t1.amdoffice.net> From: Tom Lendacky Message-ID: Date: Wed, 21 Jun 2017 08:52:53 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: BN6PR11CA0006.namprd11.prod.outlook.com (10.172.17.16) To DM5PR12MB1146.namprd12.prod.outlook.com (10.168.236.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8336e69e-2a61-41ed-da16-08d4b8acd458 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500055)(300135000095)(300000501055)(300135300095)(22001)(300000502055)(300135100095)(300000503055)(300135400095)(48565401081)(201703131423075)(201703031133081)(300000504055)(300135200095)(300000505055)(300135600095)(300000506048)(300135500095);SRVR:DM5PR12MB1146; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;3:D52iNAdBS+0jMN0v24Sju5gFFLg5o2pvB8KOoKnUbRKbkQMd0fWjum2Zx8+TW3ZzO9a8KKa1zC0T9zYSUKL62ISC3YRpYP4rQ/GAUnXFIZB9pjkf5a5vbEEbhSGW5YUYiva11hLPrWEndS5GBrA1aCF01zF2V2GcMn7Gks6AcnYRFHajSLhwmUeQ17quUFXFHvdagoygS9lGZ2Gx8M9F7c1tli38NUdDx8UQjBtFZfFaSqnyOeK8yk4yYRihdgkljeCYYSw1O3iOXFLUaUafycpuMEZCDKTTIDMivdQ0Y44o0NCb3prc5M9JuGg8QP8MNXPP8ofOQQsfyfC9GnWMjExpkgev6FRDsbFEzQw7tp6dAojv+ywg7L2q0HlxXtdBmpbfinGsKWwugr/8vi60X0BcJoK/zGKerXeSbLUmJ5w7AeP2g82JYPiHj2Q9d/Y5UifzXf9ourQ2mrPLx6M4iAJjA4GRj3VnQvi77f/LJBHuIqnr6gnNqyor2o/otnNsBv/2iz4964MbUjvtBxuUKlV1d5bJ5xt9+2lRnFdRekMdpiNIC1DYLnyRDJv6dXrV6Saz/kfxYSduvEtQyQLoz4yR6EXd+VuB70IeHy+2f82n97FPpwHLrJTIM+ATcKhtJWG90XXRaw7dxEWA6oVqsNN8RmJmDXcFQ/vk85oCMrjSD5e8nFtf4sWeQ06qf9bpFotyqB3FJWt4iUfV1oo2JDSJ3r6z3/xmPctRQqzwgTXnWlVOpZgjDiKDekXHCFnWwrAvxkHHt3m8jN+UH6l6+Q== X-MS-TrafficTypeDiagnostic: DM5PR12MB1146: X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;25:XHffX99VnJI4QzXqTvht7cy4aH3z+ZTCxC8aQiDw8YjIoyaW+ku0sBvyrI5YOJ5egLIzkPKaK43yPIcdusloZitGQSNsALSmZHH9vaR9QjzYxM7jtKTKMkL9hc+Zseolzx2hoNvr9VmM5t0GLug6jhyj/D35Xp/oRi6w03OClhiswspSLDv5VNvm/2CnICgwAuEOcoNJYbmiz3FP4SYSWS1ySxQ7vO6tJo6u4Qs+Z/+RAG1HlHE/R91+Zd8BF1OkL6OqJkn/vGB1pUTY8fQG1MNlSP52XY5LLYRLWWVzE0S63KBbc14MkXZnh3fC3t+boMMcFl2beFf38DieDsE7AZDZNrITeRDyIsEsT4iuheeJaP5hIPuImPCdOBhDFnQsPYYwtWaMRsLhgf23gEnvliMIFlc/f9CatzVLDRY63GAdyGJatJLSbahZlUMVe586di2Y/6eVffw8oBnDk/Bmu4kF3R20pYGOKFCjnUwzvdeNBXsHASNjCpOv6J/TK4jT58DOEmfnGFmTZxGHOvIG4eYoT/dd1EOqpHvPLvP5JWyQtiz1XXBW8zovEwAxfRaa3ah+5FKPmQ2+COcBxgFsD70Ptg0R128G88zQlg8gICd232pkhqaICA92iMVjXxLGCws23xvFGUfHsxZCvVz1Foe7h2GPhKw1+ntBumxFVhPJJQrBzMZzDEk5txdP1Z6zrerc9ev/lSGSfisMge09L//jWj7K3Ut95IMxr5CQB3BMjilvz7zX7XuPZJdJP0Htb7/TjavNSKqBlsK+M9yh/P+pycUawwyri8cXLSybxRI3a8PSooSlqlFJY0EvdMqVf8TVaCPvD05QCrxDBGRTGShHVZttsHF2qO4GVFyVVRwrlHpyGxS95ddack0r9LreIW6whjwjOE5jZXZpZkpDd0MTjIy/+MI6oCEuc4VL13g= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;31:P9PkDy7QCT7aKVlU2LuYenrUkDI/8heBdGuXGCrajRnlaITj+vhL2CBV+xS4OwAsURi2VVzvfzMw3Ac72zmY1Vo5w/lsR85s/Dq3Jss2Eq1i2B9K9KD1464T46J5BcIH1p8rM8oTgh/PTeRFF4FmAs3Tqud575JD3PEhiiUjGeUtYOMstUJvsHSiAzBedeBvSfoCh5UYy0ixrpWz7F6Fqxl2RvbPw386zszmZQdAz277eOzD2JSO37qdtCLYvb/8Hktu5BIFFNcAExUHmaxU/1lQ9WOA57GiuL1E3p2ZtphfYZ7PRtuDzTqNcojED8BMGEgbC7q55xqPdb61oNL4jKme7kjb0+BkJGpIsIO3HyE3nlLKWj3Iy2F6UN/bT1JOJ3n0ODVVl1/Udse/Uxyz0cNIdyRZYPbqeKE+6zWLuoM697PA8JIJCK0lgntUocQGjf5vLqJay0Q2kqW9RhDlj6uqHpxLwRqCmNA2JO53W0SfE++qL1i9mYnaIytuSwEknth4/qJTlIqK+eCoCH4XXW2kXbs38p9aWdgpaUj7Y+Iz9+vos5Ql/ATGBDlsANLT45n/AFnBKyWEUcxjfDoiEwgy/s+IoEu9ch9lH/XNyiYGL5sBvjJrSEvKnnq+aelzfzng4HPe8PmRzRdCBmHxg440FEtuNbXZT+AG+ZSO6D4= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;20:q4it61XEVpgYPlsRWIwntxCGcq7fw1Ym4KlmM1yLEw4YeJ67F/a1kwpNq95W5c1Wu47gsAp4u8AEWM+e+Ok+PmdS+IGPoQYaYn2zfjxvlgJQLMQoLz0rXsGDQBElgMRwlSybD0rmY0hXHkXK1I5/DEPQWSbqQOKNXbomQFPuy8cFpp5GkL3KrBFxwfq+y/Fu4bqtDXjMa8uNaVlm0dSaYz5CpwvAQX+x1c3l9TZaCVb5tHZQw0duEfU37ixy7glwPs5qwbsw7/Gz0e8/ZIbfb5b8aIIyW4/rnGpQ/qlIqO6X37icqcZAD943ZJxK7okSk9rz5d9wv+m+ws4ysqh+hNJh4EnWPAdN5tEE2nelNPtj8/sE68BzHm9CMn6Hrs8aFCxjWi7kjTJuRT600LTAYsSEi5WG6Qnk0xg8aDJDb5b6cZdI+XJ/yxkdgQ0FPgjKRKdBpiC6vlbd5VB9EN9mhWvidB6RUENB/SEKOpiXktngr5OF2lJfhbHsiGAz3lPC X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR12MB1146;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR12MB1146; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ2OzQ6cnNYMlVGN3hLVUJuWmJkdlczdFR3NVV0NHk0?= =?utf-8?B?T002MlJpWlVBSDlsZmxvZ2tiMlVGYlp2czd4MHNMNzF3Uy9SaHk5RnBNRzI4?= =?utf-8?B?ZDlWeVAwRlk0QTBjQzZhQXZUSzRUeXJEc0FXaWNxNThvWVVIN1NXN3BKNWZP?= =?utf-8?B?UzdZakVMZEhRNlJlMURUU1J3OXF6UHhWaE00bU5wZnlUWUxuOEZ0MTZPakFG?= =?utf-8?B?Nllva09oNk4zL3ErZnM1TmRncEdmRHFBNmthaUk2U3ZXR3NQZHJZWlFEQ1U4?= =?utf-8?B?cmRyc2ROVVF4Y25oaE1SUlZBL29TWUdUdGg3WjJxa3NMUDRwYVVZVk9WWGR4?= =?utf-8?B?M3k4VDRuUktnR0xOOWd3Yy9oNWxKQmdtMFdrODFKMTZSdkd6MFljOXluL3Y5?= =?utf-8?B?MTg4Y05RUC9LVEEyK2NoVk92ZmVhVGl3OEJYSDhUc0RueUR0YlBHN3FNejRE?= =?utf-8?B?bkgvakFLMVBlU0g1bUNIdFJFbkhLTUFrMlpES2pMd2xwVC82RVJnZGprdW9P?= =?utf-8?B?eEtyODBXK1l0QUNERGl5blQ2TTFuKzBUL3JHUzNzaC9Ud1RLdUptNGphbG1M?= =?utf-8?B?QTE1RnBjeFg2NUg1dDAwRFRqZm1oclo3K3ltQ3FvVnhSWDRyWUpOSVJBeWQv?= =?utf-8?B?a1NmMXZsTjUxVVlvTlVJSElFZTNxcU1MMHdHSGVvQUdyRWV0QnFrOThmK0Ex?= =?utf-8?B?MWp2Q0QvcFFqNGJTTllPVGIxdjd6QU9RMFNFY203NTBUTWJ4bHZ4dDlGN3VG?= =?utf-8?B?b2FPNjZWSHk1bmFIU3Z1RldGcXlCWUNqUTdlN2psWklBMWNBL0hGRk0zaHlt?= =?utf-8?B?WWxxOERkSEo0Wm5Ld1FHMEQ3QzJjRGZHekRaUkQ2eVRKYVdrYlN2ZnhKNGVE?= =?utf-8?B?Nm9XYmwra01oU2Mwam54ZGw5TnBvby9zY0JyelVWQmhJWGJNbzQwdTZBS0NL?= =?utf-8?B?engvVHZhd1ptaDY3cnlXclgwczU3SlV3TXZiRlhLS2NSaGJhSVc2K2dVNWVs?= =?utf-8?B?MFphMlh3aG9DYTI2N2NnZXQxRzVkSk9rY3k5SGxYbmZXQWh6MkhaRXd2anlV?= =?utf-8?B?NUVUSTJuV3R3ekJaSHhuaDRQQ2VjUnRuTy8xeStqM0luaXhpQkhzUE8rZDIy?= =?utf-8?B?azM3RGlZNmFrRGFNUnBPTC95UHIxWlhVY0NVQXkzTXJzdDhwQ1ZNWlFKRjZv?= =?utf-8?B?VURSM1k0ajJhenBQS2pqeG5paUpnbVg2cU9oRTUzOXhpRWdDVmVQK010QWRZ?= =?utf-8?B?ZXV0eWtqWkFtVVB2RWE5UjExNUIwM21zTTFPczhaSWg5Qk8vWnlxODNlTUNy?= =?utf-8?B?b1NSR3NveHl6S3BzYXRiWFFUb1ZHamZvZlIxUWFqM2RJMTlyYmNhVzhqeERu?= =?utf-8?B?dXJUOUg4Lzl6bDBwS3U4V3pxTi9pMTRQWTRKMGtHUTNISzhncUFxQnZ5VW5G?= =?utf-8?B?VCt1a05OUnhRK3pRc2d5WDB5TkxWcERaSHg5MU9TcnNIaEtmemRibUxyUkRV?= =?utf-8?B?NEhXM1BlN0ZYZm1rejQ4VGVCZEJPLytRc2hFLzRsc2s2RURrdnN4djNVeEtj?= =?utf-8?B?U0d4QWtEYnRkSXltV0FnYWw4QkxDdz09?= X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39850400002)(39400400002)(39840400002)(39860400002)(39450400003)(39410400002)(377454003)(24454002)(54906002)(31686004)(7736002)(8676002)(5660300001)(81166006)(33646002)(65806001)(53546010)(53936002)(110136004)(38730400002)(6246003)(2906002)(65956001)(66066001)(7406005)(230700001)(478600001)(42186005)(83506001)(7416002)(6116002)(3846002)(189998001)(31696002)(77096006)(36756003)(86362001)(23676002)(64126003)(305945005)(50466002)(76176999)(72206003)(50986999)(54356999)(6486002)(229853002)(6666003)(3260700006)(4326008)(25786009)(47776003)(6916009)(2950100002)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1146;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ2OzIzOmVkazRnR2lrUzlsQXRPNnRPcmdYOVZjUTJp?= =?utf-8?B?d21wY29pS3lZdGNKQ0kyNjlPVWszQWZWTkwxYjUyRnl4SldKWnRtTHY0SG9y?= =?utf-8?B?Y3pCWVQzVG1VR2hsNnN6b3N3eHJ3QXVDY3NsSkhCenQ3aEhWYnV4cURyLzcr?= =?utf-8?B?a203bng0cjZ0Mlp2QkJFenpHbzVZdGdGbktsdzBTekhwYm8vcmtKTUFxTGVq?= =?utf-8?B?TE9TRTYzK0xYMFU3SVVKeG5sYWx4aU41a0l5RE9TcGVzS3FQdGpEajlpd3VE?= =?utf-8?B?QmpJSHdXRWN5RFdLaHRRUXpDMEZNWXpkK0cyYzl0SFF6QisxY3ZEWkdWYm5S?= =?utf-8?B?Vk8wa0luOXYrcEZ6d3d0MERxbzNhM1lySXM3UWxWaHBKV3M4WjEyeXVkdm1r?= =?utf-8?B?U0I1Z3R4QTdmZ2lkTS9VVm1xYVNCRmpBRXowRlNiMkNCaGgzaFBhVnVLbHpn?= =?utf-8?B?UUhOMmlSU3l1cVNoZnJGd2g2eHo4TWFmZHBwSldYbU1aSVZHbytoSHloVUxl?= =?utf-8?B?Rjd6eDlpcGdDUGQ3NDZaS1B1SXRoWUZLOVJ0RGhRK3FvemdaZ08vYkhDUklZ?= =?utf-8?B?bGJ6d09PdExHUTh0cHVEWUN4MUM5TGIxMVhnb05waUZSY1BzcEV1ODlmbGZz?= =?utf-8?B?dW5YUElYdVY4b2s1aXJ5VlZqS3k0V2xMYkJGOFlFZDJGK1FTOUprUEdEZHVw?= =?utf-8?B?eUYwY0lmYSswRXhITEliVFpPSHRrclhPNitRUHRaOHZHb0t2c0ZsRG1nU1R6?= =?utf-8?B?Ykg4OHJnN0VBMVNIb2EvendaWFVCRWtDdTg4V2JwbUFCam05Q2xCWVlOcFZI?= =?utf-8?B?KzhEYjNOVldWRDNuN0tKT0VGTmsyclIzT0Y1c3NPMHRaRlowcklNSXRUWFl5?= =?utf-8?B?QklDL0I3RWZIeWNBcnE2Z2ZWci9xQjNzNmZHZVI0M01obXlKRW1ldldacC9H?= =?utf-8?B?OEw2cmlvSjNRVnJQZG0zYjFQVnVLZW9QYkhqWFBnZzVESGVkWmJNeC9Nd2NP?= =?utf-8?B?WnNTTitibWpDUk15WVV0cnZocVBGaWNEcjhtbmtleVZGNFB6dFVOdnNoUnRz?= =?utf-8?B?UjJ2cnpVa0pFSlhrZ1BUNnpYQ0NqL0ZMN2tkcXVzQ09GblZhSGc3MWN6Umpp?= =?utf-8?B?eTVzVUJ0WEZvRUxrQnlaMjhUcFZ0Z0V0UFBnR1JlQ2hueGVJRURLRngrVVB2?= =?utf-8?B?SjRwUXR5aVFIUDE5QmNjbE1MUk9KUlFXS0lSbEY4c3k4Y2JkWW1Xbk0wM3Fu?= =?utf-8?B?V245SHVnMjgxVUd4WWpJZTZBV3drQ0JkOFpjS0l6MzJtR0E4Z2t0YnZ1UU12?= =?utf-8?B?Y3NCaGMzOVNzTEkySlB3VnJZZjZoZ3ZRU1FTZkx3bitSSnRoS2NoMElvanlR?= =?utf-8?B?OTlOSE0wdVFpd2tFWi9KR2JVUm9uNVpsLzJWTnhVRytlcm9jcGg1TStWR21G?= =?utf-8?B?SGJsN0VPV2w0WjQ0U0FVZE1OeHJJMWgycWMzdUV0MTRRZjdzT3BnYlNQLzVy?= =?utf-8?B?bTcwTmpoQ2ZpRXMrOCtTN3JzbElhL3RZc0gvTHVHZnF4YUQ4cWFFL0JMYStG?= =?utf-8?B?VXpzRWVNTndDZmo1M3psUUFlSTl4eW4wdFRxUHFwUmZKMnEyOXZhSWVMUXY0?= =?utf-8?B?WTRaVFFMRDFpWHAveWh6MGFrUjNUT2tZZkxWL3E4dk5RWVRrQjJwOXF3R1ds?= =?utf-8?B?bFJhRk9wUUZyWWE3NTRDbEpsYitSRnI0V2NzaGJNdEVHZGJ4UUlGNzJad3pM?= =?utf-8?B?UDNxUENLSnM4a29yd1BqZXlqWlNrSnBJVXRrcGNubGRXNk0vc2hlOFlOSzdZ?= =?utf-8?B?Tll1aUcxMFduMnZITE9td1daZ2d1V3FBcUxIbURWUzNzSkZ4ZVNMZE1jSE9C?= =?utf-8?B?MmFxMnRzaC9pWk5hTmdsekJweHhvUFdqeDlkelFtN1lXTXhCUFJUWURCZ3du?= =?utf-8?B?cDZCazdtMmdnPT0=?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ2OzY6c3JWb3V2R0VoMDI3K3luSzJxdlkvNDFUeVdL?= =?utf-8?B?L0tZdGRYRXRNTVdpSkhiZDh6Yk5WNzJEc1ZOY2V1Ynk3eDJURzZKNDRkSEJ6?= =?utf-8?B?WE1iZ0hidXdyUVBsdGVYemdGcDRacDlybTlRRHJZL09mN2JreGY5VTBmTzdS?= =?utf-8?B?UlFzdkQ1MXhsTi9wWVduWmd6MDFXMjdJUnhIZy9kMWo0Wm9FL3dWU2lETzFP?= =?utf-8?B?UEVIcHlwdjNJV1kzM3ZLVEVabjVBYVR4bDJVR1dyalR3SCtkbWVRVkFITGsr?= =?utf-8?B?ZmJQb3FZWStlWFRaaWVaMCtIbXNiMCt1cHF1V2NyUVdmbWdOanIvVWk5ZDdN?= =?utf-8?B?UmQ2aXFkSWx1TlRxRGtIeVVzc0FaNG1LckFqSEEzdU82SHRrNXVOMkxsZEU3?= =?utf-8?B?R2E0ZmhvblBNUmNPYk9Na2lndWVudnYxVnowR1hoczVBY09sajF4UXRZdk9H?= =?utf-8?B?S2pEcWJuTXhObllvakFLbnNJbDZuclVwKzA3TGNGd2I2SkhEd0FxNlNWRXZX?= =?utf-8?B?N1czcTdsWVNIcWoyN1BJSWlScnRxbGVJUXVJYzFkYSt4cm8rUkU5ZUMzT2Za?= =?utf-8?B?TlVsTTZDMU1zdm45NmxReGcxRFNxTFE1MFFSN0UvRGhsNlVMOXdGYklZZlQ5?= =?utf-8?B?SFRkcUNtZzczY3Z6RFlCQ1hEQTNYOWJQdnRBaERtRXdzaGRUTnFxbzV1Z1Rv?= =?utf-8?B?SzlnVGpUNEY2Y3Q0RmsyUGw0OE9SZWE0R1BUNmdCbEFYckJ4bC8vZWdpUGhi?= =?utf-8?B?dDlnVzVSMG0raVBLekJXWVpHMU5lYXp5WUNJZm1YcUhHWG9sY0h6MzBKL2VM?= =?utf-8?B?S0xYT2NkVzZQV2FxcU1GSlBmV1gyVzZkSExIZ3J2RENYVFM3UHo3M1laOXll?= =?utf-8?B?NTRFeWpaNStVYXg2eXE3dS9Jb1NnSXVJVDMycm5YUUIzQ1FIa1hCbEl3Q3FU?= =?utf-8?B?N05NL0llT25CNWVyWUYwS1B2U05RZU45Z290UDF2b3dBcExjbDByUjBER1dP?= =?utf-8?B?VFc3a3g1WU9LVlpvN3NvTWZ4RUNwWkhpWkYzYWtkekFzT1dVemsyTm41NWR1?= =?utf-8?B?UDluNkwxems1SDZUTUNrN1FRa0FmemJNZW5hMTQ2Yk03WHhxb3JCZ2g5L29Q?= =?utf-8?B?S1Z1aFVVNEYxOTVUcDhIejl5eWVHby9qeXowUjNNamxhZGhrUVhBSnl3MXRz?= =?utf-8?B?R1hUZElSUHJTaFVtajg2QTF6TzluYlFoeGptU2N3NHhuZmp5WWJFNXloNURD?= =?utf-8?B?a2IzNThJMVVnYVpTREVkcEhqQkFGK1Y0QkFCeFppTVgyUjI4SEJOWmhEeFlh?= =?utf-8?B?djg2b2NUc1F2VXhxN3BQV3NkRmg2NTNBU0owNk5LT2FxMGZOczdGbEkwTEVC?= =?utf-8?Q?YoOCg3I?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;5:n0+04+HC4Hc2U33FJ1zzjN+Re4FgoSDbZeIZkAqR/vJ0WTaNUAtW5YUv7LSvFNguqwcci6lYdyPMF32OogicrDpbT3sTXb9o4yUKnCWOvYkayuO8qXJ6kDih6qzmM9wspdK3LEHzOtosN1Usw9ZB7dTeHL+l+hviVQ3yFIgkKy+937OXR0n6TIIH8donsoaNn2/7Ztxg4k1hhGMWum3TMXiANxV14kML2FjT/wpCN8b6h1YvZ/81qC4WLZt/Vx93lm6JkJW6UMKqnoqD9MItx9Dr4PqJJHKynABZ+6x8yQxFkbS1Vgrs156v3vFen3dzB2brJD+xOA89Kk/CDm+aW4T7t+sdTh91ryDxYMY9XODYKKsg3agH/xMqASDsVbhfsE9lyW0Wu/R7I+zT7+kGaUTXiD27BU4C3/4Y6yZ+Rkpjhs4DGKsavaxzlUzCc5mIZSsLzgR2u4YDWqoIwm3ZBfy6n3mNdyHgIhWtFdQcMnSUF/1HqBqVCI33ElpUg/Xz;24:bQbizZ+fLQnAbBDWqWqd2m3GohWyAv1bmpmwTuVYzOBibYZtCwAxTqsUtaC9VcqVd10Cc4bIDvS2mdqVh8Yn3bvPIAMBSPILizBu1S6OiGA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;7:VCGaAqu8Wiyax4Z4JB1SGTkv1hB37Nua2chOWKD5D1Q4V+59sxYNC0PGBjRE9bkoU5GXiQvpypx3pCFeGA2BCQq5PMalpUSbz7dBK2ies6VSRmrK4FsQW8POXbgguyjclE3ILTK4deKWaQYcM2Q3En23Ya1Fvjy66fEGEH4h8Dm974o7gmn4R+MrFlPw/cTaryJb2kR0sRl3Qs3ydaEUk0L0EW79uLxJwAnpf52F4ushuvl+sbTRHjaEExXjREK2Dva4B79TSgloPuY7JGHc/qgGEUb5PFnfFbVzDCthdaUXzBXN7uMd+4mJT9La+ZmUPYURUbaCpSB8ZsA+f+T1SKzzEhjSyrp2kE5Dq17ED3oQMr5So8Bwc4HJSTxtnpsGPEAqcfjoSVoF5jAJA6Gp4BPP5bMbWqu8LshsS3pyRpNiOnSTaBCDe6ggRJUI7dwGpdgpNffsk5KAKFMPLxTbncBLU9YhzUF0VTdZ9PEIz3rVuCC5Y+n2C06VaX/u/5zp7GpVX5PXXYqz6RaskaETxcQ4pqgkKe3Ochffycc5mmgjPaAIcSx2QQJXO5VgMAidyPCFT/y/mNGkchpmSJU3sB3hrad2bm6o7mb9TowY7xyAumI2S/pW/UdFRH7RbDt11Zd4BYCggZrxd1p+rVrQNhxm6cv8a5GvbZT5hMLdrPATYoA7yGcLDGDtREQfxT/t9tt+Dy9+olDTpywFt/wmEuI6tEcSzZb2GNRuoxZYp6U14gFgnhQnO7bUMNQUympeGJ7c+HTlEbgCmfumz9N5MmV68KOMygmG7OoQiKtdwHo= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;20:kOEd2sYco8WfdnT6/okEI28V/4y9nn9flM4d3lx/zF7eefHOAit2Pjyz8/pt3gPoiKKZh4M+bdOhebFZjiPs4LG38QZGrQ5SxsTsMToN2xuOou/NA5AogYifR/XaRMgrCLc9mYCmLlCm61XcU69CsRmjbqtgK2vpJexE4EkfodWiRRlI4e0PLYXpunXjGhwLf0adP72/O6gFVpgaj4PPmUrfHS+5l4yDHTXZ/kMthoCCGBIur/Ub88LiTFW9m5Nq X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2017 13:52:57.0294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1146 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/20/2017 3:55 PM, Thomas Gleixner wrote: > On Fri, 16 Jun 2017, Tom Lendacky wrote: > >> Currently there is a check if the address being mapped is in the ISA >> range (is_ISA_range()), and if it is then phys_to_virt() is used to >> perform the mapping. When SME is active, however, this will result >> in the mapping having the encryption bit set when it is expected that >> an ioremap() should not have the encryption bit set. So only use the >> phys_to_virt() function if SME is not active > > This does not make sense to me. What the heck has phys_to_virt() to do with > the encryption bit. Especially why would the encryption bit be set on that > mapping in the first place? The default is that all entries that get added to the pagetables have the encryption bit set unless specifically overridden. Any __va() or phys_to_virt() calls will result in a pagetable mapping that has the encryption bit set. For ioremap, the PAGE_KERNEL_IO protection is used which will not/does not have the encryption bit set. > > I'm probably missing something, but this want's some coherent explanation > understandable by mere mortals both in the changelog and the code comment. I'll add some additional info to the changelog and code. Thanks, Tom > > Thanks, > > tglx > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Lendacky Subject: Re: [PATCH v7 07/36] x86/mm: Don't use phys_to_virt in ioremap() if SME is active Date: Wed, 21 Jun 2017 08:52:53 -0500 Message-ID: References: <20170616184947.18967.84890.stgit@tlendack-t1.amdoffice.net> <20170616185104.18967.7867.stgit@tlendack-t1.amdoffice.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Thomas Gleixner Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Brijesh Singh , Toshimitsu Kani , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matt Fleming , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jonathan Corbet , "Michael S. Tsirkin" , kasan-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Borislav Petkov , Andy Lutomirski , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , kexe List-Id: linux-efi@vger.kernel.org On 6/20/2017 3:55 PM, Thomas Gleixner wrote: > On Fri, 16 Jun 2017, Tom Lendacky wrote: > >> Currently there is a check if the address being mapped is in the ISA >> range (is_ISA_range()), and if it is then phys_to_virt() is used to >> perform the mapping. When SME is active, however, this will result >> in the mapping having the encryption bit set when it is expected that >> an ioremap() should not have the encryption bit set. So only use the >> phys_to_virt() function if SME is not active > > This does not make sense to me. What the heck has phys_to_virt() to do with > the encryption bit. Especially why would the encryption bit be set on that > mapping in the first place? The default is that all entries that get added to the pagetables have the encryption bit set unless specifically overridden. Any __va() or phys_to_virt() calls will result in a pagetable mapping that has the encryption bit set. For ioremap, the PAGE_KERNEL_IO protection is used which will not/does not have the encryption bit set. > > I'm probably missing something, but this want's some coherent explanation > understandable by mere mortals both in the changelog and the code comment. I'll add some additional info to the changelog and code. Thanks, Tom > > Thanks, > > tglx > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id BC3096B03FB for ; Wed, 21 Jun 2017 09:53:04 -0400 (EDT) Received: by mail-pg0-f69.google.com with SMTP id b13so175949315pgn.4 for ; Wed, 21 Jun 2017 06:53:04 -0700 (PDT) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0070.outbound.protection.outlook.com. [104.47.41.70]) by mx.google.com with ESMTPS id d17si14553009plj.367.2017.06.21.06.53.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Jun 2017 06:53:03 -0700 (PDT) Subject: Re: [PATCH v7 07/36] x86/mm: Don't use phys_to_virt in ioremap() if SME is active References: <20170616184947.18967.84890.stgit@tlendack-t1.amdoffice.net> <20170616185104.18967.7867.stgit@tlendack-t1.amdoffice.net> From: Tom Lendacky Message-ID: Date: Wed, 21 Jun 2017 08:52:53 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Thomas Gleixner Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, xen-devel@lists.xen.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Brijesh Singh , Toshimitsu Kani , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matt Fleming , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , Jonathan Corbet , Joerg Roedel , "Michael S. Tsirkin" , Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Borislav Petkov , Andy Lutomirski , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , Paolo Bonzini On 6/20/2017 3:55 PM, Thomas Gleixner wrote: > On Fri, 16 Jun 2017, Tom Lendacky wrote: > >> Currently there is a check if the address being mapped is in the ISA >> range (is_ISA_range()), and if it is then phys_to_virt() is used to >> perform the mapping. When SME is active, however, this will result >> in the mapping having the encryption bit set when it is expected that >> an ioremap() should not have the encryption bit set. So only use the >> phys_to_virt() function if SME is not active > > This does not make sense to me. What the heck has phys_to_virt() to do with > the encryption bit. Especially why would the encryption bit be set on that > mapping in the first place? The default is that all entries that get added to the pagetables have the encryption bit set unless specifically overridden. Any __va() or phys_to_virt() calls will result in a pagetable mapping that has the encryption bit set. For ioremap, the PAGE_KERNEL_IO protection is used which will not/does not have the encryption bit set. > > I'm probably missing something, but this want's some coherent explanation > understandable by mere mortals both in the changelog and the code comment. I'll add some additional info to the changelog and code. Thanks, Tom > > Thanks, > > tglx > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-sn1nam01on0611.outbound.protection.outlook.com ([2a01:111:f400:fe40::611] helo=NAM01-SN1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dNg4S-0006gB-JH for kexec@lists.infradead.org; Wed, 21 Jun 2017 13:53:26 +0000 Subject: Re: [PATCH v7 07/36] x86/mm: Don't use phys_to_virt in ioremap() if SME is active References: <20170616184947.18967.84890.stgit@tlendack-t1.amdoffice.net> <20170616185104.18967.7867.stgit@tlendack-t1.amdoffice.net> From: Tom Lendacky Message-ID: Date: Wed, 21 Jun 2017 08:52:53 -0500 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Thomas Gleixner Cc: linux-efi@vger.kernel.org, Brijesh Singh , Toshimitsu Kani , linux-doc@vger.kernel.org, Matt Fleming , x86@kernel.org, linux-mm@kvack.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , linux-arch@vger.kernel.org, kvm@vger.kernel.org, Jonathan Corbet , Joerg Roedel , "Michael S. Tsirkin" , kasan-dev@googlegroups.com, Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Borislav Petkov , Andy Lutomirski , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, iommu@lists.linux-foundation.org, Paolo Bonzini On 6/20/2017 3:55 PM, Thomas Gleixner wrote: > On Fri, 16 Jun 2017, Tom Lendacky wrote: > >> Currently there is a check if the address being mapped is in the ISA >> range (is_ISA_range()), and if it is then phys_to_virt() is used to >> perform the mapping. When SME is active, however, this will result >> in the mapping having the encryption bit set when it is expected that >> an ioremap() should not have the encryption bit set. So only use the >> phys_to_virt() function if SME is not active > > This does not make sense to me. What the heck has phys_to_virt() to do with > the encryption bit. Especially why would the encryption bit be set on that > mapping in the first place? The default is that all entries that get added to the pagetables have the encryption bit set unless specifically overridden. Any __va() or phys_to_virt() calls will result in a pagetable mapping that has the encryption bit set. For ioremap, the PAGE_KERNEL_IO protection is used which will not/does not have the encryption bit set. > > I'm probably missing something, but this want's some coherent explanation > understandable by mere mortals both in the changelog and the code comment. I'll add some additional info to the changelog and code. Thanks, Tom > > Thanks, > > tglx > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec