From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933056AbcDTItq (ORCPT ); Wed, 20 Apr 2016 04:49:46 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.168]:53631 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbcDTItl convert rfc822-to-8bit (ORCPT ); Wed, 20 Apr 2016 04:49:41 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJKsWRWlGSWpSXmKPExsVyU6aHU3eBk3i 4wb2pfBZzzrewWCyePIvdYuUUFovLu+awWcxe0s9icfVBucWxBWIW+694OXB4fPs6icVjy8qb TB47Z91l9zh+YzuTx+dNcgGsUayZeUn5FQmsGb9O7mcs2MZesf/XEqYGxu+sXYxcHEICWxglz hz8xATh7GWUmPhpE5DDycEmYCax69U6dhBbREBNYuKJCcwgRcwC35kk7s6+ygiSEBZIlHgwbx MjRFGSxLq1L5ggbCuJHTf/ATVwcLAIqEr8W8EHYvIKuEo82S8EsauDUWLf9p1grZxA8f5HF8F 2MQrISnxpXM0MYjMLiEvcejIfbKSEgIDEkj3nmSFsUYmXj/+xQtgGEluX7mOBsBUkfvSegqqx lvj34C4TxBwdiQW7P7FB2NoSyxa+BqvhFRCUODnzCcsERrFZSNbNQtIyC0nLLCQtCxhZVjFqF KcWlaUW6Rqa6CUVZaZnlOQmZuboGhoY6+WmFhcnpqfmJCYV6yXn525iBEYrAxDsYFyx3fMQoy QHk5Ior6qAeLgQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCV5zR6CcYFFqempFWmYOMG3ApCU4eJR EeJNA0rzFBYm5xZnpEKlTjLocC37cXsskxJKXn5cqJc7LBVIkAFKUUZoHNwKWwi4xykoJ8zIC HSXEU5BalJtZgir/ilGcg1FJmPcNyBSezLwSuE2vgI5gAjqC/64oyBEliQgpqQZGudYFDOFuW w9X7Wqv2PE7VmD3Twney3u+TtK2lY4W/bzDp59fjVO6/snPCz8TY6c0zXZNemHNzb5LYuvNWb FG7lfvHfty7XBQXbgFx5nsqTYz/KbXu7Xprkrc/tlCdfZ9S52r9jLLOML3O9zcbx3g4Hh4xTK 3CxNXJq/p9dC4HzC5V/l3hMMBJZbijERDLeai4kQApJd98VwDAAA= X-Env-Sender: andrew.goodbody@cambrionix.com X-Msg-Ref: server-10.tower-139.messagelabs.com!1461142173!10021371!6 X-Originating-IP: [217.28.140.9] X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked From: Andrew Goodbody To: David Miller CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David Rivshin (Allworx)" , "grygorii.strashko@ti.com" , "mugunthanvnm@ti.com" , "linux-omap@vger.kernel.org" , "tony@atomide.com" Subject: RE: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Thread-Topic: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Thread-Index: AQHRmXnAlBr6bWQGK06IU9TOtv6vZ5+R798AgACdYCA= Date: Wed, 20 Apr 2016 08:49:34 +0000 Message-ID: References: <1460987606-18125-1-git-send-email-andrew.goodbody@cambrionix.com> <20160419.201550.902520333910307559.davem@davemloft.net> In-Reply-To: <20160419.201550.902520333910307559.davem@davemloft.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [46.17.166.30] x-exclaimer-md-config: 266e7a57-cddd-49fd-bdea-19bca6d40303 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Andrew Goodbody > Date: Mon, 18 Apr 2016 14:53:25 +0100 > > > This is a fix for a NULL pointer dereference from cpsw which is > > triggered by having two slave PHYs attached to a cpsw network device. > > The problem is due to only maintaining a single reference to a PHY > > node in the prive data which gets overwritten by the second PHY probe. > > So move the PHY node reference to the individual slave data so that there > is now one per slave. > > > > v1 had a problem that data->slaves was used before it had been filled > > in > > I already applied v1 the other day, so you need to send me a relative patch > rather than a whole new one. > > Thanks. Sorry, I had no notification that this had happened. However I thought that the plan was to revert v1 and go with David Rivshin's patch instead. I'll see if I can create a revert in a little while. Andrew