Re: [PATCH 4/4] MAINTAINERS: Add git tree and missing files for KPROBES

From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: naveen.n.rao@linux.ibm.com, anil.s.keshavamurthy@intel.com,
	davem@davemloft.net, corbet@lwn.net, ananth@in.ibm.com,
	akpm@linux-foundation.org, randy.dunlap@oracle.com,
	mathieu.desnoyers@polymtl.ca, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 4/4] MAINTAINERS: Add git tree and missing files for KPROBES
Date: Mon, 25 Oct 2021 16:31:07 +0800	[thread overview]
Message-ID: <c10e50c8-081b-aca6-eefe-eac463cb5a30@loongson.cn> (raw)
In-Reply-To: <20211025153821.baa3f5d90fd40943ee28d2e1@kernel.org>

On 10/25/2021 02:38 PM, Masami Hiramatsu wrote:
> On Mon, 25 Oct 2021 11:31:00 +0800
> Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
>> There is no git tree for KPROBES in MAINTAINERS, it is not convinent to
>> rebase, lib/test_kprobes.c and samples/kprobes belong to kprobe, add them.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>   MAINTAINERS | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 4372473..0e9bc60 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -10506,10 +10506,13 @@ M:	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>>   M:	"David S. Miller" <davem@davemloft.net>
>>   M:	Masami Hiramatsu <mhiramat@kernel.org>
>>   S:	Maintained
>> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mhiramat/linux.git
> NACK. As I said, this branch was prepared when I discussed with tip maintainer
> on kretprobe stackfix series but now it has been maintained on Steve's tracing
> tree.
>
> Steve, should we put your tree here?

If yes, should I update patch #4 and then send a v2 version of this 
patch set?

@@ -10505,11 +10505,16 @@ M:    Naveen N. Rao <naveen.n.rao@linux.ibm.com>
  M:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
  M:     "David S. Miller" <davem@davemloft.net>
  M:     Masami Hiramatsu <mhiramat@kernel.org>
+L:     linux-trace-devel@vger.kernel.org
  S:     Maintained
+Q:     https://patchwork.kernel.org/project/linux-trace-devel/list/
+T:     git 
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
  F:     Documentation/trace/kprobes.rst
  F:     include/asm-generic/kprobes.h
  F:     include/linux/kprobes.h
  F:     kernel/kprobes.c
+F:     lib/test_kprobes.c
+F:     samples/kprobes

By the way, it seems that we should also update the TRACING git tree [1]?
If yes, should I send the following change as a new patch #5 in the v2 
version
or do the following change in the above patch #4?

@@ -19065,8 +19070,10 @@ F:     drivers/char/tpm/
  TRACING
  M:     Steven Rostedt <rostedt@goodmis.org>
  M:     Ingo Molnar <mingo@redhat.com>
+L:     linux-trace-devel@vger.kernel.org
  S:     Maintained
-T:     git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 
perf/core
+Q:     https://patchwork.kernel.org/project/linux-trace-devel/list/
+T:     git 
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
  F:     Documentation/trace/ftrace.rst
  F:     arch/*/*/*/ftrace.h
  F:     arch/*/kernel/ftrace.c

  [1] 
https://lore.kernel.org/lkml/20211019091344.65629198@gandalf.local.home/

  Thanks,
  Tiezhu

>
> Anyway, I will pick your [1/4]-[3/4].
>
> Thank you,
>
>>   F:	Documentation/trace/kprobes.rst
>>   F:	include/asm-generic/kprobes.h
>>   F:	include/linux/kprobes.h
>>   F:	kernel/kprobes.c
>> +F:	lib/test_kprobes.c
>> +F:	samples/kprobes
>>   
>>   KS0108 LCD CONTROLLER DRIVER
>>   M:	Miguel Ojeda <ojeda@kernel.org>
>> -- 
>> 2.1.0
>>
>

