From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D93C43331 for ; Thu, 2 Apr 2020 03:23:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD4E420721 for ; Thu, 2 Apr 2020 03:23:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SzffjfHO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733303AbgDBDXW (ORCPT ); Wed, 1 Apr 2020 23:23:22 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:34530 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732664AbgDBDXW (ORCPT ); Wed, 1 Apr 2020 23:23:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585797800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lo4oQtgFAkpJN5E5vhIt9kZ5uAzDrIArkXhNzR8IY6M=; b=SzffjfHO3AHKJaXqg6ZrprsefUaT4OlQUvMUDoStAFIKqctR467igNRQPCpRdZ4AKfycQO 8+u0zOzpp4w23SlT+VGX3F28Jif8Wjp9WYpjmpRXqo8ZZWzgG7zZJmJVLO7Nls5oJWC3dG vNtVmla3SKNbt+ZExvaAEvmx2KBb1qs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-LVyMK6ydO8Sv_d3yw-jCFQ-1; Wed, 01 Apr 2020 23:23:18 -0400 X-MC-Unique: LVyMK6ydO8Sv_d3yw-jCFQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 125D218A5511; Thu, 2 Apr 2020 03:23:16 +0000 (UTC) Received: from [10.72.13.209] (ovpn-13-209.pek2.redhat.com [10.72.13.209]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8EEDE89F0A; Thu, 2 Apr 2020 03:22:59 +0000 (UTC) Subject: Re: [PATCH V9 1/9] vhost: refine vhost and vringh kconfig To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, jgg@mellanox.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, lingshan.zhu@intel.com, eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com, kevin.tian@intel.com, stefanha@redhat.com, rdunlap@infradead.org, hch@infradead.org, aadam@redhat.com, jiri@mellanox.com, shahafs@mellanox.com, hanand@xilinx.com, mhabets@solarflare.com, gdawar@xilinx.com, saugatm@xilinx.com, vmireyno@marvell.com, zhangweining@ruijie.com.cn References: <20200326140125.19794-1-jasowang@redhat.com> <20200326140125.19794-2-jasowang@redhat.com> <20200401092004-mutt-send-email-mst@kernel.org> <6b4d169a-9962-6014-5423-1507059343e9@redhat.com> <20200401100954-mutt-send-email-mst@kernel.org> <3dd3b7e7-e3d9-dba4-00fc-868081f95ab7@redhat.com> <20200401120643-mutt-send-email-mst@kernel.org> From: Jason Wang Message-ID: Date: Thu, 2 Apr 2020 11:22:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200401120643-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/2 =E4=B8=8A=E5=8D=8812:08, Michael S. Tsirkin wrote: > On Wed, Apr 01, 2020 at 10:29:32PM +0800, Jason Wang wrote: >> >From 9b3a5d23b8bf6b0a11e65e688335d782f8e6aa5c Mon Sep 17 00:00:00 200= 1 >> From: Jason Wang >> Date: Wed, 1 Apr 2020 22:17:27 +0800 >> Subject: [PATCH] vhost: let CONFIG_VHOST to be selected by drivers >> >> The defconfig on some archs enable vhost_net or vhost_vsock by >> default. So instead of adding CONFIG_VHOST=3Dm to all of those files, >> simply letting CONFIG_VHOST to be selected by all of the vhost >> drivers. This fixes the build on the archs with CONFIG_VHOST_NET=3Dm i= n >> their defconfig. >> >> Signed-off-by: Jason Wang >> --- >> drivers/vhost/Kconfig | 15 +++++++++++---- >> 1 file changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig >> index 2523a1d4290a..362b832f5338 100644 >> --- a/drivers/vhost/Kconfig >> +++ b/drivers/vhost/Kconfig >> @@ -11,19 +11,23 @@ config VHOST_RING >> This option is selected by any driver which needs to access >> the host side of a virtio ring. >> =20 >> -menuconfig VHOST >> - tristate "Host kernel accelerator for virtio (VHOST)" >> - depends on EVENTFD >> +config VHOST >> + tristate >> select VHOST_IOTLB >> help >> This option is selected by any driver which needs to access >> the core of vhost. >> =20 >> -if VHOST >> +menuconfig VHOST_MENU >> + bool "VHOST drivers" >> + default y >> + >> +if VHOST_MENU >> =20 >> config VHOST_NET >> tristate "Host kernel accelerator for virtio net" >> depends on NET && EVENTFD && (TUN || !TUN) && (TAP || !TAP) >> + select VHOST >> ---help--- >> This kernel module can be loaded in host kernel to accelerate >> guest networking with virtio_net. Not to be confused with virtio_= net >> @@ -35,6 +39,7 @@ config VHOST_NET >> config VHOST_SCSI >> tristate "VHOST_SCSI TCM fabric driver" >> depends on TARGET_CORE && EVENTFD >> + select VHOST >> default n >> ---help--- >> Say M here to enable the vhost_scsi TCM fabric module >> @@ -43,6 +48,7 @@ config VHOST_SCSI >> config VHOST_VSOCK >> tristate "vhost virtio-vsock driver" >> depends on VSOCKETS && EVENTFD >> + select VHOST >> select VIRTIO_VSOCKETS_COMMON >> default n >> ---help--- >> @@ -56,6 +62,7 @@ config VHOST_VSOCK >> config VHOST_VDPA >> tristate "Vhost driver for vDPA-based backend" >> depends on EVENTFD >> + select VHOST This part is not squashed. >> select VDPA >> help >> This kernel module can be loaded in host kernel to accelerate > OK so I squashed this into the original buggy patch. > Could you please play with vhost branch of my tree on various > arches? If it looks ok to you let me know I'll push > this to next. With the above part squashed. I've tested all the archs whose defconfig=20 have VHOST_NET or VHOST_VSOCK enabled. All looks fine. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH V9 1/9] vhost: refine vhost and vringh kconfig Date: Thu, 2 Apr 2020 11:22:57 +0800 Message-ID: References: <20200326140125.19794-1-jasowang@redhat.com> <20200326140125.19794-2-jasowang@redhat.com> <20200401092004-mutt-send-email-mst@kernel.org> <6b4d169a-9962-6014-5423-1507059343e9@redhat.com> <20200401100954-mutt-send-email-mst@kernel.org> <3dd3b7e7-e3d9-dba4-00fc-868081f95ab7@redhat.com> <20200401120643-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20200401120643-mutt-send-email-mst@kernel.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: "Michael S. Tsirkin" Cc: kvm@vger.kernel.org, mhabets@solarflare.com, virtualization@lists.linux-foundation.org, rob.miller@broadcom.com, saugatm@xilinx.com, lulu@redhat.com, hanand@xilinx.com, hch@infradead.org, eperezma@redhat.com, jgg@mellanox.com, shahafs@mellanox.com, parav@mellanox.com, vmireyno@marvell.com, gdawar@xilinx.com, jiri@mellanox.com, xiao.w.wang@intel.com, stefanha@redhat.com, zhihong.wang@intel.com, zhangweining@ruijie.com.cn, netdev@vger.kernel.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, lingshan.zhu@intel.com List-Id: virtualization@lists.linuxfoundation.org Ck9uIDIwMjAvNC8yIOS4iuWNiDEyOjA4LCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gT24g V2VkLCBBcHIgMDEsIDIwMjAgYXQgMTA6Mjk6MzJQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90ZToK Pj4gPkZyb20gOWIzYTVkMjNiOGJmNmIwYTExZTY1ZTY4ODMzNWQ3ODJmOGU2YWE1YyBNb24gU2Vw IDE3IDAwOjAwOjAwIDIwMDEKPj4gRnJvbTogSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNv bT4KPj4gRGF0ZTogV2VkLCAxIEFwciAyMDIwIDIyOjE3OjI3ICswODAwCj4+IFN1YmplY3Q6IFtQ QVRDSF0gdmhvc3Q6IGxldCBDT05GSUdfVkhPU1QgdG8gYmUgc2VsZWN0ZWQgYnkgZHJpdmVycwo+ Pgo+PiBUaGUgZGVmY29uZmlnIG9uIHNvbWUgYXJjaHMgZW5hYmxlIHZob3N0X25ldCBvciB2aG9z dF92c29jayBieQo+PiBkZWZhdWx0LiBTbyBpbnN0ZWFkIG9mIGFkZGluZyBDT05GSUdfVkhPU1Q9 bSB0byBhbGwgb2YgdGhvc2UgZmlsZXMsCj4+IHNpbXBseSBsZXR0aW5nIENPTkZJR19WSE9TVCB0 byBiZSBzZWxlY3RlZCBieSBhbGwgb2YgdGhlIHZob3N0Cj4+IGRyaXZlcnMuIFRoaXMgZml4ZXMg dGhlIGJ1aWxkIG9uIHRoZSBhcmNocyB3aXRoIENPTkZJR19WSE9TVF9ORVQ9bSBpbgo+PiB0aGVp ciBkZWZjb25maWcuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEphc29uIFdhbmcgPGphc293YW5nQHJl ZGhhdC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvdmhvc3QvS2NvbmZpZyB8IDE1ICsrKysrKysr KysrLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9u cygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aG9zdC9LY29uZmlnIGIvZHJpdmVycy92 aG9zdC9LY29uZmlnCj4+IGluZGV4IDI1MjNhMWQ0MjkwYS4uMzYyYjgzMmY1MzM4IDEwMDY0NAo+ PiAtLS0gYS9kcml2ZXJzL3Zob3N0L0tjb25maWcKPj4gKysrIGIvZHJpdmVycy92aG9zdC9LY29u ZmlnCj4+IEBAIC0xMSwxOSArMTEsMjMgQEAgY29uZmlnIFZIT1NUX1JJTkcKPj4gICAJICBUaGlz IG9wdGlvbiBpcyBzZWxlY3RlZCBieSBhbnkgZHJpdmVyIHdoaWNoIG5lZWRzIHRvIGFjY2Vzcwo+ PiAgIAkgIHRoZSBob3N0IHNpZGUgb2YgYSB2aXJ0aW8gcmluZy4KPj4gICAKPj4gLW1lbnVjb25m aWcgVkhPU1QKPj4gLQl0cmlzdGF0ZSAiSG9zdCBrZXJuZWwgYWNjZWxlcmF0b3IgZm9yIHZpcnRp byAoVkhPU1QpIgo+PiAtCWRlcGVuZHMgb24gRVZFTlRGRAo+PiArY29uZmlnIFZIT1NUCj4+ICsJ dHJpc3RhdGUKPj4gICAJc2VsZWN0IFZIT1NUX0lPVExCCj4+ICAgCWhlbHAKPj4gICAJICBUaGlz IG9wdGlvbiBpcyBzZWxlY3RlZCBieSBhbnkgZHJpdmVyIHdoaWNoIG5lZWRzIHRvIGFjY2Vzcwo+ PiAgIAkgIHRoZSBjb3JlIG9mIHZob3N0Lgo+PiAgIAo+PiAtaWYgVkhPU1QKPj4gK21lbnVjb25m aWcgVkhPU1RfTUVOVQo+PiArCWJvb2wgIlZIT1NUIGRyaXZlcnMiCj4+ICsJZGVmYXVsdCB5Cj4+ ICsKPj4gK2lmIFZIT1NUX01FTlUKPj4gICAKPj4gICBjb25maWcgVkhPU1RfTkVUCj4+ICAgCXRy aXN0YXRlICJIb3N0IGtlcm5lbCBhY2NlbGVyYXRvciBmb3IgdmlydGlvIG5ldCIKPj4gICAJZGVw ZW5kcyBvbiBORVQgJiYgRVZFTlRGRCAmJiAoVFVOIHx8ICFUVU4pICYmIChUQVAgfHwgIVRBUCkK Pj4gKwlzZWxlY3QgVkhPU1QKPj4gICAJLS0taGVscC0tLQo+PiAgIAkgIFRoaXMga2VybmVsIG1v ZHVsZSBjYW4gYmUgbG9hZGVkIGluIGhvc3Qga2VybmVsIHRvIGFjY2VsZXJhdGUKPj4gICAJICBn dWVzdCBuZXR3b3JraW5nIHdpdGggdmlydGlvX25ldC4gTm90IHRvIGJlIGNvbmZ1c2VkIHdpdGgg dmlydGlvX25ldAo+PiBAQCAtMzUsNiArMzksNyBAQCBjb25maWcgVkhPU1RfTkVUCj4+ICAgY29u ZmlnIFZIT1NUX1NDU0kKPj4gICAJdHJpc3RhdGUgIlZIT1NUX1NDU0kgVENNIGZhYnJpYyBkcml2 ZXIiCj4+ICAgCWRlcGVuZHMgb24gVEFSR0VUX0NPUkUgJiYgRVZFTlRGRAo+PiArCXNlbGVjdCBW SE9TVAo+PiAgIAlkZWZhdWx0IG4KPj4gICAJLS0taGVscC0tLQo+PiAgIAlTYXkgTSBoZXJlIHRv IGVuYWJsZSB0aGUgdmhvc3Rfc2NzaSBUQ00gZmFicmljIG1vZHVsZQo+PiBAQCAtNDMsNiArNDgs NyBAQCBjb25maWcgVkhPU1RfU0NTSQo+PiAgIGNvbmZpZyBWSE9TVF9WU09DSwo+PiAgIAl0cmlz dGF0ZSAidmhvc3QgdmlydGlvLXZzb2NrIGRyaXZlciIKPj4gICAJZGVwZW5kcyBvbiBWU09DS0VU UyAmJiBFVkVOVEZECj4+ICsJc2VsZWN0IFZIT1NUCj4+ICAgCXNlbGVjdCBWSVJUSU9fVlNPQ0tF VFNfQ09NTU9OCj4+ICAgCWRlZmF1bHQgbgo+PiAgIAktLS1oZWxwLS0tCj4+IEBAIC01Niw2ICs2 Miw3IEBAIGNvbmZpZyBWSE9TVF9WU09DSwo+PiAgIGNvbmZpZyBWSE9TVF9WRFBBCj4+ICAgCXRy aXN0YXRlICJWaG9zdCBkcml2ZXIgZm9yIHZEUEEtYmFzZWQgYmFja2VuZCIKPj4gICAJZGVwZW5k cyBvbiBFVkVOVEZECj4+ICsJc2VsZWN0IFZIT1NUCgoKVGhpcyBwYXJ0IGlzIG5vdCBzcXVhc2hl ZC4KCgo+PiAgIAlzZWxlY3QgVkRQQQo+PiAgIAloZWxwCj4+ICAgCSAgVGhpcyBrZXJuZWwgbW9k dWxlIGNhbiBiZSBsb2FkZWQgaW4gaG9zdCBrZXJuZWwgdG8gYWNjZWxlcmF0ZQo+IE9LIHNvIEkg c3F1YXNoZWQgdGhpcyBpbnRvIHRoZSBvcmlnaW5hbCBidWdneSBwYXRjaC4KPiBDb3VsZCB5b3Ug cGxlYXNlIHBsYXkgd2l0aCB2aG9zdCBicmFuY2ggb2YgbXkgdHJlZSBvbiB2YXJpb3VzCj4gYXJj aGVzPyBJZiBpdCBsb29rcyBvayB0byB5b3UgbGV0IG1lIGtub3cgSSdsbCBwdXNoCj4gdGhpcyB0 byBuZXh0LgoKCldpdGggdGhlIGFib3ZlIHBhcnQgc3F1YXNoZWQuIEkndmUgdGVzdGVkIGFsbCB0 aGUgYXJjaHMgd2hvc2UgZGVmY29uZmlnIApoYXZlIFZIT1NUX05FVCBvciBWSE9TVF9WU09DSyBl bmFibGVkLgoKQWxsIGxvb2tzIGZpbmUuCgpUaGFua3MKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0 dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4 Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==