From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C0EC4332F for ; Sun, 6 Nov 2022 11:32:35 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DFA040156; Sun, 6 Nov 2022 12:32:34 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0642A4003C for ; Sun, 6 Nov 2022 12:32:33 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 729985A; Sun, 6 Nov 2022 14:32:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 729985A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667734352; bh=OCP35Ox072Bby5LoE1ESzD3dDqmnMHhvVbWs4pp8PN8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uAJMwSsJGba13U1gx94GwkRU/9BZq6qZcBpOii2yGYyk5hxXWJsY0GcyxzZ3K+O/8 86oxwst8ayUzUkBFkQgiGUsoqbdObwzziCjIK+xLHISie1upcVtomOy+uHRx2LWWQr 37x/wzZrTlwoIMZekdIL9cjUeUs+6QINb/m542os= Message-ID: Date: Sun, 6 Nov 2022 14:32:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v4 1/3] mempool: split stats from debug Content-Language: en-US To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , olivier.matz@6wind.com, mattias.ronnblom@ericsson.com, stephen@networkplumber.org, jerinj@marvell.com, bruce.richardson@intel.com Cc: hofors@lysator.liu.se, thomas@monjalon.net, dev@dpdk.org References: <20221104111740.330-1-mb@smartsharesystems.com> <20221104120329.1219-1-mb@smartsharesystems.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20221104120329.1219-1-mb@smartsharesystems.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/4/22 15:03, Morten Brørup wrote: > Split stats from debug, to make mempool statistics available without the > performance cost of continuously validating the debug cookies in the > mempool elements. > > mempool_perf_autotest shows the following improvements in rate_persec. > > The cost of enabling mempool debug without this patch: > -28.1 % and -74.0 %, respectively without and with cache. > > The cost of enabling mempool stats (without debug) after this patch: > -5.8 % and -21.2 %, respectively without and with cache. > > v4: > * No changes. > v3: > * Update the Programmer's Guide. > * Update the description of the RTE_MEMPOOL_STAT_ADD macro. > v2: > * Fix checkpatch warning: > Use C style comments in rte_include.h, not C++ style. > * Do not rename the rte_mempool_debug_stats structure. > > Signed-off-by: Morten Brørup Good idea, many thanks for the patch. Reviewed-by: Andrew Rybchenko