From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18AE6C11F65 for ; Wed, 30 Jun 2021 15:58:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3C83611CA for ; Wed, 30 Jun 2021 15:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236137AbhF3QBR (ORCPT ); Wed, 30 Jun 2021 12:01:17 -0400 Received: from mga01.intel.com ([192.55.52.88]:4075 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235844AbhF3QAW (ORCPT ); Wed, 30 Jun 2021 12:00:22 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10031"; a="230015988" X-IronPort-AV: E=Sophos;i="5.83,312,1616482800"; d="scan'208";a="230015988" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2021 08:55:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,312,1616482800"; d="scan'208";a="559099792" Received: from nntpat99-84.inn.intel.com ([10.125.99.84]) by fmsmga001.fm.intel.com with ESMTP; 30 Jun 2021 08:55:52 -0700 From: Alexey Bayduraev To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , linux-kernel , Andi Kleen , Adrian Hunter , Alexander Antonov , Alexei Budankov , Riccardo Mancini Subject: [PATCH v8 15/22] perf session: Introduce reader objects in session object Date: Wed, 30 Jun 2021 18:54:54 +0300 Message-Id: X-Mailer: git-send-email 2.19.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allow to allocate multiple reader objects, so we could load multiple data files located in data directory at the same time. Design and implementation are based on the prototype [1], [2]. [1] git clone https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git -b perf/record_threads [2] https://lore.kernel.org/lkml/20180913125450.21342-1-jolsa@kernel.org/ Suggested-by: Jiri Olsa Acked-by: Namhyung Kim Signed-off-by: Alexey Bayduraev --- tools/perf/util/session.c | 33 +++++++++++++++++++++------------ tools/perf/util/session.h | 3 +++ 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index d9e0c54a74c1..d9abca5c3904 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -342,6 +342,10 @@ void perf_session__delete(struct perf_session *session) auxtrace_index__free(&session->auxtrace_index); perf_session__destroy_kernel_maps(session); perf_session__delete_threads(session); + if (session->readers) { + zfree(&session->readers); + session->nr_readers = 0; + } perf_session__release_decomp_events(session); perf_env__exit(&session->header.env); machines__exit(&session->machines); @@ -2299,14 +2303,7 @@ static s64 process_simple(struct perf_session *session, static int __perf_session__process_events(struct perf_session *session) { - struct reader rd = { - .fd = perf_data__fd(session->data), - .data_size = session->header.data_size, - .data_offset = session->header.data_offset, - .process = process_simple, - .path = session->data->file.path, - .in_place_update = session->data->in_place_update, - }; + struct reader *rd; struct ordered_events *oe = &session->ordered_events; struct perf_tool *tool = session->tool; struct ui_progress prog; @@ -2314,12 +2311,24 @@ static int __perf_session__process_events(struct perf_session *session) perf_tool__fill_defaults(tool); - if (rd.data_size == 0) - return -1; + rd = session->readers = zalloc(sizeof(struct reader)); + if (!rd) + return -ENOMEM; + + session->nr_readers = 1; + + *rd = (struct reader) { + .fd = perf_data__fd(session->data), + .data_size = session->header.data_size, + .data_offset = session->header.data_offset, + .process = process_simple, + .path = session->data->file.path, + .in_place_update = session->data->in_place_update, + }; - ui_progress__init_size(&prog, rd.data_size, "Processing events..."); + ui_progress__init_size(&prog, rd->data_size, "Processing events..."); - err = reader__process_events(&rd, session, &prog); + err = reader__process_events(rd, session, &prog); if (err) goto out_err; /* do the final flush for ordered samples */ diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h index 6895a22ab5b7..2815d00b5467 100644 --- a/tools/perf/util/session.h +++ b/tools/perf/util/session.h @@ -19,6 +19,7 @@ struct thread; struct auxtrace; struct itrace_synth_opts; +struct reader; struct perf_session { struct perf_header header; @@ -41,6 +42,8 @@ struct perf_session { struct zstd_data zstd_data; struct decomp *decomp; struct decomp *decomp_last; + struct reader *readers; + int nr_readers; }; struct decomp { -- 2.19.0