All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Chris Chiu <chiu@endlessm.com>, Daniel Drake <drake@endlessm.com>
Cc: Jian-Hong Pan <jian-hong@endlessm.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Jani Nikula <jani.nikula@intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Adrian Salido <salidoa@google.com>,
	Jason Gerecke <killertofu@gmail.com>,
	linux-input <linux-input@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD
Date: Mon, 14 May 2018 17:20:22 +0300	[thread overview]
Message-ID: <c1343704-6b1a-14b5-3942-a8a33f73feee@linux.intel.com> (raw)
In-Reply-To: <CAB4CAwd0tN7CaS7YZCo3TZH-DPxt0x6wxyO23v7aBW9MOCtHCw@mail.gmail.com>

On 05/10/2018 03:03 PM, Chris Chiu wrote:
> Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns
> , HCNT increase to 117, the SCL high duration is 576ns as follows
> https://pasteboard.co/HkwERvP.png
> 
> The original SCL high duration (HCNT = 105, 120MHz) is as follows
> https://pasteboard.co/HkwFxgY.png
> 
> So the HCNT does affect but per this HCNT/LCNT value, just not 400kHz
> as expected. Any suggestion?
> 
Thanks for measurements. I was sidetracked last week so I don't have yet 
explanation why signals run faster than expected :-(

Using 120 MHz SPT I2C clocks in commit b418bbff36dd ("mfd: intel-lpss: 
Add Intel Cannonlake PCI IDs") is clearly wrong but before going to 133 
MHz (which work for you but still runs too fast) I would like to find 
explanation why it appears to be much higher.

-- 
Jarkko

  reply	other threads:[~2018-05-14 14:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04  6:55 [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD Jian-Hong Pan
2018-05-07  8:07 ` Chris Chiu
2018-05-08 14:31   ` Jarkko Nikula
2018-05-08 15:47     ` Daniel Drake
2018-05-10 12:03       ` Chris Chiu
2018-05-14 14:20         ` Jarkko Nikula [this message]
2018-05-15  3:22           ` Chris Chiu
2018-05-15 10:20             ` Jarkko Nikula
2018-05-17  7:48               ` Jarkko Nikula
2018-05-17  9:05                 ` Chris Chiu
2018-05-18  7:48                 ` Hans de Goede
2018-05-18  8:37                   ` Andy Shevchenko
2018-05-18 10:20                     ` Andy Shevchenko
2018-05-18 10:58                       ` Jarkko Nikula
2018-05-18 13:09                         ` Hans de Goede
2018-05-18 13:15                   ` Jarkko Nikula
2018-05-18 13:26                     ` Hans de Goede
2018-05-19 11:58                     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1343704-6b1a-14b5-3942-a8a33f73feee@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=chiu@endlessm.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=drake@endlessm.com \
    --cc=hdegoede@redhat.com \
    --cc=jani.nikula@intel.com \
    --cc=jian-hong@endlessm.com \
    --cc=jikos@kernel.org \
    --cc=killertofu@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=salidoa@google.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.