From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Alistair Francis <alistair.francis@wdc.com>,
openembedded-core@lists.openembedded.org
Cc: alistair23@gmail.com
Subject: Re: [OE-core] [PATCH] u-boot: Add support for building for qemuriscv32
Date: Thu, 11 Mar 2021 23:04:30 +0000 [thread overview]
Message-ID: <c143615e770fa5b75147cb3dc82033b31ce9a034.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210311143714.3294960-1-alistair.francis@wdc.com>
On Thu, 2021-03-11 at 06:37 -0800, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> meta/conf/machine/qemuriscv32.conf | 7 ++--
> ...iscv32-Use-double-float-ABI-for-rv32.patch | 42 +++++++++++++++++++
> meta/recipes-bsp/u-boot/u-boot_2021.01.bb | 2 +
> 3 files changed, 47 insertions(+), 4 deletions(-)
> create mode 100644 meta/recipes-bsp/u-boot/files/0001-riscv32-Use-double-float-ABI-for-rv32.patch
>
> diff --git a/meta/conf/machine/qemuriscv32.conf b/meta/conf/machine/qemuriscv32.conf
> index 1413775ad6..d3858dc051 100644
> --- a/meta/conf/machine/qemuriscv32.conf
> +++ b/meta/conf/machine/qemuriscv32.conf
> @@ -11,7 +11,6 @@ PREFERRED_VERSION_openocd = "riscv"
>
>
>
>
> XVISOR_PLAT = "riscv/virt32"
>
>
>
>
> -# u-boot doesn't compile, error: "can't link hard-float modules with soft-float modules"
> -# EXTRA_IMAGEDEPENDS += "u-boot"
> -# UBOOT_MACHINE = "qemu-riscv32_smode_defconfig"
> -# UBOOT_ELF = "u-boot"
> +EXTRA_IMAGEDEPENDS += "u-boot"
> +UBOOT_MACHINE = "qemu-riscv32_smode_defconfig"
> +UBOOT_ELF = "u-boot"
> diff --git a/meta/recipes-bsp/u-boot/files/0001-riscv32-Use-double-float-ABI-for-rv32.patch b/meta/recipes-bsp/u-boot/files/0001-riscv32-Use-double-float-ABI-for-rv32.patch
> new file mode 100644
> index 0000000000..55b649db50
> --- /dev/null
> +++ b/meta/recipes-bsp/u-boot/files/0001-riscv32-Use-double-float-ABI-for-rv32.patch
> @@ -0,0 +1,42 @@
> +From 66dfe0fa886f6289add06d1af8642ce2b5302852 Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Tue, 9 Feb 2021 16:40:12 -0800
> +Subject: [PATCH] riscv32: Use double-float ABI for rv32
> +
> +So it can use libgcc built with OE toolchain
> +Fixes
> +error: "can't link hard-float modules with soft-float modules"
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +Upstream-Status: Inappropriate [configuration]
Is that status really correct? The patch doesn't look very configuration like to me...
Cheers,
Richard
next prev parent reply other threads:[~2021-03-11 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 14:37 [PATCH] u-boot: Add support for building for qemuriscv32 Alistair Francis
2021-03-11 23:04 ` Richard Purdie [this message]
2021-03-12 0:04 ` [OE-core] " Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c143615e770fa5b75147cb3dc82033b31ce9a034.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.