From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE99C10F11 for ; Wed, 24 Apr 2019 10:44:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4825420811 for ; Wed, 24 Apr 2019 10:44:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727872AbfDXKoc (ORCPT ); Wed, 24 Apr 2019 06:44:32 -0400 Received: from foss.arm.com ([217.140.101.70]:41370 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbfDXKob (ORCPT ); Wed, 24 Apr 2019 06:44:31 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 546D8A78; Wed, 24 Apr 2019 03:44:31 -0700 (PDT) Received: from [10.1.197.45] (e112298-lin.cambridge.arm.com [10.1.197.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB3E33F5AF; Wed, 24 Apr 2019 03:44:28 -0700 (PDT) Subject: Re: [RFC 4/6] arm64: assembler: Add macro to annotate asm function having non standard stack-frame. To: Raphael Gault , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: jpoimboe@redhat.com, peterz@infradead.org, catalin.marinas@arm.com, will.deacon@arm.com References: <20190409135243.12424-1-raphael.gault@arm.com> <20190409135243.12424-5-raphael.gault@arm.com> From: Julien Thierry Message-ID: Date: Wed, 24 Apr 2019 11:44:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190409135243.12424-5-raphael.gault@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Raphaël, On 09/04/2019 14:52, Raphael Gault wrote: > Signed-off-by: Raphael Gault Even there is not much to say, we include a commit message to explain what the patch does and/or why we want it. > --- > arch/arm64/include/asm/assembler.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h > index 4feb6119c3c9..636a07a7eb76 100644 > --- a/arch/arm64/include/asm/assembler.h > +++ b/arch/arm64/include/asm/assembler.h > @@ -748,4 +748,22 @@ USER(\label, ic ivau, \tmp2) // invalidate I line PoU > .Lyield_out_\@ : > .endm > > + > +#ifdef CONFIG_STACK_VALIDATION > + /* > + * This macro is the arm64 assembler equivalent of the > + * macro STACK_FRAME_NON_STANDARD define at > + * ~/include/linux/frame.h > + */ > + .macro asm_stack_frame_non_standard func > + .pushsection ".discard.func_stack_frame_non_standard" > + .8byte \func > + .popsection > + .endm > +#else > + .macro asm_stack_frame_non_standard func > + .endm > +#endif > + > + This can be simplified as: .macro asm_stack_frame_non_standard func #ifdef CONFIG_STACK_VALIDATION [...] #endif .endm > #endif /* __ASM_ASSEMBLER_H */ > Cheers, -- Julien Thierry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435D4C10F11 for ; Wed, 24 Apr 2019 10:44:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14CE920811 for ; Wed, 24 Apr 2019 10:44:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E47b81i2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14CE920811 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bNoqNTKkViUi6FwZ3PZCrYz+oXu+UtoLLB4NiHretN8=; b=E47b81i2zcvfaA D8Hoy9Uw5glaO8uyzBMvBlZhyGiLSFwGZaJt5/eUfLMjjk74fbIJlYJFjt/2XY8cnAGVi1H/zAlQy D2lgiCInM3UllMBmGTIItm8cZKOtQDCzxmvFeQEhzJp6bNDIQ/oZrA7TSRTscQmnolCsbLjvdVjWi Kz8nMT3C1lxyqvCBVB5QBOqGJdsS88tTcuIO/1uWAqPu1rJLTWUf4r2OXc4ekzEOclXd+SOAoNldw IXCrUyPsU+Ph3y7hwDv4Zag6962+0GBA71UyFFQQHhLdgMyfJSTtl7phfApC+htaE6rqMPvI3coAz SQJMCMbM0DhJbI3trUWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJFOF-0007RI-Rt; Wed, 24 Apr 2019 10:44:35 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJFOC-0007Qi-21 for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2019 10:44:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 546D8A78; Wed, 24 Apr 2019 03:44:31 -0700 (PDT) Received: from [10.1.197.45] (e112298-lin.cambridge.arm.com [10.1.197.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB3E33F5AF; Wed, 24 Apr 2019 03:44:28 -0700 (PDT) Subject: Re: [RFC 4/6] arm64: assembler: Add macro to annotate asm function having non standard stack-frame. To: Raphael Gault , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20190409135243.12424-1-raphael.gault@arm.com> <20190409135243.12424-5-raphael.gault@arm.com> From: Julien Thierry Message-ID: Date: Wed, 24 Apr 2019 11:44:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190409135243.12424-5-raphael.gault@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190424_034432_106458_5E11F259 X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peterz@infradead.org, catalin.marinas@arm.com, will.deacon@arm.com, jpoimboe@redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUmFwaGHDq2wsCgpPbiAwOS8wNC8yMDE5IDE0OjUyLCBSYXBoYWVsIEdhdWx0IHdyb3RlOgo+ IFNpZ25lZC1vZmYtYnk6IFJhcGhhZWwgR2F1bHQgPHJhcGhhZWwuZ2F1bHRAYXJtLmNvbT4KCkV2 ZW4gdGhlcmUgaXMgbm90IG11Y2ggdG8gc2F5LCB3ZSBpbmNsdWRlIGEgY29tbWl0IG1lc3NhZ2Ug dG8gZXhwbGFpbgp3aGF0IHRoZSBwYXRjaCBkb2VzIGFuZC9vciB3aHkgd2Ugd2FudCBpdC4KCj4g LS0tCj4gIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20vYXNzZW1ibGVyLmggfCAxOCArKysrKysrKysr KysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0t Z2l0IGEvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9hc3NlbWJsZXIuaCBiL2FyY2gvYXJtNjQvaW5j bHVkZS9hc20vYXNzZW1ibGVyLmgKPiBpbmRleCA0ZmViNjExOWMzYzkuLjYzNmEwN2E3ZWI3NiAx MDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2Fzc2VtYmxlci5oCj4gKysrIGIv YXJjaC9hcm02NC9pbmNsdWRlL2FzbS9hc3NlbWJsZXIuaAo+IEBAIC03NDgsNCArNzQ4LDIyIEBA IFVTRVIoXGxhYmVsLCBpYwlpdmF1LCBcdG1wMikJCQkvLyBpbnZhbGlkYXRlIEkgbGluZSBQb1UK PiAgLkx5aWVsZF9vdXRfXEAgOgo+ICAJLmVuZG0KPiAgCj4gKwo+ICsjaWZkZWYJQ09ORklHX1NU QUNLX1ZBTElEQVRJT04KPiArCS8qCj4gKwkgKiBUaGlzIG1hY3JvIGlzIHRoZSBhcm02NCBhc3Nl bWJsZXIgZXF1aXZhbGVudCBvZiB0aGUKPiArCSAqIG1hY3JvIFNUQUNLX0ZSQU1FX05PTl9TVEFO REFSRCBkZWZpbmUgYXQKPiArCSAqIH4vaW5jbHVkZS9saW51eC9mcmFtZS5oCj4gKwkgKi8KPiAr CS5tYWNybwlhc21fc3RhY2tfZnJhbWVfbm9uX3N0YW5kYXJkCWZ1bmMKPiArCS5wdXNoc2VjdGlv biAiLmRpc2NhcmQuZnVuY19zdGFja19mcmFtZV9ub25fc3RhbmRhcmQiCj4gKwkuOGJ5dGUJXGZ1 bmMKPiArCS5wb3BzZWN0aW9uCj4gKwkuZW5kbQo+ICsjZWxzZQo+ICsJLm1hY3JvCWFzbV9zdGFj a19mcmFtZV9ub25fc3RhbmRhcmQJZnVuYwo+ICsJLmVuZG0KPiArI2VuZGlmCj4gKwo+ICsKClRo aXMgY2FuIGJlIHNpbXBsaWZpZWQgYXM6CgoJLm1hY3JvIGFzbV9zdGFja19mcmFtZV9ub25fc3Rh bmRhcmQgZnVuYwojaWZkZWYgQ09ORklHX1NUQUNLX1ZBTElEQVRJT04KCVsuLi5dCiNlbmRpZgoJ LmVuZG0KCj4gICNlbmRpZgkvKiBfX0FTTV9BU1NFTUJMRVJfSCAqLwo+IAoKQ2hlZXJzLAoKLS0g Ckp1bGllbiBUaGllcnJ5CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==