From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52B6C433B4 for ; Tue, 20 Apr 2021 18:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA5C9613D0 for ; Tue, 20 Apr 2021 18:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233305AbhDTSQt (ORCPT ); Tue, 20 Apr 2021 14:16:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232648AbhDTSQr (ORCPT ); Tue, 20 Apr 2021 14:16:47 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29E00C06174A; Tue, 20 Apr 2021 11:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=B8wdXqMqUBLzsCivp+edaOcFTlLJLF22BvmBImW3Cds=; b=idQGC38rPRBjbmYwZbtyZOm3jE 6dHdTfCI3TU2tQDB+jpBCRy7jAANYERDUPDCn1zPAvNNhKLwmJgHQdkPnuCGUgXe4OLSvdasZwwEV vGnhMchBXwHkGiegv9uTQMK4CE6ct+pa6L17ZpY33ur9mazKAqLDjhLEj3v7lmkbjJcCpF7ZCNR2Q 8oXOj+in3tu1t5ajV4nsp8QhCc8HzzGkgzfruWz/wYkoPdgpPr1Ogq1T/4Xd2446qkLVW1yn/qHxX Y/m9ahMvYiCdElUwTNd/ravPIY24mm8yU8lIFGAucoiyjLTNoIuDbjsvxaxMKqHP/wTyCNh0agJbi GDEmOr/A==; Received: from [2601:1c0:6280:3f0::df68] by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lYuu5-00FUHM-Cw; Tue, 20 Apr 2021 18:15:24 +0000 Subject: Re: [PATCH 5/5] misc: zynqmp: Add afi config driver To: Nava kishore Manne , robh+dt@kernel.org, michal.simek@xilinx.com, derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, arnd@arndb.de, gregkh@linuxfoundation.org, rajan.vaja@xilinx.com, jolly.shah@xilinx.com, tejas.patel@xilinx.com, amit.sunil.dhamne@xilinx.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chinnikishore369@gmail.com, git@xilinx.com References: <20210420081153.17020-1-nava.manne@xilinx.com> <20210420081153.17020-6-nava.manne@xilinx.com> From: Randy Dunlap Message-ID: Date: Tue, 20 Apr 2021 11:15:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210420081153.17020-6-nava.manne@xilinx.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/20/21 1:11 AM, Nava kishore Manne wrote: > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 877b43b3377d..d1ea1eeb3ac1 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -456,6 +456,17 @@ config ZYNQ_AFI > between PS and PL, the AXI port data path should be configured > with the proper Bus-width values > > +config ZYNQMP_AFI > + tristate "Xilinx ZYNQMP AFI support" > + help > + ZynqMP AFI driver support for writing to the AFI registers for > + configuring PS_PL Bus-width. Xilinx Zynq US+ MPSoC connect the > + PS to the programmable logic (PL) through the AXI port. This AXI > + port helps to establish the data path between the PS and PL. > + In-order to establish the proper communication path between > + PS and PL, the AXI port data path should be configured with > + the proper Bus-width values > + > source "drivers/misc/c2port/Kconfig" > source "drivers/misc/eeprom/Kconfig" > source "drivers/misc/cb710/Kconfig" Hi, from my notabot: Please follow coding-style for Kconfig files: from Documentation/process/coding-style.rst, section 10): For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. thanks. -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B17C433B4 for ; Tue, 20 Apr 2021 18:17:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48511613CD for ; Tue, 20 Apr 2021 18:17:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48511613CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N1GJi0ci/VwTWOxJ5RHV44dMiHEkIL3uvmFRX9jEaoA=; b=CqIYsgr5IR/SEWvSx9LQwip/i YhgAarDEjicJJckECFc1kkA1n8gc60sg3RZbIebUroWV+7FQmJwWiTlOeDh4msoZ3twACkdLsonHa XG5prY5TQxD9XM6I4W6DDqjZ3kV5HOGMTwkdhyP8703nhXCyJGDE/MMvvQ5TZHVsxAWYz0FZZYMuz 2p6RU0BEPVHWNndn1vrc1oaLPwvnBiq3kbgtsDHM2f7bUptZfFv+3D99bHX0rpkt8O/kdGHFE7CM0 bygBZ2cjx9skRunVE9O5CRdwocsUV0w6j8hOgaO/i8SZC2zsPSAnZUSY19KxpOWi5kCqcrX7OILNf EedJ8mygQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYuuZ-00CoPr-Ty; Tue, 20 Apr 2021 18:15:48 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYuuX-00CoPm-S9 for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 18:15:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=B8wdXqMqUBLzsCivp+edaOcFTlLJLF22BvmBImW3Cds=; b=idQGC38rPRBjbmYwZbtyZOm3jE 6dHdTfCI3TU2tQDB+jpBCRy7jAANYERDUPDCn1zPAvNNhKLwmJgHQdkPnuCGUgXe4OLSvdasZwwEV vGnhMchBXwHkGiegv9uTQMK4CE6ct+pa6L17ZpY33ur9mazKAqLDjhLEj3v7lmkbjJcCpF7ZCNR2Q 8oXOj+in3tu1t5ajV4nsp8QhCc8HzzGkgzfruWz/wYkoPdgpPr1Ogq1T/4Xd2446qkLVW1yn/qHxX Y/m9ahMvYiCdElUwTNd/ravPIY24mm8yU8lIFGAucoiyjLTNoIuDbjsvxaxMKqHP/wTyCNh0agJbi GDEmOr/A==; Received: from [2601:1c0:6280:3f0::df68] by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lYuu5-00FUHM-Cw; Tue, 20 Apr 2021 18:15:24 +0000 Subject: Re: [PATCH 5/5] misc: zynqmp: Add afi config driver To: Nava kishore Manne , robh+dt@kernel.org, michal.simek@xilinx.com, derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, arnd@arndb.de, gregkh@linuxfoundation.org, rajan.vaja@xilinx.com, jolly.shah@xilinx.com, tejas.patel@xilinx.com, amit.sunil.dhamne@xilinx.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chinnikishore369@gmail.com, git@xilinx.com References: <20210420081153.17020-1-nava.manne@xilinx.com> <20210420081153.17020-6-nava.manne@xilinx.com> From: Randy Dunlap Message-ID: Date: Tue, 20 Apr 2021 11:15:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210420081153.17020-6-nava.manne@xilinx.com> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/20/21 1:11 AM, Nava kishore Manne wrote: > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 877b43b3377d..d1ea1eeb3ac1 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -456,6 +456,17 @@ config ZYNQ_AFI > between PS and PL, the AXI port data path should be configured > with the proper Bus-width values > > +config ZYNQMP_AFI > + tristate "Xilinx ZYNQMP AFI support" > + help > + ZynqMP AFI driver support for writing to the AFI registers for > + configuring PS_PL Bus-width. Xilinx Zynq US+ MPSoC connect the > + PS to the programmable logic (PL) through the AXI port. This AXI > + port helps to establish the data path between the PS and PL. > + In-order to establish the proper communication path between > + PS and PL, the AXI port data path should be configured with > + the proper Bus-width values > + > source "drivers/misc/c2port/Kconfig" > source "drivers/misc/eeprom/Kconfig" > source "drivers/misc/cb710/Kconfig" Hi, from my notabot: Please follow coding-style for Kconfig files: from Documentation/process/coding-style.rst, section 10): For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. thanks. -- ~Randy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel