All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Chuang <yhchuang@realtek.com>
To: "Mancini, Jason" <Jason.Mancini@amd.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: v5.5-rc1 and beyond insta-kills some Comcast wifi routers
Date: Wed, 4 Mar 2020 10:41:42 +0000	[thread overview]
Message-ID: <c185b1f27e4a4b66941b50697dba006c@realtek.com> (raw)
In-Reply-To: <DM6PR12MB433132A38F2AA6A5946B75CBE5E50@DM6PR12MB4331.namprd12.prod.outlook.com>

> [AMD Official Use Only - Internal Distribution Only]
> 
> I tested Kalle's patch.  Laptop connects via 5GHz band by default.  Comcast
> router still
> crashed in a hurry.  I blocked (via NM.conf) the 5GHz mac of the router, and
> rebooted
> the laptop. Checked that the router was using 2.4 for the laptop.  Still hung
> the router!
> 
> What I've done temporarily is change the unlimited return value from 0 to
> 4000.
> Somewhere around 5325 the Comcast router gets cranky/weird, and at 5350
> it is
> resetting the wifi stack (without resetting the entire router).
> 
> So there's no boot time flag to turn the feature off currently?
> 

Unfortunately, no, there's no flag to turn off this.

But, from your experiments, if you applied that patch,
("rtw88: disable TX-AMSDU on 2.4G band") connect to AP on 2.4G, and still crash
the Comcast AP, then it looks like it's not TX-AMSDU to be blamed.

Assume the return value you mentioned is max_rc_amsdu_len, if you always
return 1, it will just disable all of the AMSDU process.
You can try it, and to see if sending AMSDU will crash the router or not.

Yen-Hsuan

  reply	other threads:[~2020-03-04 10:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  3:34 v5.5-rc1 and beyond insta-kills some Comcast wifi routers Mancini, Jason
2020-03-04  4:05 ` Randy Dunlap
2020-03-04  5:05   ` Kalle Valo
2020-03-04  5:16     ` Tony Chuang
2020-03-04  9:03       ` Mancini, Jason
2020-03-04 10:41         ` Tony Chuang [this message]
2020-03-05  7:06           ` Jason Mancini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c185b1f27e4a4b66941b50697dba006c@realtek.com \
    --to=yhchuang@realtek.com \
    --cc=Jason.Mancini@amd.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.