* [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-17 20:44 ` Sergio Paracuellos
0 siblings, 0 replies; 14+ messages in thread
From: Sergio Paracuellos @ 2018-12-17 20:44 UTC (permalink / raw)
To: Woojung.Huh
Cc: UNGLinuxDriver, andrew, vivien.didelot, f.fainelli,
driverdev-devel, davem, netdev, devicetree
Add device-tree binding example of the ksz9477 switch managed in i2c mode.
Cc: devicetree@vger.kernel.org
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
Changes v3:
- No changes. Just resent patches together.
Changes v2:
- Use generic name for label of the switch and make sure reg and @X
have the same value.
.../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
index 0f407fb371ce..d3c4b9d4f416 100644
--- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
+++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
@@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
};
};
};
+
+Ethernet switch connected via I2C to the host, CPU port wired to eth0:
+
+ eth0: ethernet@10001000 {
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+
+ i2c0: i2c@f8008000 {
+ switch: ksz9897@5f {
+ compatible = "microchip,ksz9897";
+ reg = <5f>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ label = "lan1";
+ };
+ port@1 {
+ reg = <1>;
+ label = "lan2";
+ };
+ port@2 {
+ reg = <2>;
+ label = "lan3";
+ };
+ port@3 {
+ reg = <3>;
+ label = "lan4";
+ };
+ port@4 {
+ reg = <4>;
+ label = "lan5";
+ };
+ port@6 {
+ reg = <6>;
+ label = "cpu";
+ ethernet = <ð0>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
+ };
--
2.19.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-17 20:44 ` Sergio Paracuellos
0 siblings, 0 replies; 14+ messages in thread
From: Sergio Paracuellos @ 2018-12-17 20:44 UTC (permalink / raw)
To: Woojung.Huh
Cc: andrew, f.fainelli, vivien.didelot, netdev, driverdev-devel,
UNGLinuxDriver, devicetree, davem
Add device-tree binding example of the ksz9477 switch managed in i2c mode.
Cc: devicetree@vger.kernel.org
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
Changes v3:
- No changes. Just resent patches together.
Changes v2:
- Use generic name for label of the switch and make sure reg and @X
have the same value.
.../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
index 0f407fb371ce..d3c4b9d4f416 100644
--- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
+++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
@@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
};
};
};
+
+Ethernet switch connected via I2C to the host, CPU port wired to eth0:
+
+ eth0: ethernet@10001000 {
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+
+ i2c0: i2c@f8008000 {
+ switch: ksz9897@5f {
+ compatible = "microchip,ksz9897";
+ reg = <5f>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ label = "lan1";
+ };
+ port@1 {
+ reg = <1>;
+ label = "lan2";
+ };
+ port@2 {
+ reg = <2>;
+ label = "lan3";
+ };
+ port@3 {
+ reg = <3>;
+ label = "lan4";
+ };
+ port@4 {
+ reg = <4>;
+ label = "lan5";
+ };
+ port@6 {
+ reg = <6>;
+ label = "cpu";
+ ethernet = <ð0>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
+ };
--
2.19.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
2018-12-17 20:44 ` Sergio Paracuellos
@ 2018-12-17 22:22 ` Florian Fainelli
-1 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2018-12-17 22:22 UTC (permalink / raw)
To: Sergio Paracuellos, Woojung.Huh
Cc: UNGLinuxDriver, andrew, vivien.didelot, driverdev-devel, davem,
netdev, devicetree
On 12/17/18 12:44 PM, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
This looks good, although it looks like you have 2x the amount of tabs
necessary.
--
Florian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-17 22:22 ` Florian Fainelli
0 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2018-12-17 22:22 UTC (permalink / raw)
To: Sergio Paracuellos, Woojung.Huh
Cc: andrew, vivien.didelot, netdev, driverdev-devel, UNGLinuxDriver,
devicetree, davem
On 12/17/18 12:44 PM, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
This looks good, although it looks like you have 2x the amount of tabs
necessary.
--
Florian
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
2018-12-17 22:22 ` Florian Fainelli
@ 2018-12-18 6:32 ` Sergio Paracuellos
-1 siblings, 0 replies; 14+ messages in thread
From: Sergio Paracuellos @ 2018-12-18 6:32 UTC (permalink / raw)
To: Florian Fainelli
Cc: Woojung.Huh, UNGLinuxDriver, Andrew Lunn, vivien.didelot,
driverdev-devel, davem, netdev,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Florian,
On Mon, Dec 17, 2018 at 11:22 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> On 12/17/18 12:44 PM, Sergio Paracuellos wrote:
> > Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>
> This looks good, although it looks like you have 2x the amount of tabs
> necessary.
Yes, I know but the original spi sample included in the same file was
created with that indentation, so I only followed the same file style.
> --
> Florian
Best regards,
Sergio Paracuellos
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-18 6:32 ` Sergio Paracuellos
0 siblings, 0 replies; 14+ messages in thread
From: Sergio Paracuellos @ 2018-12-18 6:32 UTC (permalink / raw)
To: Florian Fainelli
Cc: Woojung.Huh, Andrew Lunn, vivien.didelot, netdev,
driverdev-devel, UNGLinuxDriver,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
davem
Hi Florian,
On Mon, Dec 17, 2018 at 11:22 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> On 12/17/18 12:44 PM, Sergio Paracuellos wrote:
> > Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>
> This looks good, although it looks like you have 2x the amount of tabs
> necessary.
Yes, I know but the original spi sample included in the same file was
created with that indentation, so I only followed the same file style.
> --
> Florian
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
2018-12-17 20:44 ` Sergio Paracuellos
@ 2018-12-18 15:10 ` Rob Herring
-1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2018-12-18 15:10 UTC (permalink / raw)
To: Sergio Paracuellos
Cc: Woojung.Huh, UNGLinuxDriver, andrew, vivien.didelot, f.fainelli,
driverdev-devel, davem, netdev, devicetree
On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> Changes v3:
> - No changes. Just resent patches together.
>
> Changes v2:
> - Use generic name for label of the switch and make sure reg and @X
> have the same value.
>
> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> index 0f407fb371ce..d3c4b9d4f416 100644
> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> };
> };
> };
> +
> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> +
> + eth0: ethernet@10001000 {
Why do we have all this indentation? Please remove. And use tab chars,
not spaces.
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> +
> + i2c0: i2c@f8008000 {
> + switch: ksz9897@5f {
> + compatible = "microchip,ksz9897";
> + reg = <5f>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + label = "lan1";
> + };
> + port@1 {
> + reg = <1>;
> + label = "lan2";
> + };
> + port@2 {
> + reg = <2>;
> + label = "lan3";
> + };
> + port@3 {
> + reg = <3>;
> + label = "lan4";
> + };
> + port@4 {
> + reg = <4>;
> + label = "lan5";
> + };
> + port@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <ð0>;
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> + };
> + };
> + };
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-18 15:10 ` Rob Herring
0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2018-12-18 15:10 UTC (permalink / raw)
To: Sergio Paracuellos
Cc: Woojung.Huh, andrew, f.fainelli, vivien.didelot, netdev,
driverdev-devel, UNGLinuxDriver, devicetree, davem
On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> Changes v3:
> - No changes. Just resent patches together.
>
> Changes v2:
> - Use generic name for label of the switch and make sure reg and @X
> have the same value.
>
> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> index 0f407fb371ce..d3c4b9d4f416 100644
> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> };
> };
> };
> +
> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> +
> + eth0: ethernet@10001000 {
Why do we have all this indentation? Please remove. And use tab chars,
not spaces.
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> +
> + i2c0: i2c@f8008000 {
> + switch: ksz9897@5f {
> + compatible = "microchip,ksz9897";
> + reg = <5f>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + label = "lan1";
> + };
> + port@1 {
> + reg = <1>;
> + label = "lan2";
> + };
> + port@2 {
> + reg = <2>;
> + label = "lan3";
> + };
> + port@3 {
> + reg = <3>;
> + label = "lan4";
> + };
> + port@4 {
> + reg = <4>;
> + label = "lan5";
> + };
> + port@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <ð0>;
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> + };
> + };
> + };
> --
> 2.19.1
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
2018-12-18 15:10 ` Rob Herring
@ 2018-12-19 6:23 ` Sergio Paracuellos
-1 siblings, 0 replies; 14+ messages in thread
From: Sergio Paracuellos @ 2018-12-19 6:23 UTC (permalink / raw)
To: Rob Herring
Cc: Woojung.Huh, UNGLinuxDriver, Andrew Lunn, vivien.didelot,
Florian Fainelli, driverdev-devel, davem, netdev,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Rob,
On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
> > Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> > Changes v3:
> > - No changes. Just resent patches together.
> >
> > Changes v2:
> > - Use generic name for label of the switch and make sure reg and @X
> > have the same value.
> >
> > .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > index 0f407fb371ce..d3c4b9d4f416 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> > };
> > };
> > };
> > +
> > +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> > +
> > + eth0: ethernet@10001000 {
>
> Why do we have all this indentation? Please remove. And use tab chars,
> not spaces.
The original file format is using all of this indentation. So I think
we would need a patch to change de format of the original file and
another with this new changes properly formatted.
>
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
> > +
> > + i2c0: i2c@f8008000 {
> > + switch: ksz9897@5f {
> > + compatible = "microchip,ksz9897";
> > + reg = <5f>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@0 {
> > + reg = <0>;
> > + label = "lan1";
> > + };
> > + port@1 {
> > + reg = <1>;
> > + label = "lan2";
> > + };
> > + port@2 {
> > + reg = <2>;
> > + label = "lan3";
> > + };
> > + port@3 {
> > + reg = <3>;
> > + label = "lan4";
> > + };
> > + port@4 {
> > + reg = <4>;
> > + label = "lan5";
> > + };
> > + port@6 {
> > + reg = <6>;
> > + label = "cpu";
> > + ethernet = <ð0>;
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
> > + };
> > + };
> > + };
> > --
> > 2.19.1
> >
Best regards,
Sergio Paracuellos
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-19 6:23 ` Sergio Paracuellos
0 siblings, 0 replies; 14+ messages in thread
From: Sergio Paracuellos @ 2018-12-19 6:23 UTC (permalink / raw)
To: Rob Herring
Cc: Woojung.Huh, Andrew Lunn, Florian Fainelli, vivien.didelot,
netdev, driverdev-devel, UNGLinuxDriver,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
davem
Hi Rob,
On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
> > Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> > Changes v3:
> > - No changes. Just resent patches together.
> >
> > Changes v2:
> > - Use generic name for label of the switch and make sure reg and @X
> > have the same value.
> >
> > .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > index 0f407fb371ce..d3c4b9d4f416 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> > };
> > };
> > };
> > +
> > +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> > +
> > + eth0: ethernet@10001000 {
>
> Why do we have all this indentation? Please remove. And use tab chars,
> not spaces.
The original file format is using all of this indentation. So I think
we would need a patch to change de format of the original file and
another with this new changes properly formatted.
>
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
> > +
> > + i2c0: i2c@f8008000 {
> > + switch: ksz9897@5f {
> > + compatible = "microchip,ksz9897";
> > + reg = <5f>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@0 {
> > + reg = <0>;
> > + label = "lan1";
> > + };
> > + port@1 {
> > + reg = <1>;
> > + label = "lan2";
> > + };
> > + port@2 {
> > + reg = <2>;
> > + label = "lan3";
> > + };
> > + port@3 {
> > + reg = <3>;
> > + label = "lan4";
> > + };
> > + port@4 {
> > + reg = <4>;
> > + label = "lan5";
> > + };
> > + port@6 {
> > + reg = <6>;
> > + label = "cpu";
> > + ethernet = <ð0>;
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
> > + };
> > + };
> > + };
> > --
> > 2.19.1
> >
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
2018-12-19 6:23 ` Sergio Paracuellos
@ 2018-12-19 18:26 ` Florian Fainelli
-1 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2018-12-19 18:26 UTC (permalink / raw)
To: Sergio Paracuellos, Rob Herring
Cc: Woojung.Huh, UNGLinuxDriver, Andrew Lunn, vivien.didelot,
driverdev-devel, davem, netdev,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On 12/18/18 10:23 PM, Sergio Paracuellos wrote:
> Hi Rob,
>
> On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@kernel.org> wrote:
>>
>> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
>>> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>>>
>>> Cc: devicetree@vger.kernel.org
>>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>>> ---
>>> Changes v3:
>>> - No changes. Just resent patches together.
>>>
>>> Changes v2:
>>> - Use generic name for label of the switch and make sure reg and @X
>>> have the same value.
>>>
>>> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
>>> 1 file changed, 50 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
>>> index 0f407fb371ce..d3c4b9d4f416 100644
>>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
>>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
>>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
>>> };
>>> };
>>> };
>>> +
>>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
>>> +
>>> + eth0: ethernet@10001000 {
>>
>> Why do we have all this indentation? Please remove. And use tab chars,
>> not spaces.
>
> The original file format is using all of this indentation. So I think
> we would need a patch to change de format of the original file and
> another with this new changes properly formatted.
The original formatting should be fixed, but your changes should adopt
the correct style from the first time they are submitted. Do you mind
resubmitting with only one tab? We can fix the original examples as a
follow-up patch.
Thanks!
--
Florian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-19 18:26 ` Florian Fainelli
0 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2018-12-19 18:26 UTC (permalink / raw)
To: Sergio Paracuellos, Rob Herring
Cc: Woojung.Huh, Andrew Lunn, vivien.didelot, netdev,
driverdev-devel, UNGLinuxDriver,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
davem
On 12/18/18 10:23 PM, Sergio Paracuellos wrote:
> Hi Rob,
>
> On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@kernel.org> wrote:
>>
>> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
>>> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>>>
>>> Cc: devicetree@vger.kernel.org
>>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>>> ---
>>> Changes v3:
>>> - No changes. Just resent patches together.
>>>
>>> Changes v2:
>>> - Use generic name for label of the switch and make sure reg and @X
>>> have the same value.
>>>
>>> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
>>> 1 file changed, 50 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
>>> index 0f407fb371ce..d3c4b9d4f416 100644
>>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
>>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
>>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
>>> };
>>> };
>>> };
>>> +
>>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
>>> +
>>> + eth0: ethernet@10001000 {
>>
>> Why do we have all this indentation? Please remove. And use tab chars,
>> not spaces.
>
> The original file format is using all of this indentation. So I think
> we would need a patch to change de format of the original file and
> another with this new changes properly formatted.
The original formatting should be fixed, but your changes should adopt
the correct style from the first time they are submitted. Do you mind
resubmitting with only one tab? We can fix the original examples as a
follow-up patch.
Thanks!
--
Florian
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
2018-12-19 18:26 ` Florian Fainelli
@ 2018-12-19 19:49 ` Sergio Paracuellos
-1 siblings, 0 replies; 14+ messages in thread
From: Sergio Paracuellos @ 2018-12-19 19:49 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Woojung.Huh, UNGLinuxDriver, Andrew Lunn,
vivien.didelot, driverdev-devel, davem, netdev,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Wed, Dec 19, 2018 at 7:26 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> On 12/18/18 10:23 PM, Sergio Paracuellos wrote:
> > Hi Rob,
> >
> > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@kernel.org> wrote:
> >>
> >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
> >>> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >>>
> >>> Cc: devicetree@vger.kernel.org
> >>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> >>> ---
> >>> Changes v3:
> >>> - No changes. Just resent patches together.
> >>>
> >>> Changes v2:
> >>> - Use generic name for label of the switch and make sure reg and @X
> >>> have the same value.
> >>>
> >>> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
> >>> 1 file changed, 50 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> >>> index 0f407fb371ce..d3c4b9d4f416 100644
> >>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> >>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> >>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> >>> };
> >>> };
> >>> };
> >>> +
> >>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> >>> +
> >>> + eth0: ethernet@10001000 {
> >>
> >> Why do we have all this indentation? Please remove. And use tab chars,
> >> not spaces.
> >
> > The original file format is using all of this indentation. So I think
> > we would need a patch to change de format of the original file and
> > another with this new changes properly formatted.
>
> The original formatting should be fixed, but your changes should adopt
> the correct style from the first time they are submitted. Do you mind
> resubmitting with only one tab? We can fix the original examples as a
> follow-up patch.
I see. Thanks for let me know. I'll be more careful from now.
v4 actually sent with changes proposed here.
>
> Thanks!
> --
> Florian
Best regards,
Sergio Paracuellos
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-19 19:49 ` Sergio Paracuellos
0 siblings, 0 replies; 14+ messages in thread
From: Sergio Paracuellos @ 2018-12-19 19:49 UTC (permalink / raw)
To: Florian Fainelli
Cc: Woojung.Huh, Rob Herring, vivien.didelot, netdev,
driverdev-devel, UNGLinuxDriver,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Andrew Lunn, davem
On Wed, Dec 19, 2018 at 7:26 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> On 12/18/18 10:23 PM, Sergio Paracuellos wrote:
> > Hi Rob,
> >
> > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@kernel.org> wrote:
> >>
> >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
> >>> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >>>
> >>> Cc: devicetree@vger.kernel.org
> >>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> >>> ---
> >>> Changes v3:
> >>> - No changes. Just resent patches together.
> >>>
> >>> Changes v2:
> >>> - Use generic name for label of the switch and make sure reg and @X
> >>> have the same value.
> >>>
> >>> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
> >>> 1 file changed, 50 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> >>> index 0f407fb371ce..d3c4b9d4f416 100644
> >>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> >>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> >>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> >>> };
> >>> };
> >>> };
> >>> +
> >>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> >>> +
> >>> + eth0: ethernet@10001000 {
> >>
> >> Why do we have all this indentation? Please remove. And use tab chars,
> >> not spaces.
> >
> > The original file format is using all of this indentation. So I think
> > we would need a patch to change de format of the original file and
> > another with this new changes properly formatted.
>
> The original formatting should be fixed, but your changes should adopt
> the correct style from the first time they are submitted. Do you mind
> resubmitting with only one tab? We can fix the original examples as a
> follow-up patch.
I see. Thanks for let me know. I'll be more careful from now.
v4 actually sent with changes proposed here.
>
> Thanks!
> --
> Florian
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-12-19 19:49 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-17 20:44 [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode Sergio Paracuellos
2018-12-17 20:44 ` Sergio Paracuellos
2018-12-17 22:22 ` Florian Fainelli
2018-12-17 22:22 ` Florian Fainelli
2018-12-18 6:32 ` Sergio Paracuellos
2018-12-18 6:32 ` Sergio Paracuellos
2018-12-18 15:10 ` Rob Herring
2018-12-18 15:10 ` Rob Herring
2018-12-19 6:23 ` Sergio Paracuellos
2018-12-19 6:23 ` Sergio Paracuellos
2018-12-19 18:26 ` Florian Fainelli
2018-12-19 18:26 ` Florian Fainelli
2018-12-19 19:49 ` Sergio Paracuellos
2018-12-19 19:49 ` Sergio Paracuellos
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.