From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96BDC433E7 for ; Wed, 2 Sep 2020 19:48:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85AEA20758 for ; Wed, 2 Sep 2020 19:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726913AbgIBTs0 (ORCPT ); Wed, 2 Sep 2020 15:48:26 -0400 Received: from mga04.intel.com ([192.55.52.120]:35112 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgIBTsX (ORCPT ); Wed, 2 Sep 2020 15:48:23 -0400 IronPort-SDR: 6lG2wBFsSbBz5Afwdm72SDj8NoLjougRo+WktULhobQHfF5coLcOgsPep12g055gz5vqlJyelz 9LLdDuTdEqvg== X-IronPort-AV: E=McAfee;i="6000,8403,9732"; a="154871634" X-IronPort-AV: E=Sophos;i="5.76,384,1592895600"; d="scan'208";a="154871634" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 12:48:21 -0700 IronPort-SDR: tVkddLVBeA3qWBhyGUc42GmgoU+ag6G++7iuZV21E5H52fVVDP3Vtow3ADwut0XYyTuy6DSASJ 64O/boPgzHAA== X-IronPort-AV: E=Sophos;i="5.76,384,1592895600"; d="scan'208";a="477769014" Received: from unknown (HELO dwf-u18040) ([10.232.115.11]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 12:48:20 -0700 Message-ID: Subject: Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain From: David Fugate Reply-To: david.fugate@linux.intel.com To: Christoph Hellwig , Kai Heng Feng Cc: Bjorn Helgaas , jonathan.derrick@intel.com, Mario.Limonciello@dell.com, Heiner Kallweit , Mika Westerberg , "Rafael J. Wysocki" , Xiongfeng Wang , Krzysztof Wilczynski , "open list:PCI SUBSYSTEM" , open list , Dan Williams , "Huffman, Amber" , david.fugate@intel.com Date: Wed, 02 Sep 2020 13:48:19 -0600 In-Reply-To: <20200825065634.GA2691@infradead.org> References: <20200821123222.32093-1-kai.heng.feng@canonical.com> <20200825062320.GA27116@infradead.org> <08080FC7-861B-472A-BD7D-02D33926677F@canonical.com> <20200825065634.GA2691@infradead.org> Organization: Intel Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-08-25 at 07:56 +0100, Christoph Hellwig wrote: > while adding absolutely no value. Basically we have to add a large > chunk of kernel code just to undo silicone/firmware Intel added to > their > platform to make things complicated. I mean it is their platform and > if > they want a "make things complicated" option that is fine, but it > should > not be on by default. Thanks for your feedback. Over the years, I've been forwarded numerous emails from VMD customers praising it's ability to prevent Linux kernel panics upon hot-removals and inserts of U.2 NVMe drives. Many were migrating from SATA drives, which didn't have this issue, and considered it a showstopper to NVMe adoption. I hope we can all agree reliable and robust hot-plug support adds value.