Re: [kernelci-members] Working with the KernelCI project

From: "Nikolai Kondrashov" <Nikolai.Kondrashov@redhat.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: kernelci@groups.io,
	"Guillaume Tucker" <guillaume.tucker@collabora.com>,
	"Philip Li" <philip.li@intel.com>,
	kernelci-members@groups.io, nkondras@redhat.com,
	"Don Zickus" <dzickus@redhat.com>,
	syzkaller <syzkaller@googlegroups.com>,
	"Iñaki Malerba" <imalerba@redhat.com>
Subject: Re: [kernelci-members] Working with the KernelCI project
Date: Thu, 1 Oct 2020 18:58:33 +0300	[thread overview]
Message-ID: <c19a0453-3e57-9357-1207-181fc427fae6@redhat.com> (raw)
In-Reply-To: <CACT4Y+Zxnxku6CBYdtFQuqzB28=HjaCOV0A6KPzHFVb7gU0yXg@mail.gmail.com>

On 10/1/20 6:40 PM, Dmitry Vyukov wrote:
 > On Thu, Oct 1, 2020 at 5:36 PM Dmitry Vyukov <dvyukov@google.com> wrote:
 >>
 >> On Thu, Oct 1, 2020 at 5:12 PM Nikolai Kondrashov
 >> <Nikolai.Kondrashov@redhat.com> wrote:
 >>>
 >>> On 10/1/20 6:01 PM, Dmitry Vyukov wrote:
 >>>   > On Thu, Oct 1, 2020 at 12:48 PM Nikolai Kondrashov
 >>>   > <Nikolai.Kondrashov@redhat.com> wrote:
 >>>   >> * Could you move the "dashboard" link out of test's "output_files", and into
 >>>   >>     a "misc" field? It won't be presented as a link in Grafana unfortunately,
 >>>   >>     but "output_files" is for something which could be useful when downloaded
 >>>   >>     (and e.g. re-hosted by KCIDB), and the linked HTML doesn't seem to be.
 >>>   >>     Let's deal with the dashboard link issue in
 >>>   >>     https://github.com/kernelci/kcidb/issues/93
 >>>   >
 >>>   > Any suggestions/precedents for the name?
 >>>   > dashboard_link? origin_link? master_link?
 >>>
 >>> There's a PR linked which adds "origin_url":
 >>> https://github.com/kernelci/kcidb/pull/94
 >>
 >> I've implemented all suggested improvements, please check this one:
 >> https://staging.kernelci.org:3000/d/test/test?orgId=1&var-dataset=playground_kernelci04&var-id=syzkcidb:0a89a7b56db04c21a656
 >>
 >> Here is top-level link, look for the "https:" one:
 >> https://staging.kernelci.org:3000/d/home/home?orgId=1&refresh=30m&from=now-90d&to=now&var-origin=syzkcidb&var-git_repository_url=All&var-dataset=playground_kernelci04
 >>
 >> Not sure why it's duplicate here, though:
 >> https://staging.kernelci.org:3000/d/build/build?orgId=1&var-dataset=playground_kernelci04&var-id=syzkcidb:1861b29bc5d979149e290f78e331f38f022ab032
 >> both have the same id. If they have the same id, shouldn't they be merged?
 >
 > Oh, I submitted it again and now there 3 of them:
 > https://staging.kernelci.org:3000/d/build/build?orgId=1&var-dataset=playground_kernelci04&var-id=syzkcidb:1861b29bc5d979149e290f78e331f38f022ab032
 >
 > Should they be merged based on id?
 >
 > These ones were submitted manually. Do we do dups for the "syzbot" origin?

No, we don't do de-duping yet, this is what I'm going to work on next, as I
mention in the other message.

I agree, this needs to be handled, but we should try to not resubmit without a
need, in general :)

Nick