From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C515C433B4 for ; Sat, 15 May 2021 17:45:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 710CA610A0 for ; Sat, 15 May 2021 17:45:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234205AbhEORqe (ORCPT ); Sat, 15 May 2021 13:46:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234204AbhEORqc (ORCPT ); Sat, 15 May 2021 13:46:32 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2FDAC061573 for ; Sat, 15 May 2021 10:45:18 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id p20so2233809ljj.8 for ; Sat, 15 May 2021 10:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Uew60+G+SsxW8j8MijONIawIC+5YuiNS9/uDWrf3cP4=; b=q7uMGfIu5kGZ+6hGNujZ64ZmMGy4RAikXSf8gFyIKdRbA71krFjYMlArGdyx2gq9Vq d9WOncS48vT9ws4TVxrvOPftv0vDMA0vs1BNZuOx0H1ORjEG171ueeUTtuYABCXCtDV8 VU02/2EfHzaGqprgipQVXAGhRyhW15jGjR19GiwNRD813aX3pyJgYqC6LekkD/on9E3k VTNYeguiwopR8UazK/toaPKYuSp0akJesQd0poBUiPBsST6mjHa7hywxSBqTb7DyWN1n J7fS/NOQsKnZ4+tBOHtHEefonMt015EkuoJrRFfV35eFvsEiMVk5/759MpZUEX/dRu79 JrNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Uew60+G+SsxW8j8MijONIawIC+5YuiNS9/uDWrf3cP4=; b=jK8CFP0gXAe/cwcrxI8r35+B0BbEgZLjCKJHYqYXZb/tRVLBDE4nqk6AcNqSF0r4qh pc1kRd+7sL9EDaiZAjKRgDFCpeFrKvJhNWRSORVPv9p+MvYAU8KR35Wqw/bqKBfnVScV o7t4EYdtf4DLTbI0ORkGnDbAhJNQXSsCaH+0/ZYzogjdvyFGEUpoOmhVgpyiQjKugwbf OqDWUUIu8Xkd+TezAHdCDUq7FU4aFsiwchQPIza5nHxW7YQKyIOW6NNI5IcDPo5CYEjB Pcy5YmFkWYMX0WcowID+rMN6EXrGRz5ws22+nt5332mEbp+0l0bLpl+kMrRXcv14f0RL 9nsg== X-Gm-Message-State: AOAM533R/LiJf8ifu4YsmI88Me587meHbc13Y5zrDI5mPjNxMRu8rp02 RkHhElHtcHMOgf1OlVE32mpqmQ== X-Google-Smtp-Source: ABdhPJzZpYVpC+2X095uKXRc/Oo5tcpmRjH0WCm9hYwhP9EBhCF2KrssdyelK4eKiW3/vctO7ffvdA== X-Received: by 2002:a2e:b807:: with SMTP id u7mr42869439ljo.67.1621100717420; Sat, 15 May 2021 10:45:17 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id h4sm1430170lfv.264.2021.05.15.10.45.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 May 2021 10:45:16 -0700 (PDT) Subject: Re: [PATCH v2 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init() To: Zhen Lei , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Anton Ivanov , linux-arm-msm , dri-devel , freedreno , linux-kernel References: <20210510031606.3112-1-thunder.leizhen@huawei.com> <20210510031606.3112-2-thunder.leizhen@huawei.com> From: Dmitry Baryshkov Message-ID: Date: Sat, 15 May 2021 20:45:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210510031606.3112-2-thunder.leizhen@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/05/2021 06:16, Zhen Lei wrote: > The error code returned by platform_get_irq() is stored in 'irq', it's > forgotten to be copied to 'ret' before being returned. As a result, the > value 0 of 'ret' is returned incorrectly. > > After the above fix is completed, initializing the local variable 'ret' > to 0 is no longer needed, remove it. > > In addition, when dpu_mdss_init() is successfully returned, the value of > 'ret' is always 0. Therefore, replace "return ret" with "return 0" to make > the code clearer. > > Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > index 06b56fec04e047a..6b0a7bc87eb75b8 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > @@ -225,7 +225,7 @@ int dpu_mdss_init(struct drm_device *dev) > struct msm_drm_private *priv = dev->dev_private; > struct dpu_mdss *dpu_mdss; > struct dss_module_power *mp; > - int ret = 0; > + int ret; > int irq; > > dpu_mdss = devm_kzalloc(dev->dev, sizeof(*dpu_mdss), GFP_KERNEL); > @@ -253,8 +253,10 @@ int dpu_mdss_init(struct drm_device *dev) > goto irq_domain_error; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) > + if (irq < 0) { > + ret = irq; > goto irq_error; > + } > > irq_set_chained_handler_and_data(irq, dpu_mdss_irq, > dpu_mdss); > @@ -263,7 +265,7 @@ int dpu_mdss_init(struct drm_device *dev) > > pm_runtime_enable(dev->dev); > > - return ret; > + return 0; > > irq_error: > _dpu_mdss_irq_domain_fini(dpu_mdss); > -- With best wishes Dmitry