Re: [PATCH v2 01/12] libmultipath: disable user_friendly_names for NetApp

[Martin Wilck <mwilck@suse.de>]

On Sun, 2019-03-17 at 16:04 +0100, Xose Vazquez Perez wrote:
> On 3/9/19 12:11 AM, Benjamin Marzinski wrote:
> 
> > NetApp has tools that rely on devices using WWID names. To avoid
> > breaking these, NetApp devices should continue to use WWID names,
> > even
> > if the default config is set to enable user_friendly_names. If
> > users
> > want to use user_friendly_names on NetApp devices, the must
> > specifically
> > override the device config.
> > 
> > Reviewed-by: Martin Wilck <mwilck@suse.com>
> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> > ---
> >  libmultipath/hwtable.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> > index d3a8d9b..8776411 100644
> > --- a/libmultipath/hwtable.c
> > +++ b/libmultipath/hwtable.c
> > @@ -719,6 +719,7 @@ static struct hwentry default_hw[] = {
> >  		.flush_on_last_del = FLUSH_ENABLED,
> >  		.dev_loss      = MAX_DEV_LOSS_TMO,
> >  		.prio_name     = PRIO_ONTAP,
>                 /* WWID names needed by NetApp tool ... */
> > +		.user_friendly_names = USER_FRIENDLY_NAMES_OFF,
> >  	},
> >  	{
> >  		/*
> > 
> 
> A minimal explanation should be added for a quick reference.

IMO that's not necessary. People who want to know can quickly run "git
blame" to figure this out, and get more information than your single
line comment provides. 

That works as long as we don't mess up the code with "reorder by
comment" patches, that is :-)

Martin