From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E197C3A5A6 for ; Thu, 19 Sep 2019 15:15:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 884BF21848 for ; Thu, 19 Sep 2019 15:15:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="kbS0aFQ5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 884BF21848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=lenovo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AC6501672; Thu, 19 Sep 2019 17:14:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AC6501672 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568906106; bh=C7TWrkU8zu19N9cF2VmcE0GKqfIvv7SbJPLGvE5OCSU=; h=From:To:Date:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kbS0aFQ5TXMX99nK+tCQB2eknGJeUbofH/PT89fkKtnCEdSrmmiMY1lpMibC0p5t+ P5vW+AiSnj3PKqagICGbhVdS8AVeMWed7LDfkTcaMM1e8EaOAa70WqCBNyJwSBF2Qw 0iAQjaUY3lwj1Jl6CfvuUW6Siuq6nF68OHCyBtII= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 35BA5F80146; Thu, 19 Sep 2019 17:14:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F093DF80361; Thu, 19 Sep 2019 17:14:14 +0200 (CEST) Received: from mail1.bemta24.messagelabs.com (mail1.bemta24.messagelabs.com [67.219.250.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 68AE4F80146 for ; Thu, 19 Sep 2019 17:14:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 68AE4F80146 Received: from [67.219.250.102] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-3.bemta.az-a.us-west-2.aws.symcld.net id C8/C4-25909-04B938D5; Thu, 19 Sep 2019 15:14:08 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKKsWRWlGSWpSXmKPExsWS8eIhj67D7OZ Yg/MPZC2uXDzEZNG5q5/VovPTEhYHZo8Nn5vYPFoebGX32Pd2GVsAcxRrZl5SfkUCa8bNV2sZ C3byVByafYK1gXEJTxcjF4eQwH9GifMvPzNDOC8YJT7f+cEE4exllNizZiNjFyMnB5uAhsT82 TNZuhg5OEQEkiQ291qAmMwCWhJPu2RAKoQFsiU2/O9kBrFFBHIkTs34wwZhG0msnjWRGaScRU BVYntjDEiYV8BS4tHuO2BhIYECifNr7EDCnAI2Ejen7gHbySggJvH91BomEJtZQFzi1pP5YLa EgIDEkj3nmSFsUYmXj/+xgoyREFCQuLEhGeIuTYn1u/QhOhUlpnQ/ZIdYKihxcuYTlgmMorOQ DJ2F0DELSccsJB0LGFlWMZonFWWmZ5TkJmbm6BoaGOgaGhrpGhoDaQu9xCrdRL3SYt3y1OISX SO9xPJiveLK3OScFL281JJNjMBYSyloEtrBOHHWG71DjJIcTEqivBs6m2OF+JLyUyozEosz4o tKc1KLDzHKcHAoSfAumgGUEyxKTU+tSMvMAcY9TFqCg0dJhFcPJM1bXJCYW5yZDpE6xWjJMeH l3EXMHAePzgOSR+YuXcQsxJKXn5cqJc77cRpQgwBIQ0ZpHtw4WGq6xCgrJczLyMDAIMRTkFqU m1mCKv+KUZyDUUmYdwbIWp7MvBK4ra+ADmICOsguohHkoJJEhJRUAxP/VMvPPR5B23d+Ygz0e di8+CrX0a/SplEMPFO3MTyeIG/6581yeaFDWsZqh0z2f9t97ddpjYYTSTxZivyL2ttsd+i0sE YeS1G7tYzlSFbBxb4qvvorrb/l/x6bdCTvfPtnk6tKMfNP1L3O6SjaNjv67V03JsU7s8uyt+z sE9QwPGvEIKvXsfCN0mFGLrti/YDdj5Vu/rg4ZWG52Pqo426rpu7PmXDgQe45vX8e84Lqj3+L cvy4t2Lu1kvtlwNfJV4S/7J254aJIfvSZ2yeplBY03lg06Q5Bo6XVp95syh4mp3kom6DZ/9Or P2/c3XQ/e8Z+geLJqxZ+yVmBl9lkp/ijfopbEsmpLsIpHfunfziqhJLcUaioRZzUXEiAEiPGY 7IAwAA X-Env-Sender: mpearson@lenovo.com X-Msg-Ref: server-14.tower-326.messagelabs.com!1568906047!3907!1 X-Originating-IP: [104.232.225.12] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.43.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24363 invoked from network); 19 Sep 2019 15:14:08 -0000 Received: from unknown (HELO aesmtp.lenovo.com) (104.232.225.12) by server-14.tower-326.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 19 Sep 2019 15:14:08 -0000 Received: from reswpmail04.lenovo.com (unknown [10.62.32.23]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by Forcepoint Email with ESMTPS id 49027E1A4D2C9A320EDF; Thu, 19 Sep 2019 11:14:07 -0400 (EDT) Received: from reswpmail05.lenovo.com (10.62.32.4) by reswpmail04.lenovo.com (10.62.32.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1591.10; Thu, 19 Sep 2019 08:14:07 -0700 Received: from reswpmail05.lenovo.com ([fe80::41c7:6219:84e5:c550]) by reswpmail05.lenovo.com ([fe80::41c7:6219:84e5:c550%13]) with mapi id 15.01.1591.008; Thu, 19 Sep 2019 08:14:07 -0700 From: Mark Pearson To: Jaroslav Kysela , "alsa-devel@alsa-project.org" Thread-Topic: [External] Re: [alsa-devel] alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio Thread-Index: AQHVbvmGfT4V198Yt0etODfCnZfiT6czFmWA Date: Thu, 19 Sep 2019 15:14:06 +0000 Message-ID: References: <20190919142329.35bsdnh5skuj7jl3@toy.home.lxtec.de> <6449d5f6-959e-4384-4e80-b68171cd8091@perex.cz> In-Reply-To: <6449d5f6-959e-4384-4e80-b68171cd8091@perex.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.64.83.152] MIME-Version: 1.0 Cc: Elimar Riesebieter Subject: Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > > Too many commmented lines inside without any explanation. The author > should send the patch with the signed-off-by line. Also, we are working on > the LGPL to BSD 3-Clause licence change, so it would be nice to indicate the > agreement with this. > Thanks Jaroslav, I originally got this file from Ubuntu where they worked with Lenovo when certifying our X1 Carbon Gen7 system with Ubuntu. I believe it originally came from Intel but I will confirm. I hadn't even considered licence issues as there isn't a licence in the file - my bad. I'm working my way through the steps to make sure support for our platforms gets into Debian but am new to the process. All pointers would be much appreciated - I'm assuming the two files are going to be generic to all platforms using the whiskeylake processor (and likely over Intel processors?) so the SOF and Intel team likely already have plans for this. I can certainly clean up the file and confirm its original providence. A dumb question - but what do you mean by the signed-off-by line? I looked for a guideline to submitting bugs on the alsa-project wiki and couldn't find any details. Thanks Mark _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel