All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/gcc: disable libcilkrts when there is no thread support
Date: Sun, 21 Oct 2018 14:30:57 +0200	[thread overview]
Message-ID: <c1d43d4b-a6a5-8964-f76d-39e8b5bdc622@gmail.com> (raw)
In-Reply-To: <20181021115415.21471-2-thomas.petazzoni@bootlin.com>

Hi Thomas,

Le 21/10/2018 ? 13:54, Thomas Petazzoni a ?crit?:
> The libcilkrts configure script errors out with "Pthreads are required
> to build libcilkrts" if the C library doesn't have thread support. To
> fix that, we disable libcilkrts when thread support is not available.
> 
> This issue was not noticed until now, because we only regularly build
> a no-thread toolchain for ARM, and libcilkrts was enabled on ARM only
> starting in gcc 7.x.
> 
> This fixes the build of no-thread toolchains on architectures where
> libcilkrts is supported, i.e x86/x86-64, ARM and Sparc.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Reviewed-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain


> ---
>  package/gcc/gcc-final/gcc-final.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
> index 9897d18682..1be0b9bfc9 100644
> --- a/package/gcc/gcc-final/gcc-final.mk
> +++ b/package/gcc/gcc-final/gcc-final.mk
> @@ -81,6 +81,11 @@ ifeq ($(BR2_sparc),y)
>  HOST_GCC_FINAL_CONF_OPTS += --disable-libcilkrts
>  endif
>  
> +# Pthreads are required to build libcilkrts
> +ifeq ($(BR2_PTHREADS_NONE),y)
> +HOST_GCC_FINAL_CONF_OPTS += --disable-libcilkrts
> +endif
> +
>  # Disable shared libs like libstdc++ if we do static since it confuses linking
>  # In that case also disable libcilkrts as there is no static version
>  ifeq ($(BR2_STATIC_LIBS),y)
> 

  reply	other threads:[~2018-10-21 12:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-21 11:54 [Buildroot] [PATCH 0/3] Misc gcc fixes/improvements Thomas Petazzoni
2018-10-21 11:54 ` [Buildroot] [PATCH 1/3] package/gcc: disable libcilkrts when there is no thread support Thomas Petazzoni
2018-10-21 12:30   ` Romain Naour [this message]
2018-10-24 12:37   ` Peter Korsgaard
2018-10-21 11:54 ` [Buildroot] [PATCH 2/3] package/gcc: introduce BR2_GCC_SUPPORTS_LIBCILKRTS Thomas Petazzoni
2018-10-21 12:34   ` Romain Naour
2018-10-21 11:54 ` [Buildroot] [PATCH 3/3] package/gcc: remove BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE Thomas Petazzoni
2018-10-21 12:37   ` Romain Naour
2018-10-21 14:27 ` [Buildroot] [PATCH 0/3] Misc gcc fixes/improvements Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1d43d4b-a6a5-8964-f76d-39e8b5bdc622@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.