Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

[Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>]

Thanks for your time Doug!!!

On 4/21/2022 9:50 PM, Doug Anderson wrote:
> Hi,
>
> On Thu, Apr 21, 2022 at 7:20 AM Srinivasa Rao Mandadapu
> <quic_srivasam@quicinc.com> wrote:
>> Add ldo_l17b in pm7325 regulator, which is required for
>> wcd codec vdd buck supply.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
> The ${SUBJECT} should probably mention qcard somehow? Right now your
> patch subject makes it sound like this applies to all sc7280 boards,
> but this only affects those including the qcard dtsi file.
Okay. Will update the subject accordingly.
>
>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> index b833ba1..17d0c05 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> @@ -113,6 +113,11 @@
>>                          regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>>                  };
>>
>> +               vreg_l17b_1p8: ldo17 {
>> +                       regulator-min-microvolt = <1700000>;
>> +                       regulator-max-microvolt = <1900000>;
> All the other regulators in this file specify:
>
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>
> Why doesn't yours?
Okay. Will add initial mode.