From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: Theodore Ts'o <tytso@mit.edu>, Haotian Li <lihaotian9@huawei.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
"harshad shirwadkar," <harshadshirwadkar@gmail.com>,
linfeilong <linfeilong@huawei.com>
Subject: Re: [PATCH] e2fsprogs: Try again to solve unreliable io case
Date: Fri, 23 Apr 2021 10:18:09 +0800 [thread overview]
Message-ID: <c1eb6441-9081-530c-63d8-1987048b2011@huawei.com> (raw)
In-Reply-To: <YH7/D1h5r9WB1TNq@mit.edu>
On 2021/4/21 0:19, Theodore Ts'o wrote:
> On Tue, Apr 20, 2021 at 03:18:05PM +0800, Haotian Li wrote:
>> If some I/O error occured during e2fsck, for example the
>> fibre channel connections are flasky, the e2fsck may exit.
>> Try again in these I/O error cases may help e2fsck
>> successfully execute and fix the disk correctly.
>
> Why not fix this by retrying in the device driver instead? If the
> Fibre Channel is that flaky, then it's going to be a problem when the
> file system is mounted, so it would seem to me that fixing this in the
> kernel makes a lot more sense.
>
> - Ted
>
Thanks for your reply.
Actually, we have met the problem in ipsan situation.
When exec 'fsck -a <remote-device>', short-term fluctuations or
abnormalities may occur on the network. Despite the driver has
do the best effort, some IO errors may occur. So add retrying in
e2fsprogs can further improve the reliability of the repair
process.
Regards
Zhiqiang Liu
> .
>
next prev parent reply other threads:[~2021-04-23 2:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 7:18 [PATCH] e2fsprogs: Try again to solve unreliable io case Haotian Li
2021-04-20 15:08 ` Darrick J. Wong
2021-04-22 13:03 ` Zhiqiang Liu
2021-04-20 16:19 ` Theodore Ts'o
2021-04-23 2:18 ` Zhiqiang Liu [this message]
2021-04-23 15:46 ` Theodore Ts'o
2021-04-24 4:46 ` Zhiqiang Liu
2021-05-10 3:35 ` Zhiqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1eb6441-9081-530c-63d8-1987048b2011@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=harshadshirwadkar@gmail.com \
--cc=lihaotian9@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.