From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0199C43334 for ; Thu, 9 Jun 2022 12:46:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238431AbiFIMqS (ORCPT ); Thu, 9 Jun 2022 08:46:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbiFIMqS (ORCPT ); Thu, 9 Jun 2022 08:46:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 06DDB212C80 for ; Thu, 9 Jun 2022 05:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654778776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=bfaVa0reba5JNx1JCCi449akB/iE7w7HJkh+iPewcoKUtXRVntBOZRj18BsRFXEJQD7Xt3 GObsr5AzbK9k5Qx9iLnaJWAyVgOUUAb6wweVt7qXGOICRsO1ol959im5WFYdFixia0rC7b ZHeTquzJ+C6aZV+E1vVG8wDxl9vLE1g= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-82-Ux-M1popPDGd1hjx4tmd_A-1; Thu, 09 Jun 2022 08:46:14 -0400 X-MC-Unique: Ux-M1popPDGd1hjx4tmd_A-1 Received: by mail-wm1-f71.google.com with SMTP id c125-20020a1c3583000000b003978decffedso15936768wma.5 for ; Thu, 09 Jun 2022 05:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=WZfUzCQAhyoFk0VLWH1zalBZj6+Scbq7eX1JDFoZ/oT7h6DXiCieu84mGIdgm5nQDH 2NCguy+oJ0NMKB/NhJy0cDQwqcDhEWrxmp8N+55zQf/R2qJVqBXGHltA6tp9iZvyG8u1 vRHSIEKGbk3qA7eHXSx2YQNQlfSPX29Y5Co7T+6jutkJvOnAVNTSOfqW2LBAYY/J8Srt OtVh1TxPkgo4e9ZwV0vu+u4uGMSqcnsQ9AMZ4yV26NiEAyAyrYlF65CsqJHi/adcyCos b8iUWSxg1ruPYvedhIoYvmrWHYCOQpTCUDb4NoDt/TwD3JuAFZXJBsKUTiXNs9/q1DYI BDOg== X-Gm-Message-State: AOAM530BktpMyCnW62kz1ZfRCgClQing6UDj5q/8Am+PuQA2EM6Ra54n A+ASwyT0hQQGYOLXDQkwqYHdMjpF5TM+2K3z48xdRHvln+03lpmKxahiyKFhIVkZaAmGKPlv8y3 Qcc//5RnUqc7hKhB1KNVnk4g= X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022155wrd.283.1654778773732; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFg5i2EPJ88Gv87gtw7EHVrLhSwsyQAltgpPZk1DxRKIUlDObIOhdmhH9jKki5ThpOI9Vqng== X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022117wrd.283.1654778773451; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id a7-20020a05600c224700b0039c693a54ecsm3854607wmm.23.2022.06.09.05.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 05:46:12 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 14:46:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 01/19] secretmem: Remove isolate_page Content-Language: en-US To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, virtualization@lists.linux-foundation.org References: <20220608150249.3033815-1-willy@infradead.org> <20220608150249.3033815-2-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220608150249.3033815-2-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > The isolate_page operation is never called for filesystems, only > for device drivers which call SetPageMovable. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/secretmem.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 206ed6b40c1d..1c7f1775b56e 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -133,11 +133,6 @@ static const struct file_operations secretmem_fops = { > .mmap = secretmem_mmap, > }; > > -static bool secretmem_isolate_page(struct page *page, isolate_mode_t mode) > -{ > - return false; > -} > - > static int secretmem_migratepage(struct address_space *mapping, > struct page *newpage, struct page *page, > enum migrate_mode mode) > @@ -155,7 +150,6 @@ const struct address_space_operations secretmem_aops = { > .dirty_folio = noop_dirty_folio, > .free_folio = secretmem_free_folio, > .migratepage = secretmem_migratepage, > - .isolate_page = secretmem_isolate_page, > }; > > static int secretmem_setattr(struct user_namespace *mnt_userns, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aib29ajc246.phx1.oracleemaildelivery.com (aib29ajc246.phx1.oracleemaildelivery.com [192.29.103.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81DCDC433EF for ; Thu, 9 Jun 2022 12:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oss-phx-1109; d=oss.oracle.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=ZaDsoELL6anQPRCfAdYBPVfP+yP2nv9/9wpq6JwLhN8=; b=y7QyNjmZC2ozQOsVW/YQJ4yOBrXd1tn95nXukRY+rVXap95xaTWf2MFUnbYs30ElSFg2UqtKb1cc 5FxnT8tpM0asCnsCquZP74eBkth4ydLWRmhcYcRiM32M692lwQ2PcykzKCvp1dDVG/WHyeOW5QPh 0g9RDd143sje67d7BZJgEQ2vW5D2Ju2BJv9fiAXcdu/TGK4gC8hJPENoKFQlW0BHJ/b1hppX22wg weoxbhriBkdUzOs1M0kvb+hCN6WSvhlrcMLY9t/T7PMgwbu98X8pweDOpdMn/4j2Z/gNMJiJyyS9 H8PPj7bAnsiIvSFh+UfMrATnM1og8QXi2eFhgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-phx-20191217; d=phx1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=ZaDsoELL6anQPRCfAdYBPVfP+yP2nv9/9wpq6JwLhN8=; b=OXb5KK2TudWMD3spaFzhDq45VF5aEesXWLeHtsf3Ul3PuiIU2y2jksggwiyG9PXJccYwjT3E6+nv X996s/KuKXyYWiV+nUgSL9fs32UI6BK9ch2g3JRHqTrXNRbgWITxm2tBPLPEhvZWkZ6vfRtQBj4O x8QKVevRmsW+IXIeBA2emL+HAhYcqk8mrnVBFU/ora/rhmrOHXnhl96igIFF2Zly2j0lZrXirCZc 3yFsoe0tTgNdDvXrwLIKeM6nhCVMv7Ocp6ofdl8B5LiG3mLOcF1YS386inPaSHpdMTzFK2wOXla6 oCD7Ir4L7Ax23gTlESlJdxpPGQFN0shIk6C1bA== Received: by omta-ad1-fd3-101-us-phoenix-1.omtaad1.vcndpphx.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20220517 64bit (built May 17 2022)) with ESMTPS id <0RD700702NHHLH80@omta-ad1-fd3-101-us-phoenix-1.omtaad1.vcndpphx.oraclevcn.com> for ocfs2-devel@archiver.kernel.org; Thu, 09 Jun 2022 12:46:29 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654778776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=bfaVa0reba5JNx1JCCi449akB/iE7w7HJkh+iPewcoKUtXRVntBOZRj18BsRFXEJQD7Xt3 GObsr5AzbK9k5Qx9iLnaJWAyVgOUUAb6wweVt7qXGOICRsO1ol959im5WFYdFixia0rC7b ZHeTquzJ+C6aZV+E1vVG8wDxl9vLE1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=nJ9EVVbXo5GeX11AmXR7G8wkjECmjjgdbWpbu/QZROTOnUOHKywqsAOTDqH25+FNhV MEi80jH+oDTyoObjkwItw4saCFPNKSNtu75YO7GG+1R+A521CcvAVEqCuxl5FKR2mutL e3jcg72W13rMrTFfsRWiJc9xKKRmHvO0CiANaJlmHvEys9OpvmhXiwgbOGGoJ8MApuEF 9tzspCJKNXZKqioVaO4C6rZp2YrnAecrA9PGW/ko2VDOxoCKS1TXAxra1J4NnREdfnBx 1wnwItyZa9GcYyu1dK+5CB3aT7UwVQatAk+oN/dIcRmLCKBVAVMsNUW2tu7ZiYlW0CG8 8Ftw== X-Gm-Message-State: AOAM533vHIEYuAJv7JJG8iNVN7jwX3gBUzDtrTFpuZkXZdzOXjRnugZ8 t4yKn5bme+5J8tEbb4dO/5V/E77fs7dCMcADSqMiPDyvmpFOeqlOufrUXJj6d/gkuqG1m3KBqq9 lqaQ/PkvL5iv0+I+pU4OuXw== X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022157wrd.283.1654778773733; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022117wrd.283.1654778773451; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) Message-id: Date: Thu, 9 Jun 2022 14:46:11 +0200 MIME-version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org References: <20220608150249.3033815-1-willy@infradead.org> <20220608150249.3033815-2-willy@infradead.org> Organization: Red Hat In-reply-to: <20220608150249.3033815-2-willy@infradead.org> Authentication-results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com Content-language: en-US X-Source-IP: 170.10.129.124 X-Proofpoint-Virus-Version: vendor=nai engine=6400 definitions=10372 signatures=594849 Cc: linux-aio@kvack.org, linux-nfs@vger.kernel.org, cluster-devel@redhat.com, linux-ntfs-dev@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [Ocfs2-devel] [PATCH v2 01/19] secretmem: Remove isolate_page X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: David Hildenbrand via Ocfs2-devel Reply-to: David Hildenbrand Content-type: text/plain; charset="us-ascii" Content-transfer-encoding: 7bit Errors-to: ocfs2-devel-bounces@oss.oracle.com X-MC-Unique: 7UiEVf6IN0SK2IqEVac5hg-1 X-Google-Smtp-Source: ABdhPJxFg5i2EPJ88Gv87gtw7EHVrLhSwsyQAltgpPZk1DxRKIUlDObIOhdmhH9jKki5ThpOI9Vqng== X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 ip4:103.23.64.2 ip4:103.23.65.2 ip4:103.23.66.26 ip4:103.23.67.26 ip4:107.21.15.141 ip4:108.177.8.0/21 ip4:128.17.0.0/20 ip4:128.17.128.0/20 ip4:128.17.192.0/20 ip4:128.17.64.0/20 ip4:128.245.0.0/20 ip4:128.245.64.0/20 ip4:13.110.208.0/21 ip4:13.110.216.0/22 ip4:13.110.224.0/20 ip4:13.111.0.0/16 ip4:136.147.128.0/20 include:spf1.redhat.com -all X-Proofpoint-SPF-VenPass: Allowed X-ServerName: us-smtp-delivery-124.mimecast.com X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 ip4:103.23.64.2 ip4:103.23.65.2 ip4:103.23.66.26 ip4:103.23.67.26 ip4:107.21.15.141 ip4:108.177.8.0/21 ip4:128.17.0.0/20 ip4:128.17.128.0/20 ip4:128.17.192.0/20 ip4:128.17.64.0/20 ip4:128.245.0.0/20 ip4:128.245.64.0/20 ip4:13.110.208.0/21 ip4:13.110.216.0/22 ip4:13.110.224.0/20 ip4:13.111.0.0/16 ip4:136.147.128.0/20 include:spf1.redhat.com -all X-Proofpoint-Spam-Reason: safe X-Spam: OrgSafeList X-SpamRule: orgsafelist X-Proofpoint-GUID: nLo87hmh-RU0ayih1RRdd0cUHXnpQ9T0 X-Proofpoint-ORIG-GUID: nLo87hmh-RU0ayih1RRdd0cUHXnpQ9T0 Reporting-Meta: AAGni/yQTh7fcOMzRT8aS4a0ZQqGUSrNXFi8yvblSY96+bYcuAwOKXGKSYq0J9NO jXJyXToyLxAW4+bQ/jOQP0qt0m/kg+O6hANzeQIRVB7OkcSZMBV2N5sjaktRCo0/ Qh94DAyvi5prbeSD7LFFabG9HHDFKzR5RsC7qE+siyMM4k97QfPjcRNw2o+czZPg OebWff+SYTwTiBjf0Jutx9mDt9AGs84EJm1v6xii9+sO0Sg/um1tjrlDBLE9B3+J xsnjOkn5vrZurhtZXhHmbeN2Sj7uNyCxdvlAjRV6qTIf/TJY4rQdyUALmMoqQcTM hcGdljeAJ8xqnGtIaDZPnwMvxnAkV+vWt4SroafRFKD3g3Zat0tqtwIZYvd7RdwQ rZEJkWwHTnrzbsDmNcws06UlbIK1h6Cx/RMM3oT6vEzGNA5shUpL3MR13TFhaPY2 o/RBBm7dOYCQwtCulTDJAgI0d5rrq/oWyHIRjosIk6OWgQtWNWo03/ghmdC65gyK GFRm2cSP+UC2fbb/QXafjt8hTSE5KH5TuIp3n7IK053v On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > The isolate_page operation is never called for filesystems, only > for device drivers which call SetPageMovable. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/secretmem.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 206ed6b40c1d..1c7f1775b56e 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -133,11 +133,6 @@ static const struct file_operations secretmem_fops = { > .mmap = secretmem_mmap, > }; > > -static bool secretmem_isolate_page(struct page *page, isolate_mode_t mode) > -{ > - return false; > -} > - > static int secretmem_migratepage(struct address_space *mapping, > struct page *newpage, struct page *page, > enum migrate_mode mode) > @@ -155,7 +150,6 @@ const struct address_space_operations secretmem_aops = { > .dirty_folio = noop_dirty_folio, > .free_folio = secretmem_free_folio, > .migratepage = secretmem_migratepage, > - .isolate_page = secretmem_isolate_page, > }; > > static int secretmem_setattr(struct user_namespace *mnt_userns, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FD82C43334 for ; Thu, 9 Jun 2022 12:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=udsFl8IVncUO1Ebh0fjgAn5Tpmzgoea+XdB38oQh83s=; b=gF+SaOxTzU9euE 2i3YM+rcYDiW8Rgxm+PZVl+x9MB3ir+F38YAMstDWvJCWwEsZ8w3mD/j5g0E2NhaZoS4CV1CwyPSx hOyrfSI9YWniRLa9H1HfoOzxvme1VNen8cj7rNRn543iIgSgruRSY+nzw0yQ8v7BngTLYz+u79ART YmtJYHZoJEaglul2JG6APykUdENDt4+JlvDWjeGXk4fG1irwVANtag0CW/C9KT0RHsU5lcfnszQJb AzB6PA+7wdLmbVurSTnTFnXxgT+VTAFftwcyJvIXp5EeJngQq+FobQMBfEWNBxKB0PX/KOyNFIHj7 o9D7kuH5lyow7ANg3DDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzHYK-001s0P-NB; Thu, 09 Jun 2022 12:46:20 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzHYH-001rxY-9w for linux-mtd@lists.infradead.org; Thu, 09 Jun 2022 12:46:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654778776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=bfaVa0reba5JNx1JCCi449akB/iE7w7HJkh+iPewcoKUtXRVntBOZRj18BsRFXEJQD7Xt3 GObsr5AzbK9k5Qx9iLnaJWAyVgOUUAb6wweVt7qXGOICRsO1ol959im5WFYdFixia0rC7b ZHeTquzJ+C6aZV+E1vVG8wDxl9vLE1g= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-508-BXtztT2TM3qA5uILIbTvnw-1; Thu, 09 Jun 2022 08:46:14 -0400 X-MC-Unique: BXtztT2TM3qA5uILIbTvnw-1 Received: by mail-wm1-f71.google.com with SMTP id u12-20020a05600c19cc00b0038ec265155fso15941576wmq.6 for ; Thu, 09 Jun 2022 05:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=31FQFhCUSeAm6Lzn4E/ha6s6sL+1TjuwgXv2iBC2LvTD9cbw2uJCyMfQhME0w3Awme t7j/muS7QmhWpJEuHpYLa8mal2HKx+yr0tL9DG+0oVVU6mKqICaHhQWcL5dlYNPveOO1 ZNVmyS0OZTsmWc41h1LB1sx5UtadVMtSUmNrzIdbUXC5NHzsCx1yh9XWIzQ5LQoB3CJn W/jqSDKUAjHlZOegPOpehd9qgHJPrQRDUkbsLAJ6NZ/Jt4KsfDwJ6PRokcoKeV+pmw2H Q78aq0KjGKs0ULwalneGX6LWgaMKTbWUnKBO5v4IFXb0OMIRb34+TBlwWesiFf1XEWUY u5Eg== X-Gm-Message-State: AOAM5325a/lqAN8plx9m5mE3OyVOvOn+VRS2lqetPgPrkxvWYNOneHjd FgLFBDMgAOiH7IEMRCZNGo0L3E67WNgIubeIldn0/Q3O00nwyUai2FsnXy4Kt2ktaCLCRVS0VLh bBwrCCCI009hR3SYrQ/tzUS3X0g== X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022154wrd.283.1654778773732; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFg5i2EPJ88Gv87gtw7EHVrLhSwsyQAltgpPZk1DxRKIUlDObIOhdmhH9jKki5ThpOI9Vqng== X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022117wrd.283.1654778773451; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id a7-20020a05600c224700b0039c693a54ecsm3854607wmm.23.2022.06.09.05.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 05:46:12 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 14:46:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 01/19] secretmem: Remove isolate_page To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, virtualization@lists.linux-foundation.org References: <20220608150249.3033815-1-willy@infradead.org> <20220608150249.3033815-2-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220608150249.3033815-2-willy@infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_054617_484166_64047FC2 X-CRM114-Status: GOOD ( 15.26 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > The isolate_page operation is never called for filesystems, only > for device drivers which call SetPageMovable. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/secretmem.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 206ed6b40c1d..1c7f1775b56e 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -133,11 +133,6 @@ static const struct file_operations secretmem_fops = { > .mmap = secretmem_mmap, > }; > > -static bool secretmem_isolate_page(struct page *page, isolate_mode_t mode) > -{ > - return false; > -} > - > static int secretmem_migratepage(struct address_space *mapping, > struct page *newpage, struct page *page, > enum migrate_mode mode) > @@ -155,7 +150,6 @@ const struct address_space_operations secretmem_aops = { > .dirty_folio = noop_dirty_folio, > .free_folio = secretmem_free_folio, > .migratepage = secretmem_migratepage, > - .isolate_page = secretmem_isolate_page, > }; > > static int secretmem_setattr(struct user_namespace *mnt_userns, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C21FCCA47F for ; Thu, 9 Jun 2022 12:46:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BB397610F0; Thu, 9 Jun 2022 12:46:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kqt1jXxsogWp; Thu, 9 Jun 2022 12:46:21 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 522D3610EC; Thu, 9 Jun 2022 12:46:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 27285C0039; Thu, 9 Jun 2022 12:46:21 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3CEF8C002D for ; Thu, 9 Jun 2022 12:46:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1D8D2610E8 for ; Thu, 9 Jun 2022 12:46:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MVoGcuQ3Xgau for ; Thu, 9 Jun 2022 12:46:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 4E100610E6 for ; Thu, 9 Jun 2022 12:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654778776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=bfaVa0reba5JNx1JCCi449akB/iE7w7HJkh+iPewcoKUtXRVntBOZRj18BsRFXEJQD7Xt3 GObsr5AzbK9k5Qx9iLnaJWAyVgOUUAb6wweVt7qXGOICRsO1ol959im5WFYdFixia0rC7b ZHeTquzJ+C6aZV+E1vVG8wDxl9vLE1g= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-i7VOkGf_PVaKV6J9BGozJA-1; Thu, 09 Jun 2022 08:46:15 -0400 X-MC-Unique: i7VOkGf_PVaKV6J9BGozJA-1 Received: by mail-wm1-f69.google.com with SMTP id k32-20020a05600c1ca000b0039c4cf75023so6958060wms.9 for ; Thu, 09 Jun 2022 05:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=X8fNwgjvgbHFw7Sl36YyaWwNCK7hB8gAwb84vpHkQAlBiFoUEFxyalbXRCHrY8MnCE fhINojyY2DGqEs3uhNFYY1QUI6bUl+qt6hEwF28cViIgQ8AcUzddftcc45F8MtkOFHzD l6agoEsLCiQR9/ncVdz4TZRr0G6v+87OHCkF6LCw+hneqOKxGFPBs35Pk9kZ/P+MFwXT kGW/DgUP9jCfdO7W7hQXxiplEoE87zrDn06imCQ/AybgPSUKy0iFQn0hUq6tGQ8RAHYE f0eP3TPUXCpGvzK46jjOEOc6YDoiDb9f29FEw48bV1JIvwnODg1Lyd1AHbOLEzJCqqsu aq9g== X-Gm-Message-State: AOAM533iu1XTMYhrJdTDe73o8EEuOUBH5KJck+J09cVVK14aZbr+lwoJ e8kZ79vhA2ibsMghNa1SZDF7b1m8Pg0co581PT5Y7ESN8vjtRS3yyrM5aCAn1mZVg88k9YVFQ2X VWF0MJDgn8IIgCmrFEApNwhGrvAL9j6DmJczCEqeYiQ== X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022153wrd.283.1654778773731; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFg5i2EPJ88Gv87gtw7EHVrLhSwsyQAltgpPZk1DxRKIUlDObIOhdmhH9jKki5ThpOI9Vqng== X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022117wrd.283.1654778773451; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id a7-20020a05600c224700b0039c693a54ecsm3854607wmm.23.2022.06.09.05.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 05:46:12 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 14:46:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 01/19] secretmem: Remove isolate_page To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org References: <20220608150249.3033815-1-willy@infradead.org> <20220608150249.3033815-2-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220608150249.3033815-2-willy@infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: linux-aio@kvack.org, linux-nfs@vger.kernel.org, cluster-devel@redhat.com, linux-ntfs-dev@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > The isolate_page operation is never called for filesystems, only > for device drivers which call SetPageMovable. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/secretmem.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 206ed6b40c1d..1c7f1775b56e 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -133,11 +133,6 @@ static const struct file_operations secretmem_fops = { > .mmap = secretmem_mmap, > }; > > -static bool secretmem_isolate_page(struct page *page, isolate_mode_t mode) > -{ > - return false; > -} > - > static int secretmem_migratepage(struct address_space *mapping, > struct page *newpage, struct page *page, > enum migrate_mode mode) > @@ -155,7 +150,6 @@ const struct address_space_operations secretmem_aops = { > .dirty_folio = noop_dirty_folio, > .free_folio = secretmem_free_folio, > .migratepage = secretmem_migratepage, > - .isolate_page = secretmem_isolate_page, > }; > > static int secretmem_setattr(struct user_namespace *mnt_userns, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF176C43334 for ; Thu, 9 Jun 2022 12:46:58 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nzHYt-0006KW-MU; Thu, 09 Jun 2022 12:46:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzHYs-0006KQ-Pf for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Jun 2022 12:46:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=VU+qTFkCjmB0qGrsmtUvUrOZ2r BKKi1/f64+6wjEJzqHesU2wGc7/URWqc/TvRSNDZz8YMG0ts0pKJrpIOYWTu8oXbQGcUbr/AgdQNr c25SjaTF3njMfGvwjjkoTmjDJoawR9m+nPpAkjZiqZr1PJA8j5PGytYXNCreKJfggQGY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=IJOf/C9GTerWxG0gzm5fkir+em uEq/gJXw27erGE8SAGbF7/ZuLxn2p8pSDdjtUUbaVCjxeYTtyif/fxdrlceENjqyXs2o8og1e7C6p pr80e2Mlejbm7YMDT+1zsEI3IufG7fLG3qPyCtCT65M4sfcuG6s42ka2Qjqa5RKu5o0o=; Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nzHYK-0004CJ-Sp for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Jun 2022 12:46:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654778775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=VGZsBrLCDUGucota6u0ppSg4dENr59/5LV6as6RlGw2FDbFCrTYy90pqYKfzoN90C7aIxN 8/9mbLt3ugnVsg6/wxiSV1S1rsjWAk9Z78U/nYY8qN3fHvg+0aBG/2SG9h1AFIx4FwHL1L SZjWoQM54qNvylt98NRupHDSI2W4RSs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-508-3sThPFhKP0SbucWreJPK9g-1; Thu, 09 Jun 2022 08:46:14 -0400 X-MC-Unique: 3sThPFhKP0SbucWreJPK9g-1 Received: by mail-wm1-f71.google.com with SMTP id o2-20020a05600c510200b0039747b0216fso15965857wms.0 for ; Thu, 09 Jun 2022 05:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=mjjKt5vCXvIgPD9PJQ8zYC8sj8wyO0wiGUybO0NmM5vR7K+YtznD2+a8pre52iK+Uh 2DTYyCSYY/e80CvG8zHunfu5ErrBK7sI/ksexm8Vqd+X4ehhlkYO84XeUVyX1HzZd6Lw Dl+fKWzGjZIGSiQoIM8Hxd6an6MnTLFmAPC6dj1h5/bomi1ZKf02K66EZbcDU+qrgQ3+ 9vk/Z3nWaZzZysi2Lan9xGyZafhDAPXnoIvyrTqY2ks1P0SEd59jcm19oi9N4D59HjUL HjlLLTUUjkFUfwPBjtiovq8+AL6W4eAGYtKlp3eXM6w2P2Pq0fP4nn/M96OJUAWeEza+ 5fLQ== X-Gm-Message-State: AOAM531mc8ccl4KyHUGT1l6LpIiTQTh/5HECca8O6GqFa7yXikl2GK2i Jwl18JpAB32T4Ona0IETHFK9C34Kgt84evxycJ4MHolGSuZUt8DNxP44Et7cWkKgNBZ/nyuS3gi Vr9FNjAByKd7Zs/e5XpD8Ii9T7Xhkei6N6tB2DQ== X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022147wrd.283.1654778773728; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFg5i2EPJ88Gv87gtw7EHVrLhSwsyQAltgpPZk1DxRKIUlDObIOhdmhH9jKki5ThpOI9Vqng== X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022117wrd.283.1654778773451; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id a7-20020a05600c224700b0039c693a54ecsm3854607wmm.23.2022.06.09.05.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 05:46:12 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 14:46:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org References: <20220608150249.3033815-1-willy@infradead.org> <20220608150249.3033815-2-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220608150249.3033815-2-willy@infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Headers-End: 1nzHYK-0004CJ-Sp Subject: Re: [f2fs-dev] [PATCH v2 01/19] secretmem: Remove isolate_page X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aio@kvack.org, linux-nfs@vger.kernel.org, cluster-devel@redhat.com, linux-ntfs-dev@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > The isolate_page operation is never called for filesystems, only > for device drivers which call SetPageMovable. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/secretmem.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 206ed6b40c1d..1c7f1775b56e 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -133,11 +133,6 @@ static const struct file_operations secretmem_fops = { > .mmap = secretmem_mmap, > }; > > -static bool secretmem_isolate_page(struct page *page, isolate_mode_t mode) > -{ > - return false; > -} > - > static int secretmem_migratepage(struct address_space *mapping, > struct page *newpage, struct page *page, > enum migrate_mode mode) > @@ -155,7 +150,6 @@ const struct address_space_operations secretmem_aops = { > .dirty_folio = noop_dirty_folio, > .free_folio = secretmem_free_folio, > .migratepage = secretmem_migratepage, > - .isolate_page = secretmem_isolate_page, > }; > > static int secretmem_setattr(struct user_namespace *mnt_userns, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Date: Thu, 9 Jun 2022 14:46:11 +0200 Subject: [Cluster-devel] [PATCH v2 01/19] secretmem: Remove isolate_page In-Reply-To: <20220608150249.3033815-2-willy@infradead.org> References: <20220608150249.3033815-1-willy@infradead.org> <20220608150249.3033815-2-willy@infradead.org> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > The isolate_page operation is never called for filesystems, only > for device drivers which call SetPageMovable. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/secretmem.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 206ed6b40c1d..1c7f1775b56e 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -133,11 +133,6 @@ static const struct file_operations secretmem_fops = { > .mmap = secretmem_mmap, > }; > > -static bool secretmem_isolate_page(struct page *page, isolate_mode_t mode) > -{ > - return false; > -} > - > static int secretmem_migratepage(struct address_space *mapping, > struct page *newpage, struct page *page, > enum migrate_mode mode) > @@ -155,7 +150,6 @@ const struct address_space_operations secretmem_aops = { > .dirty_folio = noop_dirty_folio, > .free_folio = secretmem_free_folio, > .migratepage = secretmem_migratepage, > - .isolate_page = secretmem_isolate_page, > }; > > static int secretmem_setattr(struct user_namespace *mnt_userns, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb