All of
 help / color / mirror / Atom feed
From: Max Reitz <>
To: Kevin Wolf <>,
Subject: Re: [PATCH 2/2] iotests: Run pylint and mypy in a testcase
Date: Wed, 13 May 2020 14:14:15 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1.1: Type: text/plain, Size: 1362 bytes --]

On 11.05.20 18:35, Kevin Wolf wrote:
> We made sure that passes pylint. It would be a shame if we
> allowed new patches in that break this again, so let's just add a
> meta-test case that runs pylint on it.
> While we don't pass mypy --strict yet, we can already run it with a few
> options that would be part of --strict to make sure that we won't
> regress on these aspects at least until we can enable the full thing.
> Signed-off-by: Kevin Wolf <>
> ---
>  tests/qemu-iotests/297     | 44 ++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/297.out |  3 +++
>  tests/qemu-iotests/group   |  1 +
>  3 files changed, 48 insertions(+)
>  create mode 100755 tests/qemu-iotests/297
>  create mode 100644 tests/qemu-iotests/297.out

Bit of a shame that this takes 8 s (on my machine at least) and will run
with every format/protocol combination unless I explictly exclude it
with -x meta...  But I suppose the actual problem here is the fact that
tests still can’t just define a “This is the format/protocol combination
I require” and then you can just let all tests run once with that
default combination.  (And maybe afterwards run all tests again with
some custom combinations, but only when that makes sense.)

Well.  Not a new problem.

Reviewed-by: Max Reitz <>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-05-13 12:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 16:35 [PATCH 0/2] iotests: Run pylint and mypy in a testcase Kevin Wolf
2020-05-11 16:35 ` [PATCH 1/2] iotests: Fix incomplete type declarations Kevin Wolf
2020-05-13 11:57   ` Max Reitz
2020-05-11 16:35 ` [PATCH 2/2] iotests: Run pylint and mypy in a testcase Kevin Wolf
2020-05-13 12:14   ` Max Reitz [this message]
2020-05-13 14:54     ` Kevin Wolf
2020-05-13 20:56 ` [PATCH 0/2] " John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.