From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E1CC433EF for ; Tue, 24 May 2022 15:57:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239150AbiEXP5z (ORCPT ); Tue, 24 May 2022 11:57:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239139AbiEXPz4 (ORCPT ); Tue, 24 May 2022 11:55:56 -0400 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC2BD98096; Tue, 24 May 2022 08:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=qMEBoG8lqFJvGve+K5m+z9fgN9hILK6ZisKxqQim1eM=; b=XFlcW/TpHW8e5ACmg+/YYTcud5 kFsXafcr7Cytf6qeJfc86HtV/G4yR5wGWRknuahG3h9Cx3mrMXB2ncbMui7tvMx+kliUcfOIQMtGI ICGsOv6+XQyTAltzLG9aU+SDiIK83MgM6wdqtVo9hC1dnhncrRZF5Vr3QAiLVtU3kyeDbbRebGkQo BBvxRnls9jKK7VVfkPrVuwZbgT5poxyEkZ5cx7ZQZY3IPMsuVVd43VAnSk+bqIr2sjcA72ZoQGpAb 3YBFrW/iRUAccGkbMIDLQkrx+kkEqVFGXnUtuvSPzopL3VddTeq99Cq7eI8Z+bdaiY74HxQfME4c3 tbepAB8w==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1ntWsy-006R7q-R4; Tue, 24 May 2022 09:55:54 -0600 Message-ID: Date: Tue, 24 May 2022 09:55:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-CA To: Donald Buczek , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Song Liu Cc: Christoph Hellwig , Guoqing Jiang , Xiao Ni , Stephen Bates , Martin Oliveira , David Sloan References: <20220519191311.17119-1-logang@deltatee.com> <20220519191311.17119-13-logang@deltatee.com> <571344e2-6e43-a72f-bd12-04d650e669fd@molgen.mpg.de> From: Logan Gunthorpe In-Reply-To: <571344e2-6e43-a72f-bd12-04d650e669fd@molgen.mpg.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: buczek@molgen.mpg.de, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, song@kernel.org, hch@infradead.org, guoqing.jiang@linux.dev, xni@redhat.com, sbates@raithlin.com, Martin.Oliveira@eideticom.com, David.Sloan@eideticom.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On 2022-05-22 01:32, Donald Buczek wrote: >> /* >> @@ -703,7 +720,7 @@ static void r5c_disable_writeback_async(struct work_struct *work) >> >> /* wait superblock change before suspend */ >> wait_event(mddev->sb_wait, >> - conf->log == NULL || >> + rcu_access_pointer(conf->log) || > > Reversed condition? > > I think, some examples in Documentation/RCU/Design/Requirements/Requirements.rst are reversed, too. Oops. Nice Catch! Thanks, Logan