All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Like Xu <like.xu.linux@gmail.com>
Subject: Re: [RFC PATCH 0/3] KVM: x86: Disallow writes to feature MSRs post-KVM_RUN
Date: Wed, 10 Aug 2022 14:52:36 +0200	[thread overview]
Message-ID: <c2335a69-c243-3c5f-b983-938c91cb5c2c@redhat.com> (raw)
In-Reply-To: <20220805172945.35412-1-seanjc@google.com>

On 8/5/22 19:29, Sean Christopherson wrote:
> Give feature MSRs that same treatment as CPUID and disallow changing said
> MSRs after KVM_RUN.
> 
> RFC as this is lightly tested and should come with a selftests update to
> verify it actually works.  Posting early to get feedback on the overall
> idea, and on the VMX MSRs trickery (though I think patches 1-2 are a good
> idea irrespective of trying to reduce the overhead of the new check).

They are good, just a small style remark on patch 2.

Paolo


      parent reply	other threads:[~2022-08-10 12:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 17:29 [RFC PATCH 0/3] KVM: x86: Disallow writes to feature MSRs post-KVM_RUN Sean Christopherson
2022-08-05 17:29 ` [RFC PATCH 1/3] KVM: x86: Add macros to track first...last VMX feature MSRs Sean Christopherson
2022-08-05 17:29 ` [RFC PATCH 2/3] KVM: x86: Generate set of VMX feature MSRs using first/last definitions Sean Christopherson
2022-08-10 12:52   ` Paolo Bonzini
2022-08-10 14:40     ` Sean Christopherson
2022-08-10 19:16       ` Paolo Bonzini
2022-08-05 17:29 ` [RFC PATCH 3/3] KVM: x86: Disallow writes to immutable feature MSRs after KVM_RUN Sean Christopherson
2022-08-10  6:29   ` Xiaoyao Li
2022-08-10 14:45     ` Sean Christopherson
2022-08-10 12:52 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2335a69-c243-3c5f-b983-938c91cb5c2c@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=like.xu.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.