From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753111AbdDDLs5 (ORCPT ); Tue, 4 Apr 2017 07:48:57 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:34287 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752461AbdDDLsz (ORCPT ); Tue, 4 Apr 2017 07:48:55 -0400 Subject: Re: [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI tps6105x chip To: Lee Jones References: <20170401071854.23198-1-javier@osg.samsung.com> <20170401071854.23198-6-javier@osg.samsung.com> <20170403111540.7k3rjucvcxe5cunf@dell> <20170404082739.6w6ltgdr2mgaqq4l@dell> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland From: Javier Martinez Canillas Message-ID: Date: Tue, 4 Apr 2017 07:48:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170404082739.6w6ltgdr2mgaqq4l@dell> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Lee, On 04/04/2017 04:27 AM, Lee Jones wrote: > On Mon, 03 Apr 2017, Javier Martinez Canillas wrote: > >> Hello Lee, >> >> On 04/03/2017 07:15 AM, Lee Jones wrote: >> >> [snip] >> >>>> + >>>> +The TP61050/TPS61052 is a high-power "white LED driver". This boost converter >>>> +is also used for other things than white LEDs, and also contains a GPIO pin. >>> >>> What functions does it offer? >>> >> >> Same comment than before, I'm not really familiar with this driver. But I'll >> look what are the MFD cell instantiated to better understand dev functions >> and expand this documentation accordingly. > > Writing documentation for H/W you are unfamiliar with is a bad idea IMHO. > I just wanted to add an OF device ID table to the driver to make sure the driver won't have a regression when the I2C core reports an OF modalias but was asked to also write a DT binding doc in this case... I'm happy to drop the DT binding doc patch and someone more familiar to do it as a follow up. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI tps6105x chip Date: Tue, 4 Apr 2017 07:48:48 -0400 Message-ID: References: <20170401071854.23198-1-javier@osg.samsung.com> <20170401071854.23198-6-javier@osg.samsung.com> <20170403111540.7k3rjucvcxe5cunf@dell> <20170404082739.6w6ltgdr2mgaqq4l@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170404082739.6w6ltgdr2mgaqq4l@dell> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org Hello Lee, On 04/04/2017 04:27 AM, Lee Jones wrote: > On Mon, 03 Apr 2017, Javier Martinez Canillas wrote: > >> Hello Lee, >> >> On 04/03/2017 07:15 AM, Lee Jones wrote: >> >> [snip] >> >>>> + >>>> +The TP61050/TPS61052 is a high-power "white LED driver". This boost converter >>>> +is also used for other things than white LEDs, and also contains a GPIO pin. >>> >>> What functions does it offer? >>> >> >> Same comment than before, I'm not really familiar with this driver. But I'll >> look what are the MFD cell instantiated to better understand dev functions >> and expand this documentation accordingly. > > Writing documentation for H/W you are unfamiliar with is a bad idea IMHO. > I just wanted to add an OF device ID table to the driver to make sure the driver won't have a regression when the I2C core reports an OF modalias but was asked to also write a DT binding doc in this case... I'm happy to drop the DT binding doc patch and someone more familiar to do it as a follow up. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html