From: Rian Hunter <rian@alum.mit.edu>
To: Andy Lutomirski <luto@amacapital.net>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Andy Lutomirski <luto@kernel.org>,
Borislav Petkov <bpetkov@suse.de>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Joerg Roedel <jroedel@suse.de>, Dmitry Safonov <dima@arista.com>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH] x86/process: Export start_thread()
Date: Sun, 19 Aug 2018 21:34:42 -0700 [thread overview]
Message-ID: <c2517959e12dfecef167e5657881e003@thelig.ht> (raw)
In-Reply-To: <53141AE9-7192-432B-8A27-25986CF442D4@amacapital.net>
On 2018-08-19 19:29, Andy Lutomirski wrote:
>> On Aug 19, 2018, at 4:08 PM, Rian Hunter <rian@alum.mit.edu> wrote:
>>
>> Commit e634d8fc792c ("x86-64: merge the standard and compat
>> start_thread() functions") removed exporting for the start_thread()
>> function in what seems like a typo. Add it back to
>> arch/x86/kernel/process_64.c for parity with process_32.c and other
>> arch.
>
> What for? Perhaps 32-bit could remove it instead?
>
Came across this while writing a binfmt module. Useful for me but
probably no one else on Earth, at least for another ~9 years on average.
>> Signed-off-by: Rian Hunter <rian@alum.mit.edu>
>> ---
>> arch/x86/kernel/process_64.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/kernel/process_64.c
>> b/arch/x86/kernel/process_64.c
>> index 476e3ddf8890..a451bc374b9b 100644
>> --- a/arch/x86/kernel/process_64.c
>> +++ b/arch/x86/kernel/process_64.c
>> @@ -384,6 +384,7 @@ start_thread(struct pt_regs *regs, unsigned long
>> new_ip, unsigned long new_sp)
>> start_thread_common(regs, new_ip, new_sp,
>> __USER_CS, __USER_DS, 0);
>> }
>> +EXPORT_SYMBOL_GPL(start_thread);
>>
>> #ifdef CONFIG_COMPAT
>> void compat_start_thread(struct pt_regs *regs, u32 new_ip, u32 new_sp)
>> --
>> 2.16.3
>>
next prev parent reply other threads:[~2018-08-20 4:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 23:08 [PATCH] x86/process: Export start_thread() Rian Hunter
2018-08-20 2:29 ` Andy Lutomirski
2018-08-20 4:34 ` Rian Hunter [this message]
2018-08-20 7:30 ` Thomas Gleixner
2018-08-20 14:27 ` Andy Lutomirski
2018-08-20 16:11 ` [tip:x86/urgent] x86/process: Re-export start_thread() tip-bot for Rian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2517959e12dfecef167e5657881e003@thelig.ht \
--to=rian@alum.mit.edu \
--cc=bpetkov@suse.de \
--cc=dima@arista.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.