From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D0E4C10F14 for ; Tue, 23 Apr 2019 12:59:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7634206A3 for ; Tue, 23 Apr 2019 12:59:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="NB6QoECL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727775AbfDWM7c (ORCPT ); Tue, 23 Apr 2019 08:59:32 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:48826 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727225AbfDWM7c (ORCPT ); Tue, 23 Apr 2019 08:59:32 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x3NCxF3F020838; Tue, 23 Apr 2019 07:59:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1556024356; bh=m1GaqatvcHWGft1cimldRpq3+Wj+GxtgYLjUb+o/um0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=NB6QoECLRNos4h+LyPekREh6avE1ehKMm/Iau7Gx5y+d0OuXGjKRz7mBB6JkzjmQy k8tLTvpSWNTtjO+glgiiHorq0phRTveHqNmkTizTLeRQmg08eUNLtDk+tnHz2A5OzF HmlyZDDBSgT7N40U81M1oE0syn6ehVLSQ4NuPT/0= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x3NCxFKO032853 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 23 Apr 2019 07:59:15 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 23 Apr 2019 07:59:14 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 23 Apr 2019 07:59:13 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x3NCxBkt070170; Tue, 23 Apr 2019 07:59:12 -0500 Subject: Re: [PATCH v3 0/4] drm/panel: Support for OSD101T2045-53TS and OSD101T2587-53TS To: Thierry Reding CC: , , , , , , , References: <20190226075523.28997-1-peter.ujfalusi@ti.com> <20190423115506.GE23448@ulmo> From: Peter Ujfalusi Message-ID: Date: Tue, 23 Apr 2019 16:00:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190423115506.GE23448@ulmo> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thierry, On 23/04/2019 14.55, Thierry Reding wrote: > On Tue, Feb 26, 2019 at 09:55:19AM +0200, Peter Ujfalusi wrote: >> Hi, >> >> Changes since v2: >> - Added Reviewed-by from Rob to the binding patches >> - Added help text to Kconfig (osd101t2587-53ts) >> - Print the error values in dev_err/warn >> - Added Reviewed-by from Sam to the osd101t2587-53ts patch >> >> Changes since v1 (only panel-osd-osd101t2587-53ts changed): >> - Removed unused members from struct osd101t2587_panel >> - Use backlight_enable/backlight_disable >> - Use devm_of_find_backlight() >> - osd101t2587_of_match table standardized >> - osd101t2587_panel_unprepare() added to shutdown and remove callbacks to turn >> power off >> - Fix probe in case mipi_dsi_attach() would fail >> >> Add support for OSD101T2045-53TS and OSD101T2587-53TS from One Stop Displays. >> >> The two panel is similar with one big difference: OSD101T2587-53TS requires the >> MIPI_DSI_TURN_ON_PERIPHERAL message, thus can not be handled by panel-simple. >> >> Regards, >> Peter >> --- >> Peter Ujfalusi (4): >> dt-bindings: display: Add bindings for OSD101T2045-53TS >> drm/panel: simple: Add support for OSD101T2045-53TS >> dt-bindings: display: Add bindings for OSD101T2587-53TS panel >> drm/panel: Add OSD101T2587-53TS driver >> >> .../display/panel/osd,osd101t2045-53ts.txt | 11 + >> .../display/panel/osd,osd101t2587-53ts.txt | 14 + >> drivers/gpu/drm/panel/Kconfig | 9 + >> drivers/gpu/drm/panel/Makefile | 1 + >> .../drm/panel/panel-osd-osd101t2587-53ts.c | 254 ++++++++++++++++++ >> drivers/gpu/drm/panel/panel-simple.c | 34 +++ >> 6 files changed, 323 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/osd,osd101t2045-53ts.txt >> create mode 100644 Documentation/devicetree/bindings/display/panel/osd,osd101t2587-53ts.txt >> create mode 100644 drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c > > Applied all four patches. Note that I had to change the osd vendor > string to osddisplays, which is the one that is documented in > vendor-prefixes.txt. I recall checking the vendor-prefixes.txt and not finding OSD in there. Odd, as it is indeed there. > I'm assuming that this is the same vendor, based on the model names. If > this is a different vendor, do let me know. Yes it is the same one. Thank you and sorry for missing it, - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH v3 0/4] drm/panel: Support for OSD101T2045-53TS and OSD101T2587-53TS Date: Tue, 23 Apr 2019 16:00:26 +0300 Message-ID: References: <20190226075523.28997-1-peter.ujfalusi@ti.com> <20190423115506.GE23448@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190423115506.GE23448@ulmo> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: devicetree@vger.kernel.org, airlied@linux.ie, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, sam@ravnborg.org List-Id: devicetree@vger.kernel.org SGkgVGhpZXJyeSwKCk9uIDIzLzA0LzIwMTkgMTQuNTUsIFRoaWVycnkgUmVkaW5nIHdyb3RlOgo+ IE9uIFR1ZSwgRmViIDI2LCAyMDE5IGF0IDA5OjU1OjE5QU0gKzAyMDAsIFBldGVyIFVqZmFsdXNp IHdyb3RlOgo+PiBIaSwKPj4KPj4gQ2hhbmdlcyBzaW5jZSB2MjoKPj4gLSBBZGRlZCBSZXZpZXdl ZC1ieSBmcm9tIFJvYiB0byB0aGUgYmluZGluZyBwYXRjaGVzCj4+IC0gQWRkZWQgaGVscCB0ZXh0 IHRvIEtjb25maWcgKG9zZDEwMXQyNTg3LTUzdHMpCj4+IC0gUHJpbnQgdGhlIGVycm9yIHZhbHVl cyBpbiBkZXZfZXJyL3dhcm4KPj4gLSBBZGRlZCBSZXZpZXdlZC1ieSBmcm9tIFNhbSB0byB0aGUg b3NkMTAxdDI1ODctNTN0cyBwYXRjaAo+Pgo+PiBDaGFuZ2VzIHNpbmNlIHYxIChvbmx5IHBhbmVs LW9zZC1vc2QxMDF0MjU4Ny01M3RzIGNoYW5nZWQpOgo+PiAtIFJlbW92ZWQgdW51c2VkIG1lbWJl cnMgZnJvbSBzdHJ1Y3Qgb3NkMTAxdDI1ODdfcGFuZWwKPj4gLSBVc2UgYmFja2xpZ2h0X2VuYWJs ZS9iYWNrbGlnaHRfZGlzYWJsZQo+PiAtIFVzZSBkZXZtX29mX2ZpbmRfYmFja2xpZ2h0KCkKPj4g LSBvc2QxMDF0MjU4N19vZl9tYXRjaCB0YWJsZSBzdGFuZGFyZGl6ZWQgCj4+IC0gb3NkMTAxdDI1 ODdfcGFuZWxfdW5wcmVwYXJlKCkgYWRkZWQgdG8gc2h1dGRvd24gYW5kIHJlbW92ZSBjYWxsYmFj a3MgdG8gdHVybgo+PiAgIHBvd2VyIG9mZgo+PiAtIEZpeCBwcm9iZSBpbiBjYXNlIG1pcGlfZHNp X2F0dGFjaCgpIHdvdWxkIGZhaWwKPj4KPj4gQWRkIHN1cHBvcnQgZm9yIE9TRDEwMVQyMDQ1LTUz VFMgYW5kIE9TRDEwMVQyNTg3LTUzVFMgZnJvbSBPbmUgU3RvcCBEaXNwbGF5cy4KPj4KPj4gVGhl IHR3byBwYW5lbCBpcyBzaW1pbGFyIHdpdGggb25lIGJpZyBkaWZmZXJlbmNlOiBPU0QxMDFUMjU4 Ny01M1RTIHJlcXVpcmVzIHRoZQo+PiBNSVBJX0RTSV9UVVJOX09OX1BFUklQSEVSQUwgbWVzc2Fn ZSwgdGh1cyBjYW4gbm90IGJlIGhhbmRsZWQgYnkgcGFuZWwtc2ltcGxlLgo+Pgo+PiBSZWdhcmRz LAo+PiBQZXRlcgo+PiAtLS0KPj4gUGV0ZXIgVWpmYWx1c2kgKDQpOgo+PiAgIGR0LWJpbmRpbmdz OiBkaXNwbGF5OiBBZGQgYmluZGluZ3MgZm9yIE9TRDEwMVQyMDQ1LTUzVFMKPj4gICBkcm0vcGFu ZWw6IHNpbXBsZTogQWRkIHN1cHBvcnQgZm9yIE9TRDEwMVQyMDQ1LTUzVFMKPj4gICBkdC1iaW5k aW5nczogZGlzcGxheTogQWRkIGJpbmRpbmdzIGZvciBPU0QxMDFUMjU4Ny01M1RTIHBhbmVsCj4+ ICAgZHJtL3BhbmVsOiBBZGQgT1NEMTAxVDI1ODctNTNUUyBkcml2ZXIKPj4KPj4gIC4uLi9kaXNw bGF5L3BhbmVsL29zZCxvc2QxMDF0MjA0NS01M3RzLnR4dCAgICB8ICAxMSArCj4+ICAuLi4vZGlz cGxheS9wYW5lbC9vc2Qsb3NkMTAxdDI1ODctNTN0cy50eHQgICAgfCAgMTQgKwo+PiAgZHJpdmVy cy9ncHUvZHJtL3BhbmVsL0tjb25maWcgICAgICAgICAgICAgICAgIHwgICA5ICsKPj4gIGRyaXZl cnMvZ3B1L2RybS9wYW5lbC9NYWtlZmlsZSAgICAgICAgICAgICAgICB8ICAgMSArCj4+ICAuLi4v ZHJtL3BhbmVsL3BhbmVsLW9zZC1vc2QxMDF0MjU4Ny01M3RzLmMgICAgfCAyNTQgKysrKysrKysr KysrKysrKysrCj4+ICBkcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMgICAgICAg ICAgfCAgMzQgKysrCj4+ICA2IGZpbGVzIGNoYW5nZWQsIDMyMyBpbnNlcnRpb25zKCspCj4+ICBj cmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3Bs YXkvcGFuZWwvb3NkLG9zZDEwMXQyMDQ1LTUzdHMudHh0Cj4+ICBjcmVhdGUgbW9kZSAxMDA2NDQg RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvb3NkLG9zZDEw MXQyNTg3LTUzdHMudHh0Cj4+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL3Bh bmVsL3BhbmVsLW9zZC1vc2QxMDF0MjU4Ny01M3RzLmMKPiAKPiBBcHBsaWVkIGFsbCBmb3VyIHBh dGNoZXMuIE5vdGUgdGhhdCBJIGhhZCB0byBjaGFuZ2UgdGhlIG9zZCB2ZW5kb3IKPiBzdHJpbmcg dG8gb3NkZGlzcGxheXMsIHdoaWNoIGlzIHRoZSBvbmUgdGhhdCBpcyBkb2N1bWVudGVkIGluCj4g dmVuZG9yLXByZWZpeGVzLnR4dC4KCkkgcmVjYWxsIGNoZWNraW5nIHRoZSB2ZW5kb3ItcHJlZml4 ZXMudHh0IGFuZCBub3QgZmluZGluZyBPU0QgaW4gdGhlcmUuCk9kZCwgYXMgaXQgaXMgaW5kZWVk IHRoZXJlLgoKPiBJJ20gYXNzdW1pbmcgdGhhdCB0aGlzIGlzIHRoZSBzYW1lIHZlbmRvciwgYmFz ZWQgb24gdGhlIG1vZGVsIG5hbWVzLiBJZgo+IHRoaXMgaXMgYSBkaWZmZXJlbnQgdmVuZG9yLCBk byBsZXQgbWUga25vdy4KClllcyBpdCBpcyB0aGUgc2FtZSBvbmUuCgpUaGFuayB5b3UgYW5kIHNv cnJ5IGZvciBtaXNzaW5nIGl0LAotIFDDqXRlcgoKVGV4YXMgSW5zdHJ1bWVudHMgRmlubGFuZCBP eSwgUG9ya2thbGFua2F0dSAyMiwgMDAxODAgSGVsc2lua2kuClktdHVubnVzL0J1c2luZXNzIElE OiAwNjE1NTIxLTQuIEtvdGlwYWlra2EvRG9taWNpbGU6IEhlbHNpbmtpCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==