All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Tiago Macedo <tiagohenrique.macedo@gmail.com>,
	gregkh@linuxfoundation.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org, lkcamp@lists.libreplanetbr.org,
	Tiago Macedo <tiagohenrique.macedo@gmai.com>
Subject: Re: [PATCH] Fixed coding style: do not initialise statics to NULL
Date: Fri, 12 Apr 2019 12:48:40 +0200	[thread overview]
Message-ID: <c26613c6-1212-8ccd-e762-c7280509844e@xs4all.nl> (raw)
In-Reply-To: <20190412024520.26835-1-tiagohenrique.macedo@gmai.com>

Hi Tiago,

On 4/12/19 4:45 AM, Tiago Macedo wrote:
> The standard guarantees that a pointer with static storage duration
> and no other initializer will be initialized to be a null pointer.
> 
> Signed-off-by: Tiago Macedo <tiagohenrique.macedo@gmai.com>
> ---
>  drivers/staging/media/zoran/videocodec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/media/zoran/videocodec.c
> index c1ee5cb7e66b..cc6e0f1cd7b4 100644
> --- a/drivers/staging/media/zoran/videocodec.c
> +++ b/drivers/staging/media/zoran/videocodec.c
> @@ -51,7 +51,7 @@ struct codec_list {
>  	struct codec_list *next;
>  };
>  
> -static struct codec_list *codeclist_top = NULL;
> +static struct codec_list *codeclist_top;
>  
>  /* ================================================= */
>  /* function prototypes of the master/slave interface */
> 

I dropped this patch since the zoran driver will be removed for 5.2,
so there is no point in applying this patch.

Also, for future reference, please provide the name of the driver that
you are patching in the subject. I.e. something like this:

[PATCH] zoran: fixed coding style: do not initialise statics to NULL

That helps triage for maintainers.

Regards,

	Hans

      reply	other threads:[~2019-04-12 10:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  2:45 [PATCH] Fixed coding style: do not initialise statics to NULL Tiago Macedo
2019-04-12 10:48 ` Hans Verkuil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c26613c6-1212-8ccd-e762-c7280509844e@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=tiagohenrique.macedo@gmai.com \
    --cc=tiagohenrique.macedo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.