From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AE23C4332F for ; Sun, 6 Nov 2022 22:32:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 26A1280A55; Sun, 6 Nov 2022 23:32:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=sholland.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sholland.org header.i=@sholland.org header.b="tdi4AS3O"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="nLSkEAS6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 03BD384576; Sun, 6 Nov 2022 23:32:38 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BCD5A80705 for ; Sun, 6 Nov 2022 23:32:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=sholland.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=samuel@sholland.org Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 40BFC5C0082; Sun, 6 Nov 2022 17:32:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 06 Nov 2022 17:32:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1667773952; x= 1667860352; bh=BR6eaKhGokq7p6ahju++gRjibDCIse8FeOXoTC6KMg4=; b=t di4AS3Oe2oKFGtzaBd52aVPwrkY7zC2b9qY8+QxUvPR5G/HE9J9TkWkM/y/hLWKc ByRNKfTcRfXRHmDO35cSAfvc7j6gTIe9rUw7TBchh3Of53cwx6pLrmJaffkU6veR K040msvDSeQFc8ROm6q2QGxU0gne8bIqW63GfsHV7LJ+MjXuU/FTLHr28gG2kzUv VVlFkVDGNGwdE6+UsBgY/OzlRjBm9Z407jGoWc5XtG38aVx3/JYCB9q+rlv8rbce Q3bw6C+V2PL8j8ho1T28t934mjE+tuU4Wv01jOOFdCSF3F/uXtxchoDbLEAxp0SZ 4fVQi82f1HHZazP7Pjc4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667773952; x= 1667860352; bh=BR6eaKhGokq7p6ahju++gRjibDCIse8FeOXoTC6KMg4=; b=n LSkEAS65E8pL8Tgnrdtb+KgYF1G6AfqyKVdkFd6j782nY1Mio+NeGjo+rbe+aL2s o6Gy0dPuu5CYCvHdpxjP2Z9Q2mYaklX+KF5wpEIoIwygObZD42iLfQynXaNY4H+d 6Gq00zy34F+4UzZKQ5ILZkRizPo3hvdZHXEszAzzFVargXAkZf3zePtfA77UuvVE 9LEfe3E6jFd1xNLxgfc8fHpLS/Z00IgK2958JB1kpoZbr7+OQHHkwH9pPWA3JNi/ nkOYzRps/ToYyuxkMAgCQhdDVIu9s4BZ+6cqa/30Pi13veGHYVULSETXrUj3nZpb N2d7jbgs+KVuqv7gQ9e0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrvdejucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epkfffgggfvfevfhfhufgjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghmuhgvlhcu jfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtffrrg htthgvrhhnpeejgfffhfdujeeftdeuudeguedttefgieetffffheejuefguedvheejteef tdfftdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 6 Nov 2022 17:32:31 -0500 (EST) Message-ID: Date: Sun, 6 Nov 2022 16:32:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-US To: Andre Przywara Cc: Jagan Teki , u-boot@lists.denx.de References: <20221101050835.2421-1-samuel@sholland.org> <20221103164619.687138e7@donnerap.cambridge.arm.com> From: Samuel Holland Subject: Re: [PATCH 00/22] sunxi: Prepare platform Kconfig to support multiple architectures In-Reply-To: <20221103164619.687138e7@donnerap.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/3/22 11:46, Andre Przywara wrote: > On Tue, 1 Nov 2022 00:08:12 -0500 > Samuel Holland wrote: > > Hi Samuel, > >> sunxi is getting a new RISC-V platform, D1. We want to share as much of >> the existing configuration as possible, to provide a familiar >> environment, DRAM layout, partition layout, etc. >> >> Because U-Boot includes all architecture Kconfig files at once, we must >> use a symbol outside of both CONFIG_ARM and CONFIG_RISCV to contain >> shared Kconfig options. I chose BOARD_SUNXI, corresponding to the file >> location and somewhat following the BOARD_SPECIFIC_OPTIONS pattern. > > many thanks for sending this, indeed our Kconfig deserved some cleanups, > plus we need to fix the woes with RISC-V. > I just skimmed over this for now, and it seems to look good. > > I have some gripes with the name BOARD_SUNXI though. Bad enough we have > board-agnostic generic code in board/sunxi, but maybe we shouldn't add to > the confusion. Would PLAT_SUNXI be a better name? After all it's all about > the Allwinner platform (and not even "architecture", for that matter). I am fine with either name. "board" is U-Boot's name for the level of abstraction we are working at. I don't know that it necessarily has to refer to code for a _single_ board, as opposed to code that glues things together at the "board level" outside the CPU/SoC. But I can see where the confusion comes from. Let me know what you want me to do, and I can adjust/resend the series. >> I did a buildman run on this series. The only net option changes are the >> expected ones: >> - Host-side USB gets enabled on several boards by the first patch >> (emlid_neutis_n5_devboard orangepi_zero2 pinephone pinetab tanix_tx6 >> x96_mate teres_i) >> - CONFIG_BOARD_SUNXI gets added everywhere >> - CONFIG_SYS_I2C_MVTWSI gets enabled by the corresponding patch >> >> Andre, please feel free to take any subset of these; they don't all have >> to go in at once. And I'm open to suggestions about what instances of >> ARCH_SUNXI should (not) be converted. Some of them are open to opinion. > > Yeah, I will definitely cherry-pick some patches, especially the more > innocent ones. I will run my before/after defconfig comparisons to test > them. I used buildman's -K option to get the list above; it outputs the list of individual boards with option changes per patch. Regards, Samuel