From: Amir Mizinski <amirmizi6@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Eyal.Cohen@nuvoton.com, jarkko.sakkinen@linux.intel.com,
oshrialkoby85@gmail.com, alexander.steffen@infineon.com,
mark.rutland@arm.com, peterhuewe@gmx.de, jgg@ziepe.ca,
arnd@arndb.de, gregkh@linuxfoundation.org, benoit.houyere@st.com,
eajames@linux.ibm.com, joel@jms.id.au,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com,
tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com,
Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com,
shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com
Subject: Re: [PATCH v7 6/7] tpm: Add YAML schema for TPM TIS I2C options
Date: Wed, 6 May 2020 15:20:30 +0000 [thread overview]
Message-ID: <c2760659-ec14-237e-e060-5d9a2d7c7e4a@gmail.com> (raw)
In-Reply-To: <20200505161226.GA555@bogus>
On 2020-05-05 16:12, Rob Herring wrote:
> On Mon, Apr 27, 2020 at 03:49:30PM +0300, amirmizi6@gmail.com wrote:
>> From: Amir Mizinski <amirmizi6@gmail.com>
>>
>> Added a YAML schema to support tpm tis i2c related dt-bindings for the I2c
>> PTP based physical layer.
>>
>> This patch adds the documentation for corresponding device tree bindings of
>> I2C based Physical TPM.
>> Refer to the 'I2C Interface Definition' section in
>> 'TCG PC Client PlatformTPMProfile(PTP) Specification' publication
>> for specification.
>
> Again, DT bindings describe h/w devices, not just a protocol. A device
> is more than just a protocol interface. There's clocks, power rails,
> resets, interrupts, firmware, etc.
>
> Unless there's something special about TPM chips that makes none of this
> applicable and no chip will ever have any quirks (or extensions) in
> their protocol to work-around, then you need compatible string(s) that
> are specific to the TPM chip. You can have tcg,tpm-tis-i2c as a
> fallback, but you need specific compatible to handle any quirks.
>
> Rob
Hello Rob, currently yes. All TPM chip are implemented according to the TGC specs and should use the same properties for this I2C driver.
I can't say for sure that it will be the case in the future. Shouldn't we use the standard "tcg,tpm-tis-i2c" compatible, and if a specific TPM chip will deviate from the specs, the vendor should add an additional compatible string for it?
Thank you,
Amir
next prev parent reply other threads:[~2020-05-06 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 12:49 [PATCH v7 0/7] Add tpm i2c ptp driver amirmizi6
2020-04-27 12:49 ` [PATCH v7 1/7] tpm: tpm_tis: Make implementation of read16, read32 and write32 optional amirmizi6
2020-04-27 12:49 ` [PATCH v7 2/7] tpm: tpm_tis: Add verify_data_integrity handle toy tpm_tis_phy_ops amirmizi6
2020-04-29 5:34 ` Jarkko Sakkinen
2020-04-30 10:19 ` Amir Mizinski
2020-04-27 12:49 ` [PATCH v7 3/7] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()" amirmizi6
2020-04-29 5:37 ` Jarkko Sakkinen
2020-04-30 10:29 ` Amir Mizinski
2020-04-27 12:49 ` [PATCH v7 4/7] tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception amirmizi6
2020-04-27 12:49 ` [PATCH v7 5/7] tpm: Handle an exception for TPM Firmware Update mode amirmizi6
2020-04-27 12:49 ` [PATCH v7 6/7] tpm: Add YAML schema for TPM TIS I2C options amirmizi6
2020-05-05 16:12 ` Rob Herring
2020-05-06 15:20 ` Amir Mizinski [this message]
2020-05-06 19:02 ` Rob Herring
2020-04-27 12:49 ` [PATCH v7 7/7] tpm: tpm_tis: add tpm_tis_i2c driver amirmizi6
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2760659-ec14-237e-e060-5d9a2d7c7e4a@gmail.com \
--to=amirmizi6@gmail.com \
--cc=Dan.Morav@nuvoton.com \
--cc=Eyal.Cohen@nuvoton.com \
--cc=alexander.steffen@infineon.com \
--cc=amir.mizinski@nuvoton.com \
--cc=arnd@arndb.de \
--cc=benoit.houyere@st.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=gcwilson@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=joel@jms.id.au \
--cc=kgoldman@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oren.tanami@nuvoton.com \
--cc=oshri.alkoby@nuvoton.com \
--cc=oshrialkoby85@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=robh@kernel.org \
--cc=shmulik.hager@nuvoton.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.