From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from pegase1.c-s.fr ([93.17.236.30]:44230 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbdLXIzZ (ORCPT ); Sun, 24 Dec 2017 03:55:25 -0500 Subject: Re: [PATCH v3 00/27] kill devm_ioremap_nocache To: Guenter Roeck , Greg KH , Yisheng Xie Cc: linux-kernel@vger.kernel.org, ysxie@foxmail.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, boris.brezillon@free-electrons.com, richard@nod.at, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, linux-mtd@lists.infradead.org, alsa-devel@alsa-project.org, wim@iguana.be, linux-watchdog@vger.kernel.org, b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, ralf@linux-mips.org, linux-mips@linux-mips.org, lgirdwood@gmail.com, broonie@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, arnd@arndb.de, andriy.shevchenko@linux.intel.com, industrypack-devel@lists.sourceforge.net, wg@grandegger.com, mkl@pengutronix.de, linux-can@vger.kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, linux-rtc@vger.kernel.org, daniel.vetter@intel.com, jani.nikula@linux.intel.com, seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, linux-spi@vger.kernel.org, tj@kernel.org, linux-ide@vger.kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, devel@driverdev.osuosl.org, dvhart@infradead.org, andy@infradead.org, platform-driver-x86@vger.kernel.org, jakub.kicinski@netronome.com, davem@davemloft.net, nios2-dev@lists.rocketboards.org, netdev@vger.kernel.org, vinod.koul@intel.com, dan.j.williams@intel.com, dmaengine@vger.kernel.org, jslaby@suse.com References: <1514026525-32538-1-git-send-email-xieyisheng1@huawei.com> <20171223134831.GB10103@kroah.com> From: christophe leroy Message-ID: (sfid-20171224_095606_890844_B2F1235D) Date: Sun, 24 Dec 2017 09:55:18 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Le 23/12/2017 à 16:57, Guenter Roeck a écrit : > On 12/23/2017 05:48 AM, Greg KH wrote: >> On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: >>> Hi all, >>> >>> When I tried to use devm_ioremap function and review related code, I >>> found >>> devm_ioremap and devm_ioremap_nocache is almost the same with each >>> other, >>> except one use ioremap while the other use ioremap_nocache. >> >> For all arches?  Really?  Look at MIPS, and x86, they have different >> functions. >> > > Both mips and x86 end up mapping the same function, but other arches don't. > mn10300 is one where ioremap and ioremap_nocache are definitely different. alpha: identical arc: identical arm: identical arm64: identical cris: different <== frv: identical hexagone: identical ia64: different <== m32r: identical m68k: identical metag: identical microblaze: identical mips: identical mn10300: different <== nios: identical openrisc: different <== parisc: identical riscv: identical s390: identical sh: identical sparc: identical tile: identical um: rely on asm/generic unicore32: identical x86: identical asm/generic (no mmu): identical So 4 among all arches seems to have ioremap() and ioremap_nocache() being different. Could we have a define set by the 4 arches on which ioremap() and ioremap_nocache() are different, something like HAVE_DIFFERENT_IOREMAP_NOCACHE ? Christophe > > Guenter > >>> While ioremap's >>> default function is ioremap_nocache, so devm_ioremap_nocache also >>> have the >>> same function with devm_ioremap, which can just be killed to reduce >>> the size >>> of devres.o(from 20304 bytes to 18992 bytes in my compile environment). >>> >>> I have posted two versions, which use macro instead of function for >>> devm_ioremap_nocache[1] or devm_ioremap[2]. And Greg suggest me to kill >>> devm_ioremap_nocache for no need to keep a macro around for the >>> duplicate >>> thing. So here comes v3 and please help to review. >> >> I don't think this can be done, what am I missing?  These functions are >> not identical, sorry for missing that before. >> >> thanks, >> >> greg k-h >> > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus From mboxrd@z Thu Jan 1 00:00:00 1970 From: christophe leroy Subject: Re: [PATCH v3 00/27] kill devm_ioremap_nocache Date: Sun, 24 Dec 2017 09:55:18 +0100 Message-ID: References: <1514026525-32538-1-git-send-email-xieyisheng1@huawei.com> <20171223134831.GB10103@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: fr Sender: linux-can-owner@vger.kernel.org To: Guenter Roeck , Greg KH , Yisheng Xie Cc: linux-kernel@vger.kernel.org, ysxie@foxmail.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, boris.brezillon@free-electrons.com, richard@nod.at, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, linux-mtd@lists.infradead.org, alsa-devel@alsa-project.org, wim@iguana.be, linux-watchdog@vger.kernel.org, b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, ralf@linux-mips.org, linux-mips@linux-mips.org, lgirdwood@gmail.com, broonie@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, arnd@arndb.de, andriy.shevchenko@linux.intel.com, industrypack-devel@lists.sourceforge.net, wg@grandegger.com, mkl@pengutronix.de, linux-can@vger.kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, a.zum List-Id: linux-ide@vger.kernel.org Le 23/12/2017 à 16:57, Guenter Roeck a écrit : > On 12/23/2017 05:48 AM, Greg KH wrote: >> On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: >>> Hi all, >>> >>> When I tried to use devm_ioremap function and review related code, I >>> found >>> devm_ioremap and devm_ioremap_nocache is almost the same with each >>> other, >>> except one use ioremap while the other use ioremap_nocache. >> >> For all arches?  Really?  Look at MIPS, and x86, they have different >> functions. >> > > Both mips and x86 end up mapping the same function, but other arches don't. > mn10300 is one where ioremap and ioremap_nocache are definitely different. alpha: identical arc: identical arm: identical arm64: identical cris: different <== frv: identical hexagone: identical ia64: different <== m32r: identical m68k: identical metag: identical microblaze: identical mips: identical mn10300: different <== nios: identical openrisc: different <== parisc: identical riscv: identical s390: identical sh: identical sparc: identical tile: identical um: rely on asm/generic unicore32: identical x86: identical asm/generic (no mmu): identical So 4 among all arches seems to have ioremap() and ioremap_nocache() being different. Could we have a define set by the 4 arches on which ioremap() and ioremap_nocache() are different, something like HAVE_DIFFERENT_IOREMAP_NOCACHE ? Christophe > > Guenter > >>> While ioremap's >>> default function is ioremap_nocache, so devm_ioremap_nocache also >>> have the >>> same function with devm_ioremap, which can just be killed to reduce >>> the size >>> of devres.o(from 20304 bytes to 18992 bytes in my compile environment). >>> >>> I have posted two versions, which use macro instead of function for >>> devm_ioremap_nocache[1] or devm_ioremap[2]. And Greg suggest me to kill >>> devm_ioremap_nocache for no need to keep a macro around for the >>> duplicate >>> thing. So here comes v3 and please help to review. >> >> I don't think this can be done, what am I missing?  These functions are >> not identical, sorry for missing that before. >> >> thanks, >> >> greg k-h >> > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus From mboxrd@z Thu Jan 1 00:00:00 1970 From: christophe leroy Date: Sun, 24 Dec 2017 08:55:18 +0000 Subject: Re: [PATCH v3 00/27] kill devm_ioremap_nocache Message-Id: List-Id: References: <1514026525-32538-1-git-send-email-xieyisheng1@huawei.com> <20171223134831.GB10103@kroah.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Guenter Roeck , Greg KH , Yisheng Xie Cc: linux-kernel@vger.kernel.org, ysxie@foxmail.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, boris.brezillon@free-electrons.com, richard@nod.at, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, linux-mtd@lists.infradead.org, alsa-devel@alsa-project.org, wim@iguana.be, linux-watchdog@vger.kernel.org, b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, ralf@linux-mips.org, linux-mips@linux-mips.org, lgirdwood@gmail.com, broonie@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, arnd@arndb.de, andriy.shevchenko@linux.intel.com, industrypack-devel@lists.sourceforge.net, wg@grandegger.com, mkl@pengutronix.de, linux-can@vger.kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, a.zum Le 23/12/2017 à 16:57, Guenter Roeck a écrit : > On 12/23/2017 05:48 AM, Greg KH wrote: >> On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: >>> Hi all, >>> >>> When I tried to use devm_ioremap function and review related code, I >>> found >>> devm_ioremap and devm_ioremap_nocache is almost the same with each >>> other, >>> except one use ioremap while the other use ioremap_nocache. >> >> For all arches?  Really?  Look at MIPS, and x86, they have different >> functions. >> > > Both mips and x86 end up mapping the same function, but other arches don't. > mn10300 is one where ioremap and ioremap_nocache are definitely different. alpha: identical arc: identical arm: identical arm64: identical cris: different <= frv: identical hexagone: identical ia64: different <= m32r: identical m68k: identical metag: identical microblaze: identical mips: identical mn10300: different <= nios: identical openrisc: different <= parisc: identical riscv: identical s390: identical sh: identical sparc: identical tile: identical um: rely on asm/generic unicore32: identical x86: identical asm/generic (no mmu): identical So 4 among all arches seems to have ioremap() and ioremap_nocache() being different. Could we have a define set by the 4 arches on which ioremap() and ioremap_nocache() are different, something like HAVE_DIFFERENT_IOREMAP_NOCACHE ? Christophe > > Guenter > >>> While ioremap's >>> default function is ioremap_nocache, so devm_ioremap_nocache also >>> have the >>> same function with devm_ioremap, which can just be killed to reduce >>> the size >>> of devres.o(from 20304 bytes to 18992 bytes in my compile environment). >>> >>> I have posted two versions, which use macro instead of function for >>> devm_ioremap_nocache[1] or devm_ioremap[2]. And Greg suggest me to kill >>> devm_ioremap_nocache for no need to keep a macro around for the >>> duplicate >>> thing. So here comes v3 and please help to review. >> >> I don't think this can be done, what am I missing?  These functions are >> not identical, sorry for missing that before. >> >> thanks, >> >> greg k-h >> > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus