From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9110AC00140 for ; Fri, 12 Aug 2022 10:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238187AbiHLKOa (ORCPT ); Fri, 12 Aug 2022 06:14:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238170AbiHLKOL (ORCPT ); Fri, 12 Aug 2022 06:14:11 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B53B3AB4E8 for ; Fri, 12 Aug 2022 03:13:18 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id w15so507405ljw.1 for ; Fri, 12 Aug 2022 03:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=8cLhmbUzxjFPeEqNnxegdJhRMYmiHcGmozP5wffiZTU=; b=WTxdbpatl/Nddz+PTuVRR73SuOXowEQtLmLFxwXWr5GSYU+ztSACZWVLaK2vzxj6m2 3NdwSnjEIuzz6QdV1sGNd+PZwhsw0kp2vd8OV4FBs95Ubiv1gkcyN7+g+cGKDByb+dwc VQaz4lcgk7eb4C/9zl9ZYT0SHgo4br4IhFxpnqSl4UJ9dKefLYB9Ro0WwChQc7roJYiv qtr4ZjKf0hvB8pl/KDFx1/0QTUUnNrZUeTJYA9rnIsSID56uY/KMzHsCWv4uyxdt/0Z3 w+mbvhDGrfZt2gPg0v9ElyCXUE5wVb/a+Etr7VCnn3ncEwUWWctATPiZqmDsJPyv+BLB mg+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=8cLhmbUzxjFPeEqNnxegdJhRMYmiHcGmozP5wffiZTU=; b=MTZp+pZwmY+9a6r3zgy0KIw+2QiRsL9sHdkFJgp6PXZIxqMDj1GUSd3JrMwkS/+Ri6 nB+KtGlKYoW/YBXdYoYVLqXOEJrbSDkkFtZM8B13tN/h9zNKbJy3Ql2+Fp/kXo6utfm1 wgLLtCoYM7pzUFEL/waH4QDLaLMkk5ACC/EPKR9mqIKx8yP33O6wtbs4Z3qpr9h+jmjQ S/Ya+In0JWxeXOo6QLbIrtKn54IqhiuqXHxkpqA9kFljfXaBs4kiMgbp9R9OxKiLu6ed 3bCqk9o7Gh2y3frjybtS3yvpFd/GEaiQekBouN4isnB1fBojZRJa+opFrOjMankVitEK /c9g== X-Gm-Message-State: ACgBeo2Vg2hdeFkoBQQFC3HUzVbA/0JBUU1bNVsx29g0D7BwCngTniaq 0tNNuQFNkbXC+SN8QnNEpwVsWA== X-Google-Smtp-Source: AA6agR7naJ9emf9TqWnh8kwp04vlKy5jAdUnOcyWakfGln360Wqaak0cNUSE0V2nXvLtaxyZjCuJ0Q== X-Received: by 2002:a2e:b8d3:0:b0:25f:e94d:10ae with SMTP id s19-20020a2eb8d3000000b0025fe94d10aemr897828ljp.331.1660299197072; Fri, 12 Aug 2022 03:13:17 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id e7-20020a05651c038700b0025df04af0f0sm305398ljp.51.2022.08.12.03.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 03:13:16 -0700 (PDT) Message-ID: Date: Fri, 12 Aug 2022 13:13:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 6/6] i2c: imx-lpi2c: handle IPG clock Content-Language: en-US To: "Peng Fan (OSS)" , aisheng.dong@nxp.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xiaoning.wang@nxp.com, Peng Fan References: <20220812043424.4078034-1-peng.fan@oss.nxp.com> <20220812043424.4078034-7-peng.fan@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220812043424.4078034-7-peng.fan@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2022 07:34, Peng Fan (OSS) wrote: > From: Peng Fan > > The LPI2C controller needs both PER and IPG clock to work, but current > driver only supports PER clock. This patch add IPG clock. > > Signed-off-by: Peng Fan > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 41 ++++++++++++++++++++++-------- > 1 file changed, 31 insertions(+), 10 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c > index 8b9ba055c418..f43ad1ae8627 100644 > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > @@ -94,7 +94,8 @@ enum lpi2c_imx_pincfg { > > struct lpi2c_imx_struct { > struct i2c_adapter adapter; > - struct clk *clk; > + struct clk *clk_per; > + struct clk *clk_ipg; > void __iomem *base; > __u8 *rx_buf; > __u8 *tx_buf; > @@ -207,7 +208,7 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx) > > lpi2c_imx_set_mode(lpi2c_imx); > > - clk_rate = clk_get_rate(lpi2c_imx->clk); > + clk_rate = clk_get_rate(lpi2c_imx->clk_per); > if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST) > filt = 0; > else > @@ -561,10 +562,16 @@ static int lpi2c_imx_probe(struct platform_device *pdev) > strlcpy(lpi2c_imx->adapter.name, pdev->name, > sizeof(lpi2c_imx->adapter.name)); > > - lpi2c_imx->clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(lpi2c_imx->clk)) { > + lpi2c_imx->clk_per = devm_clk_get(&pdev->dev, "per"); > + if (IS_ERR(lpi2c_imx->clk_per)) { > dev_err(&pdev->dev, "can't get I2C peripheral clock\n"); > - return PTR_ERR(lpi2c_imx->clk); > + return PTR_ERR(lpi2c_imx->clk_per); > + } > + > + lpi2c_imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); > + if (IS_ERR(lpi2c_imx->clk_ipg)) { > + dev_err(&pdev->dev, "can't get I2C ipg clock\n"); > + return PTR_ERR(lpi2c_imx->clk_ipg); > } You just broke all DTS... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCD5DC00140 for ; Fri, 12 Aug 2022 10:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EHIWf15Dk/4XFDzPqZvANtXLRO1zHQkSoY3q0YEN7Fk=; b=VVo/x8NdFGDJm9 sF9oLl31hHVK7eGpa8vfGFe+PhCmBah+RBbVFypXBcOZC0TyF8cYT7FeOAkXWJMEDwuOSxIHAOJO0 XjMNB9LwI/llVSk2gTNnnllUimbTDMgk96iIeL837KGafp3Ux87udh3d28yZdjp6QtcLrDNmbGUtH iWVPOsLZXJQW5G3SFwL1NxeEDKavxY+gHQD8EnZC32JoR3SHlRwQ3hFa0mJ77yi8tizn9cXfcem1v EO8ZwWv24mWeP4qE+bq+aWJjDjlHICDtP4/2cynilodsqyf8owHI2La996rlyVJef34JUanD3mmEk hKafP76RjtJjX7hTMzew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMRg0-004qwV-DM; Fri, 12 Aug 2022 10:14:00 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMRfK-004pd3-HA for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2022 10:13:20 +0000 Received: by mail-lj1-x231.google.com with SMTP id x10so500483ljq.4 for ; Fri, 12 Aug 2022 03:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=8cLhmbUzxjFPeEqNnxegdJhRMYmiHcGmozP5wffiZTU=; b=WTxdbpatl/Nddz+PTuVRR73SuOXowEQtLmLFxwXWr5GSYU+ztSACZWVLaK2vzxj6m2 3NdwSnjEIuzz6QdV1sGNd+PZwhsw0kp2vd8OV4FBs95Ubiv1gkcyN7+g+cGKDByb+dwc VQaz4lcgk7eb4C/9zl9ZYT0SHgo4br4IhFxpnqSl4UJ9dKefLYB9Ro0WwChQc7roJYiv qtr4ZjKf0hvB8pl/KDFx1/0QTUUnNrZUeTJYA9rnIsSID56uY/KMzHsCWv4uyxdt/0Z3 w+mbvhDGrfZt2gPg0v9ElyCXUE5wVb/a+Etr7VCnn3ncEwUWWctATPiZqmDsJPyv+BLB mg+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=8cLhmbUzxjFPeEqNnxegdJhRMYmiHcGmozP5wffiZTU=; b=0kIj7H3K/whNibZ7GHDvY/LaVZDEafSuiQqYI8BMtZ4yyf0gwI0xiOv2E+g6up7m8I PYJxAWBbpSLiYgBK1vpPdiW1XCrvwExAt9haPCeK+i3UlTn2/u7qk5ojSUXrZE2PEZGv nN2BI82ocjQNGNGa0LSzPUhERHgsG+I0tP10sejya7EMb7tkJeNa8DFMCvsd22SMfj2H ZanRDt0bnRlZoDnEaybbj8p78pTRB7XBkV5aiHihUNXv+GpHc1lKGoY91lXfhDXPnB/9 YJCAI5yqXr01mD/ttNtdNPJJ9rvZva7LqLRMePoOpCDPgBwNgi5iikd8eDixgaMe6RN1 RCwQ== X-Gm-Message-State: ACgBeo2j5qQk3ogEWcXAMM7LOhQZAAbVLM7uDxDaZk3b4hAyRvMWP+bG BgDxIlcqxI5+JlZKP7l+MUeRCQ== X-Google-Smtp-Source: AA6agR7naJ9emf9TqWnh8kwp04vlKy5jAdUnOcyWakfGln360Wqaak0cNUSE0V2nXvLtaxyZjCuJ0Q== X-Received: by 2002:a2e:b8d3:0:b0:25f:e94d:10ae with SMTP id s19-20020a2eb8d3000000b0025fe94d10aemr897828ljp.331.1660299197072; Fri, 12 Aug 2022 03:13:17 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id e7-20020a05651c038700b0025df04af0f0sm305398ljp.51.2022.08.12.03.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 03:13:16 -0700 (PDT) Message-ID: Date: Fri, 12 Aug 2022 13:13:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 6/6] i2c: imx-lpi2c: handle IPG clock Content-Language: en-US To: "Peng Fan (OSS)" , aisheng.dong@nxp.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xiaoning.wang@nxp.com, Peng Fan References: <20220812043424.4078034-1-peng.fan@oss.nxp.com> <20220812043424.4078034-7-peng.fan@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220812043424.4078034-7-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_031318_641155_FB35006F X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/08/2022 07:34, Peng Fan (OSS) wrote: > From: Peng Fan > > The LPI2C controller needs both PER and IPG clock to work, but current > driver only supports PER clock. This patch add IPG clock. > > Signed-off-by: Peng Fan > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 41 ++++++++++++++++++++++-------- > 1 file changed, 31 insertions(+), 10 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c > index 8b9ba055c418..f43ad1ae8627 100644 > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > @@ -94,7 +94,8 @@ enum lpi2c_imx_pincfg { > > struct lpi2c_imx_struct { > struct i2c_adapter adapter; > - struct clk *clk; > + struct clk *clk_per; > + struct clk *clk_ipg; > void __iomem *base; > __u8 *rx_buf; > __u8 *tx_buf; > @@ -207,7 +208,7 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx) > > lpi2c_imx_set_mode(lpi2c_imx); > > - clk_rate = clk_get_rate(lpi2c_imx->clk); > + clk_rate = clk_get_rate(lpi2c_imx->clk_per); > if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST) > filt = 0; > else > @@ -561,10 +562,16 @@ static int lpi2c_imx_probe(struct platform_device *pdev) > strlcpy(lpi2c_imx->adapter.name, pdev->name, > sizeof(lpi2c_imx->adapter.name)); > > - lpi2c_imx->clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(lpi2c_imx->clk)) { > + lpi2c_imx->clk_per = devm_clk_get(&pdev->dev, "per"); > + if (IS_ERR(lpi2c_imx->clk_per)) { > dev_err(&pdev->dev, "can't get I2C peripheral clock\n"); > - return PTR_ERR(lpi2c_imx->clk); > + return PTR_ERR(lpi2c_imx->clk_per); > + } > + > + lpi2c_imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); > + if (IS_ERR(lpi2c_imx->clk_ipg)) { > + dev_err(&pdev->dev, "can't get I2C ipg clock\n"); > + return PTR_ERR(lpi2c_imx->clk_ipg); > } You just broke all DTS... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel