From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 26107C6379F
	for <dpdk-dev@archiver.kernel.org>; Thu,  2 Feb 2023 10:47:40 +0000 (UTC)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3FB28406A2;
	Thu,  2 Feb 2023 11:47:39 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id E8E6B40689
 for <dev@dpdk.org>; Thu,  2 Feb 2023 11:47:37 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 56EC050;
 Thu,  2 Feb 2023 13:47:37 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 56EC050
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1675334857;
 bh=MoqJzoZHOope6d2VIcPuU5/SOP5lGpCCmpRiCX/fnN0=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=cB0vZBnNk2dUdzAzB+wguYwUf3NJiyufh/Hfdpnbtzmq4DgVAbCSb4s4GRTgmAlOR
 KQ2655lZ/DCCn1J7CbI5l4rjgq/SkxQB6qd0tyJbgcw23K30QeEei+r4KgJsKmsPyn
 Goso25gc5VjHL7A2ZMQ0hQx9ySAmN2K4eAFNSqEQ=
Message-ID: <c29ac2f7-08f8-fde3-c790-f0562f6f8c3c@oktetlabs.ru>
Date: Thu, 2 Feb 2023 13:47:36 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v8 1/2] ethdev: add query_update sync and async function
 calls
Content-Language: en-US
To: Gregory Etelson <getelson@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,
 Ori Kam <orika@nvidia.com>,
 "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@amd.com>
References: <20221221073547.988-1-getelson@nvidia.com>
 <20230201151646.3500-1-getelson@nvidia.com>
 <0a24a07c-6d36-2f5e-5f24-1501bcc41c1e@oktetlabs.ru>
 <IA1PR12MB6332C9F3CB7546DC41EC6197A5D69@IA1PR12MB6332.namprd12.prod.outlook.com>
 <8cd35215-a114-3ac4-4dc8-8f69df360833@oktetlabs.ru>
 <IA1PR12MB63329539076088AA4A5DFD77A5D69@IA1PR12MB6332.namprd12.prod.outlook.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <IA1PR12MB63329539076088AA4A5DFD77A5D69@IA1PR12MB6332.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2/2/23 13:44, Gregory Etelson wrote:
> Hello Andrew,
> 
> []
> 
>> On 2/2/23 13:24, Gregory Etelson wrote:
>>>> On 2/1/23 18:16, Gregory Etelson wrote:
>>>>> +     ops = rte_flow_ops_get(port_id, error);
>>>>> +     if (!ops || !ops->action_handle_query_update)
>>>>> +             return -ENOTSUP;
>>>>
>>>> May be it makes sense to use single-operation callbacks if
>>>> another operation input is NULL. I guess it could be
>>>> convenient in some cases. Just an idea.
>>>>
>>>
>>> There is a plan to deprecate indirect query and update functions
>>> and replace them with a single query_update.
>>
>> So, will you add corresponding code? Just want to clarify.
>>
> 
> There is ongoing work on next stage of indirect action functions.
> The plan is to deprecate existing API when all updates will be introduced.

IMHO nothing prevents to add handling right now. It will allow
to use query_update instead of just query or update from the
very beginning. Not a strong requirement. Just nice to have
from my point of view.