Re: [PATCH 6/7] xsm/flask: Use unsigned int instead of plain unsigned

From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	Jason Andryuk <jandryuk@gmail.com>
Subject: Re: [PATCH 6/7] xsm/flask: Use unsigned int instead of plain unsigned
Date: Mon, 27 Jun 2022 15:19:00 -0400	[thread overview]
Message-ID: <c2b68766-9608-5910-7937-b7747ad189e7@apertussolutions.com> (raw)
In-Reply-To: <20220627131543.410971-7-michal.orzel@arm.com>

On 6/27/22 09:15, Michal Orzel wrote:
> This is just for the style and consistency reasons as the former is
> being used more often than the latter.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
>  xen/xsm/flask/ss/avtab.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c
> index 017f5183de..9761d028d8 100644
> --- a/xen/xsm/flask/ss/avtab.c
> +++ b/xen/xsm/flask/ss/avtab.c
> @@ -349,7 +349,7 @@ int avtab_read_item(struct avtab *a, void *fp, struct policydb *pol,
>      struct avtab_key key;
>      struct avtab_datum datum;
>      int i, rc;
> -    unsigned set;
> +    unsigned int set;
>  
>      memset(&key, 0, sizeof(struct avtab_key));
>      memset(&datum, 0, sizeof(struct avtab_datum));

Is this not v2? Jason gave a Rb on the similar patch if I am not mistaken.

v/r,
dps