From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 766F8C433EF for ; Mon, 2 May 2022 06:48:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 90A0883F18; Mon, 2 May 2022 08:48:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1651474106; bh=5/Gi+a8+Sxw2DnyfyfzHNY5fqolLaGEg8cJedLWODcs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=x0Sfyeocr35ZE+EMAJfD9VP17UO9QPLnwjuZr/0W/4iniLDaRq/PaNqRkEQTAJ49K b6pi+9eOuFgYCAS02tIcjgOxqcBoOZQFAhtkPPJ4Z1lDzUZpBBI6dD8iMYUGJKQ4H3 OK8DPOTKPawduxIC6oVAwyrzW+mpRHl382qV9Hb2cpoR9Ulm2QQrOO+wl5VkSM0siF AZjVvZzaV+PEhSw05V1cCfosYPW7iuLSVbzRKGg8qDnSswmQ/yoYsWVpZPuuRqKCrH Ys0H60RLWQzBFk1ojRD+B+MENxnQjkcf+QTcStr9RV1CFljudOtZ8HI8TFavpzJt4F Y/TLwwP/Y5z3A== Received: by phobos.denx.de (Postfix, from userid 109) id 5046383F06; Mon, 2 May 2022 08:48:24 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [80.241.59.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D753683EA3 for ; Mon, 2 May 2022 08:48:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4KsDFK2npbz9sS0; Mon, 2 May 2022 08:48:21 +0200 (CEST) Message-ID: Date: Mon, 2 May 2022 08:48:16 +0200 MIME-Version: 1.0 Subject: Re: [PATCH u-boot-marvell 02/19] net: mvneta: Fix 10Mbps speed Content-Language: en-US To: =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: Robert Marko , =?UTF-8?Q?Pali_Roh=c3=a1r?= , U-Boot-Denx , Ramon Fried , Joe Hershberger , =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20220427104202.1205-1-kabel@kernel.org> <20220427104202.1205-3-kabel@kernel.org> From: Stefan Roese In-Reply-To: <20220427104202.1205-3-kabel@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 27.04.22 12:41, Marek Behún wrote: > From: Marek Behún > > In mvneta_adjust_link() we need to set MII_SPEED bit only if PHY reports > the speed at 100Mbps. > > Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > drivers/net/mvneta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c > index d1c5f7930d..79cdb93341 100644 > --- a/drivers/net/mvneta.c > +++ b/drivers/net/mvneta.c > @@ -1195,7 +1195,7 @@ static void mvneta_adjust_link(struct udevice *dev) > > if (phydev->speed == SPEED_1000) > val |= MVNETA_GMAC_CONFIG_GMII_SPEED; > - else > + else if (pp->speed == SPEED_100) > val |= MVNETA_GMAC_CONFIG_MII_SPEED; > > mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val); Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de