From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 266EAC43331 for ; Mon, 11 Nov 2019 23:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E46B12184C for ; Mon, 11 Nov 2019 23:16:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbfKKXQN (ORCPT ); Mon, 11 Nov 2019 18:16:13 -0500 Received: from smtprelay0001.hostedemail.com ([216.40.44.1]:50588 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726845AbfKKXQN (ORCPT ); Mon, 11 Nov 2019 18:16:13 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id DA04540E1; Mon, 11 Nov 2019 23:16:11 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: nut53_18ddf32dd8d37 X-Filterd-Recvd-Size: 2182 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Mon, 11 Nov 2019 23:16:10 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 3/3] staging: wfx: replace u32 by __le32 From: Joe Perches To: Jerome Pouiller , Jules Irenge Cc: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Date: Mon, 11 Nov 2019 15:15:54 -0800 In-Reply-To: <3445403.d56fhTCmfW@pc-42> References: <20191111133055.214410-1-jbi.octave@gmail.com> <20191111133055.214410-3-jbi.octave@gmail.com> <3445403.d56fhTCmfW@pc-42> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-11-11 at 16:58 +0000, Jerome Pouiller wrote: > On Monday 11 November 2019 14:30:55 CET Jules Irenge wrote: > [...] > > - u32 count_rts_failures; > > - u32 count_ack_failures; > > - u32 count_rx_multicast_frames; > > - u32 count_rx_frames_success; > > - u32 count_rx_cmacicv_errors; > > - u32 count_rx_cmac_replays; > > - u32 count_rx_mgmt_ccmp_replays; > [...] > > + __le32 count_rts_failures; > > + __le32 count_rx_multicast_frames; > > + __le32 count_rx_cmacicv_errors; > > + __le32 count_rx_cmac_replays; > > + __le32 count_rx_mgmt_ccmp_replays; > > + __le32 count_rx_beacon; > > + __le32 count_miss_beacon; > > + __le32 count_ack_failures; > > + __le32 count_rx_frames_success; > > u32 count_rx_bipmic_errors; > > - u32 count_rx_beacon; > > - u32 count_miss_beacon; > > Hello Jules, > > Your patch reorders members of the structure. It will break API with the > chip. And if the hardware really is le, then almost certainly _all_ the members of the struct should be __le32 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BA8C43331 for ; Mon, 11 Nov 2019 23:55:41 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8707621655 for ; Mon, 11 Nov 2019 23:55:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8707621655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 04E4287553; Mon, 11 Nov 2019 23:55:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k68brXEZFEn7; Mon, 11 Nov 2019 23:55:38 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 198128757D; Mon, 11 Nov 2019 23:55:38 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 212E91BF381 for ; Mon, 11 Nov 2019 23:55:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1DFC92000B for ; Mon, 11 Nov 2019 23:55:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YlEfH5XpcwH2 for ; Mon, 11 Nov 2019 23:55:36 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by silver.osuosl.org (Postfix) with ESMTPS id 3054820006 for ; Mon, 11 Nov 2019 23:55:36 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave06.hostedemail.com (Postfix) with ESMTP id 8893A800A327 for ; Mon, 11 Nov 2019 23:16:14 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id DA04540E1; Mon, 11 Nov 2019 23:16:11 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: nut53_18ddf32dd8d37 X-Filterd-Recvd-Size: 2182 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Mon, 11 Nov 2019 23:16:10 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 3/3] staging: wfx: replace u32 by __le32 From: Joe Perches To: Jerome Pouiller , Jules Irenge Date: Mon, 11 Nov 2019 15:15:54 -0800 In-Reply-To: <3445403.d56fhTCmfW@pc-42> References: <20191111133055.214410-1-jbi.octave@gmail.com> <20191111133055.214410-3-jbi.octave@gmail.com> <3445403.d56fhTCmfW@pc-42> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devel@driverdev.osuosl.org" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, 2019-11-11 at 16:58 +0000, Jerome Pouiller wrote: > On Monday 11 November 2019 14:30:55 CET Jules Irenge wrote: > [...] > > - u32 count_rts_failures; > > - u32 count_ack_failures; > > - u32 count_rx_multicast_frames; > > - u32 count_rx_frames_success; > > - u32 count_rx_cmacicv_errors; > > - u32 count_rx_cmac_replays; > > - u32 count_rx_mgmt_ccmp_replays; > [...] > > + __le32 count_rts_failures; > > + __le32 count_rx_multicast_frames; > > + __le32 count_rx_cmacicv_errors; > > + __le32 count_rx_cmac_replays; > > + __le32 count_rx_mgmt_ccmp_replays; > > + __le32 count_rx_beacon; > > + __le32 count_miss_beacon; > > + __le32 count_ack_failures; > > + __le32 count_rx_frames_success; > > u32 count_rx_bipmic_errors; > > - u32 count_rx_beacon; > > - u32 count_miss_beacon; > > Hello Jules, > > Your patch reorders members of the structure. It will break API with the > chip. And if the hardware really is le, then almost certainly _all_ the members of the struct should be __le32 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel