From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91809C4363D for ; Fri, 2 Oct 2020 08:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F900206DC for ; Fri, 2 Oct 2020 08:52:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Q6JBHgBm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726517AbgJBIwJ (ORCPT ); Fri, 2 Oct 2020 04:52:09 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:4981 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725993AbgJBIwJ (ORCPT ); Fri, 2 Oct 2020 04:52:09 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 02 Oct 2020 01:51:17 -0700 Received: from [10.25.97.216] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 2 Oct 2020 08:52:00 +0000 Subject: Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver To: Dmitry Osipenko , , , , , , , , , CC: , , , , , , , , , , , , References: <1601573587-15288-1-git-send-email-spujar@nvidia.com> <1601573587-15288-11-git-send-email-spujar@nvidia.com> <98f01f9e-96f8-6867-1af3-475294e81a9d@gmail.com> <352b5f57-baa5-8905-4ac9-1281268270a8@gmail.com> From: Sameer Pujar Message-ID: Date: Fri, 2 Oct 2020 14:21:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <352b5f57-baa5-8905-4ac9-1281268270a8@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601628677; bh=MKlVcqKLPdDu8OBlYPBwuNP2isTdKIOp/ktFx21aA+U=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=Q6JBHgBmCmScUpfFBsiclVC+L3nHbZj7/FeXu1PPFwxGk4uA9yv+yt3bFjW/dGES1 cJlgXeXUUNDMGphPJzP+7p9V3Auoa44c+FptQp6W7/63SpbIXcKtY0ZABN/FWkeXWe tQOqKQwPWlwqRWzsj3+IcaZvtItU62hWp6JsA8WEzSzaFPa9k6NJPnVcyj12LbkSl0 3IRENlQzEtLu/zoumUrzNgxIwTuu95U2Ct50qqkzMh57U0AUK/kCRgYISaKNGFguxm upKJLJXhDd77WGhbc//ygaVpADM23m4Q9I62+C7xpFcx1ai7V3Tzcs1P+CS8oRlhsJ 53FivqyFeer+g== Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org >>> +/* Setup PLL clock as per the given sample rate */ >>> +static int tegra_audio_graph_update_pll(struct snd_pcm_substream *substream, >>> + struct snd_pcm_hw_params *params) >>> +{ >>> + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); >>> + struct asoc_simple_priv *priv = snd_soc_card_get_drvdata(rtd->card); >>> + struct device *dev = rtd->card->dev; >>> + struct tegra_audio_graph_data *graph_data = >>> + (struct tegra_audio_graph_data *)priv->data; >>> + struct tegra_audio_chip_data *chip_data = >>> + (struct tegra_audio_chip_data *)of_device_get_match_data(dev); >> void* doesn't need casting >> > There are several similar places in the code. Not a big deal, but this > makes code less readable than it could be. I will drop these in next revision. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11DDCC4363D for ; Fri, 2 Oct 2020 08:53:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF1BA206DC for ; Fri, 2 Oct 2020 08:53:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="GgQr954m"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Q6JBHgBm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF1BA206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 49DF51EF6; Fri, 2 Oct 2020 10:52:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 49DF51EF6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601628792; bh=waJnn41M00lpRqIbVTIzEDQ/uF7/GVtUC4qmN6jOUu0=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GgQr954mcCI8utdhQCI12ZyK+B9GwR3SISP6Yb7NI0JUdQZcHQ4t4c85tslYZtjQm Z7Y6OhTnkioTmLwKo3bBe7N5tPpQSzjoKqUeSAn9kiEV6AxLy2eRVlYWSEWFMdKZZN jr1RPHZhrVn7jDy/1atvxsM0M3vRHCHVvAp/6Y3Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BFC62F80228; Fri, 2 Oct 2020 10:52:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0EACDF800E5; Fri, 2 Oct 2020 10:52:20 +0200 (CEST) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5D726F800E5 for ; Fri, 2 Oct 2020 10:52:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5D726F800E5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Q6JBHgBm" Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 02 Oct 2020 01:51:17 -0700 Received: from [10.25.97.216] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 2 Oct 2020 08:52:00 +0000 Subject: Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver To: Dmitry Osipenko , , , , , , , , , References: <1601573587-15288-1-git-send-email-spujar@nvidia.com> <1601573587-15288-11-git-send-email-spujar@nvidia.com> <98f01f9e-96f8-6867-1af3-475294e81a9d@gmail.com> <352b5f57-baa5-8905-4ac9-1281268270a8@gmail.com> From: Sameer Pujar Message-ID: Date: Fri, 2 Oct 2020 14:21:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <352b5f57-baa5-8905-4ac9-1281268270a8@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601628677; bh=MKlVcqKLPdDu8OBlYPBwuNP2isTdKIOp/ktFx21aA+U=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=Q6JBHgBmCmScUpfFBsiclVC+L3nHbZj7/FeXu1PPFwxGk4uA9yv+yt3bFjW/dGES1 cJlgXeXUUNDMGphPJzP+7p9V3Auoa44c+FptQp6W7/63SpbIXcKtY0ZABN/FWkeXWe tQOqKQwPWlwqRWzsj3+IcaZvtItU62hWp6JsA8WEzSzaFPa9k6NJPnVcyj12LbkSl0 3IRENlQzEtLu/zoumUrzNgxIwTuu95U2Ct50qqkzMh57U0AUK/kCRgYISaKNGFguxm upKJLJXhDd77WGhbc//ygaVpADM23m4Q9I62+C7xpFcx1ai7V3Tzcs1P+CS8oRlhsJ 53FivqyFeer+g== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, nicoleotsuka@gmail.com, swarren@nvidia.com, linux-kernel@vger.kernel.org, atalambedu@nvidia.com, viswanathl@nvidia.com, sharadg@nvidia.com, nwartikar@nvidia.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >>> +/* Setup PLL clock as per the given sample rate */ >>> +static int tegra_audio_graph_update_pll(struct snd_pcm_substream *substream, >>> + struct snd_pcm_hw_params *params) >>> +{ >>> + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); >>> + struct asoc_simple_priv *priv = snd_soc_card_get_drvdata(rtd->card); >>> + struct device *dev = rtd->card->dev; >>> + struct tegra_audio_graph_data *graph_data = >>> + (struct tegra_audio_graph_data *)priv->data; >>> + struct tegra_audio_chip_data *chip_data = >>> + (struct tegra_audio_chip_data *)of_device_get_match_data(dev); >> void* doesn't need casting >> > There are several similar places in the code. Not a big deal, but this > makes code less readable than it could be. I will drop these in next revision.