All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Necasek <michal.necasek@oracle.com>
To: <tglx@linutronix.de>
Cc: <prarit@redhat.com>, <ville.syrjala@linux.intel.com>,
	<michael.thayer@oracle.com>, <frank.mehnert@oracle.com>,
	<knut.osmundsen@oracle.com>, <linux-kernel@vger.kernel.org>
Subject: Re: 4.8.2 not booting in 32-bit VM without I/O-APIC
Date: Thu, 3 Nov 2016 13:02:16 -0700 (PDT)	[thread overview]
Message-ID: <c2d4d670-64dc-4cfe-ae68-63dbe6a543bf@default> (raw)


    Hi Thomas,

 Sorry for the delay. I can confirm that the problem is fixed in 4.9.0-rc3 and prefill_possible_map no longer crashes (as it did in 4.9.0-rc2). Thank you!

 Just a side question, is the previous fix in commit ff8560512b (x86/boot/smp: Don't try to poke disabled/non-existent APIC) actually still required or would the no-op APIC driver take care of it?

    Regards,
      Michal

----- Original Message -----
From: tglx@linutronix.de
To: michal.necasek@oracle.com
Cc: prarit@redhat.com, ville.syrjala@linux.intel.com, michael.thayer@oracle.com, knut.osmundsen@oracle.com, frank.mehnert@oracle.com, linux-kernel@vger.kernel.org
Sent: Friday, October 28, 2016 9:37:31 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: Re: 4.8.2 not booting in 32-bit VM without I/O-APIC

On Fri, 28 Oct 2016, Thomas Gleixner wrote:

> On Fri, 28 Oct 2016, Michal Necasek wrote:
> > 
> >  Sorry if I wasn't clear. No, it doesn't work for us. The ff8560512b8d
> > commit fixes the APIC poking on machines where there is no local APIC
> > available (and thus fixes the committer's machine), but it doesn't work
> > in our case, where there is a local APIC but no I/O APIC, no ACPI MADT,
> > and no MP tables.
> 
> > In other words, for us boot_cpu_has(X86_FEATURE_APIC) is true but the
> > APIC has not been set up yet because init_apic_mappings() hasn't been
> > run.

Right. That mapping setup is an utter trainwreck as we do it from multiple
places, but there is no reason why we can't move it before the call to
prefill_possible_map().

Thanks,

	tglx

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index bbfbca5fea0c..b59fdba3cbdf 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1221,11 +1221,13 @@ void __init setup_arch(char **cmdline_p)
 	 */
 	get_smp_config();
 
+	/* Make sure apic is mapped before prefill_possible_map() */
+	init_apic_mappings();
+
 	prefill_possible_map();
 
 	init_cpu_to_node();
 
-	init_apic_mappings();
 	io_apic_init_mappings();
 
 	kvm_guest_init();

             reply	other threads:[~2016-11-03 20:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 20:02 Michal Necasek [this message]
2016-11-10 14:21 ` Michael Thayer
2016-11-10 17:18   ` Thomas Gleixner
  -- strict thread matches above, loose matches on Subject: below --
2016-10-28 18:52 Michal Necasek
2016-10-28 19:00 ` Thomas Gleixner
2016-10-28 19:34   ` Thomas Gleixner
2016-10-29 10:18     ` Borislav Petkov
2016-10-28 18:30 Michal Necasek
2016-10-28 18:38 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2d4d670-64dc-4cfe-ae68-63dbe6a543bf@default \
    --to=michal.necasek@oracle.com \
    --cc=frank.mehnert@oracle.com \
    --cc=knut.osmundsen@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.thayer@oracle.com \
    --cc=prarit@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=ville.syrjala@linux.intel.com \
    --subject='Re: 4.8.2 not booting in 32-bit VM without I/O-APIC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.