From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D49F7C77B73 for ; Wed, 31 May 2023 08:14:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4GyF-0006pn-EV; Wed, 31 May 2023 04:14:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Gy4-0006ff-Iw; Wed, 31 May 2023 04:14:04 -0400 Received: from forwardcorp1c.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Gy1-0007ej-BJ; Wed, 31 May 2023 04:14:04 -0400 Received: from mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:5515:0:640:d92d:0]) by forwardcorp1c.mail.yandex.net (Yandex) with ESMTP id 33E8260870; Wed, 31 May 2023 11:13:46 +0300 (MSK) Received: from [IPV6:2a02:6b8:b081:a512::1:34] (unknown [2a02:6b8:b081:a512::1:34]) by mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id jDI1MG0OgKo0-Qbsk5t7d; Wed, 31 May 2023 11:13:45 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1685520825; bh=GuOF3SCxr2h+ugLWsPK1bAa40q7Yz46xNqD9XbAh1xY=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=NIhePZCu6rAhMDOl6D05mZItsgCJeBXQXog02fEpAycxaayArlOkBveLxgdkzfncU rMuPR7OdW6Qe4QL3ZFCgx1hGgyrkRNAkdKaJTSFT+i/orwzrLAb0eQT3ayvITFynbG woPnRdqs8SWFb6ZOGBl/y/km8cM48P24l5Gv94zo= Authentication-Results: mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru Message-ID: Date: Wed, 31 May 2023 11:13:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 07/14] nbd/server: Refactor to pass full request around Content-Language: en-US To: Eric Blake , qemu-devel@nongnu.org Cc: libguestfs@redhat.com, "open list:Network Block Dev..." References: <20230515195343.1915857-1-eblake@redhat.com> <20230515195343.1915857-8-eblake@redhat.com> From: Vladimir Sementsov-Ogievskiy In-Reply-To: <20230515195343.1915857-8-eblake@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=178.154.239.200; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1c.mail.yandex.net X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.09, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 15.05.23 22:53, Eric Blake wrote: > Part of NBD's 64-bit headers extension involves passing the client's > requested offset back as part of the reply header (one reason for this > change: converting absolute offsets stored in > NBD_REPLY_TYPE_OFFSET_DATA to relative offsets within the buffer is > easier if the absolute offset of the buffer is also available). This > is a refactoring patch to pass the full request around the reply > stack, rather than just the handle, so that later patches can then > access request->from when extended headers are active. But for this > patch, there are no semantic changes. > > Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir