All of lore.kernel.org
 help / color / mirror / Atom feed
* USB gadget regression on i.MX7
@ 2021-06-18 13:42 Fabio Estevam
  2021-06-18 22:54 ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2021-06-18 13:42 UTC (permalink / raw)
  To: Marek Vasut; +Cc: Stefano Babic, Ye Li, Peng Fan, U-Boot-Denx

Hi Marek,

I noticed that USB  gadget does not work in U-Boot mainline on a warp7 board:

=> ums 0 mmc 0
UMS: LUN 0, dev mmc 0, hwpart 0, sector 0x0, count 0xe18000
g_dnl_register: failed!, error: -2
g_dnl_register failed

2021.04 works fine. I bisected and it pointed to:

4dcfa3bcbcbc5e0f7da145fff41e120392433062 is the first bad commit
commit 4dcfa3bcbcbc5e0f7da145fff41e120392433062
Author: Marek Vasut <marex@denx.de>
Date:   Wed Mar 31 23:06:07 2021 +0200

    usb: ehci-mx6: Parse USB PHY and MISC offsets from DT

    In case DM and OF controler is enabled, but PHY support is disabled,
    parse USB PHY and MISC component addresses from DT manually. Those
    component addresses will be used in subsequent patches to access the
    ANATOP, PHY and MISC registers matching the controller and thus get
    rid of the ad-hoc controller sequence number mapping.

    Fixes: 4de51cc25b5 ("usb: ehci-mx6: Drop assignment of sequence number")
    Signed-off-by: Marek Vasut <marex@denx.de>
    Cc: Fabio Estevam <festevam@gmail.com>
    Cc: Peng Fan <peng.fan@nxp.com>
    Cc: Stefano Babic <sbabic@denx.de>
    Cc: Ye Li <ye.li@nxp.com>
    Cc: uboot-imx <uboot-imx@nxp.com>

fdtdec_get_alias_seq() fails inside mx6_parse_dt_addrs().

Any suggestions?

Thanks,

Fabio Estevam

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: USB gadget regression on i.MX7
  2021-06-18 13:42 USB gadget regression on i.MX7 Fabio Estevam
@ 2021-06-18 22:54 ` Marek Vasut
  2021-06-20 15:00   ` Fabio Estevam
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2021-06-18 22:54 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: Stefano Babic, Ye Li, Peng Fan, U-Boot-Denx

On 6/18/21 3:42 PM, Fabio Estevam wrote:
> Hi Marek,

Hi,

> I noticed that USB  gadget does not work in U-Boot mainline on a warp7 board:
> 
> => ums 0 mmc 0
> UMS: LUN 0, dev mmc 0, hwpart 0, sector 0x0, count 0xe18000
> g_dnl_register: failed!, error: -2
> g_dnl_register failed
> 
> 2021.04 works fine. I bisected and it pointed to:
> 
> 4dcfa3bcbcbc5e0f7da145fff41e120392433062 is the first bad commit
> commit 4dcfa3bcbcbc5e0f7da145fff41e120392433062
> Author: Marek Vasut <marex@denx.de>
> Date:   Wed Mar 31 23:06:07 2021 +0200
> 
>      usb: ehci-mx6: Parse USB PHY and MISC offsets from DT
> 
>      In case DM and OF controler is enabled, but PHY support is disabled,
>      parse USB PHY and MISC component addresses from DT manually. Those
>      component addresses will be used in subsequent patches to access the
>      ANATOP, PHY and MISC registers matching the controller and thus get
>      rid of the ad-hoc controller sequence number mapping.

[...]

> fdtdec_get_alias_seq() fails inside mx6_parse_dt_addrs().
> 
> Any suggestions?

There is no fdtdec_get_alias_seq() in the above commit , and in fact, 
there shouldn't be, since all the sub-device addresses and offsets 
should be parsed out of DT now. So the only suggestion I can offer is, 
look into your DT and see whether the parsing can find all the props there.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: USB gadget regression on i.MX7
  2021-06-18 22:54 ` Marek Vasut
@ 2021-06-20 15:00   ` Fabio Estevam
  2021-06-20 19:35     ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2021-06-20 15:00 UTC (permalink / raw)
  To: Marek Vasut; +Cc: Stefano Babic, Ye Li, Peng Fan, U-Boot-Denx

Hi Marek,

On Fri, Jun 18, 2021 at 7:55 PM Marek Vasut <marex@denx.de> wrote:

> There is no fdtdec_get_alias_seq() in the above commit , and in fact,
> there shouldn't be, since all the sub-device addresses and offsets
> should be parsed out of DT now. So the only suggestion I can offer is,
> look into your DT and see whether the parsing can find all the props there.

I sent two fixes that allows me to use "ums 0 mmc 0" again on imx7s-warp.

Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: USB gadget regression on i.MX7
  2021-06-20 15:00   ` Fabio Estevam
@ 2021-06-20 19:35     ` Marek Vasut
  0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2021-06-20 19:35 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: Stefano Babic, Ye Li, Peng Fan, U-Boot-Denx

On 6/20/21 5:00 PM, Fabio Estevam wrote:

Hi,

[...]

>> There is no fdtdec_get_alias_seq() in the above commit , and in fact,
>> there shouldn't be, since all the sub-device addresses and offsets
>> should be parsed out of DT now. So the only suggestion I can offer is,
>> look into your DT and see whether the parsing can find all the props there.
> 
> I sent two fixes that allows me to use "ums 0 mmc 0" again on imx7s-warp.

Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-20 19:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 13:42 USB gadget regression on i.MX7 Fabio Estevam
2021-06-18 22:54 ` Marek Vasut
2021-06-20 15:00   ` Fabio Estevam
2021-06-20 19:35     ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.