From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 858D1C282DC for ; Sat, 6 Apr 2019 09:36:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C2C6218C3 for ; Sat, 6 Apr 2019 09:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbfDFJgV (ORCPT ); Sat, 6 Apr 2019 05:36:21 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:42570 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfDFJgV (ORCPT ); Sat, 6 Apr 2019 05:36:21 -0400 Received: by mail-ed1-f67.google.com with SMTP id x61so7508794edc.9 for ; Sat, 06 Apr 2019 02:36:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0DLb1Fk7vLKtuiPgIqTovdK4+ETBgN7HCCxekbvOg24=; b=RSSRPsiT/hi52e8QIipq6iLpZAW+bX64YMnSFs1ABEPjkCeiiIOr8LGqSpMlOXGCCG GqSA2ZPCgQfSwrftnLpzcyv2ZOWU2HuI57Tdw1+Azms5dByB+aGCijm+8mwccXaKIj30 o4HcsYS4UCxzgBZB5COzhIuRmuXiyL78X4XrBp9nPxhdha0ydmvmcUrjan/fwKjnBfNe ls49v0Pv+BP3/Iz8FKnvzlDYEDUZwl4NhaFWglysdTcZkepKSnrcqhjWgSUUuDDgmH7B VqyJRjvvyF7BvIh4bliU02BwGvqvwzg5CmUnGKyjeTB4h/eacH0m4u8IT2nEmcLyp1Xr 2euw== X-Gm-Message-State: APjAAAWYl8F2wknxQnKHbGXmuLKyFVDi6/+QVTXx7+Kms8QyTRpLJ/nY LWFRJRGHINS8eNkOrYtG7Owo+7YmfYI= X-Google-Smtp-Source: APXvYqxEu/D801d9gkHn5D8Ty9xBsp2yR/K2ozbOvNgrlXEDgKt6XUaxRXtK+RLrHgX6u3uQyjagYQ== X-Received: by 2002:a17:906:7496:: with SMTP id e22mr10230765ejl.45.1554543379515; Sat, 06 Apr 2019 02:36:19 -0700 (PDT) Received: from shalem.localdomain (84-106-84-65.cable.dynamic.v4.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id d20sm7237122eda.82.2019.04.06.02.36.18 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sat, 06 Apr 2019 02:36:18 -0700 (PDT) Subject: Re: [PATCH] iio: accel: add missing sensor for some 2-in-1 based ultrabooks To: =?UTF-8?Q?Lu=c3=ads_Ferreira?= Cc: jic23@kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Stephan Gerhold , "open list:IIO SUBSYSTEM AND DRIVERS" , open list References: <20190402160433.15810-1-luis@aurorafoss.org> <55a52a4e-01d1-2f4c-25e3-0047537bef86@redhat.com> From: Hans de Goede Message-ID: Date: Sat, 6 Apr 2019 11:36:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 06-04-19 01:01, Luís Ferreira wrote: > Hi, > >> Basically we need to come up with a convention to (optionally) indicate >> the sensors location with a udev attribute set by: >> /lib/udev/hwdb.d/60-sensor.hwdb > > So should we start adding `ACCEL_LOCATION=display` and > `ACCEL_LOCATION=keyboard` attributes to that file and patch > iio-sensor-proxy to ignore the keyboard ones as a first step ? Yes that seems the best way forward with this. Note I think "base" is better then "keyboard" for the sensor which is in the base/keyboard. But neither is perfect, so go which whatever you prefer. Thanks & Regards, Hans > On Wed, 3 Apr 2019 at 10:10, Hans de Goede wrote: >> >> Hi, >> >> On 02-04-19 18:04, Luís Ferreira wrote: >>> Some ultrabooks, like Teclast F6 Pro, use KIOX010A sensor on display >>> and KIOX020A sensor on keyboard base, to detect tablet mode or screen >>> orientation. >> >> I deliberately left out the KIOX020A id for now, because currently >> userspace cannot really deal with having 2 sensors. >> >> See: >> https://github.com/systemd/systemd/issues/6557 >> https://github.com/hadess/iio-sensor-proxy/issues/166 >> >> Basically we need to come up with a convention to (optionally) indicate >> the sensors location with a udev attribute set by: >> /lib/udev/hwdb.d/60-sensor.hwdb >> >> And then patch iio-sensor-proxy to consume that attribute and ignore >> the one which has e.g. ACCEL_LOCATION=keyboard in its udev properties >> >> Ignoring would be a first step, maybe later it can do something useful >> with it, see e.g. : https://github.com/alesguzik/linux_detect_tablet_mode >> >> IMHO we really should minimally get code in place for iio-sensor-proxy >> to ignore the keyboard accelerometer before merging this patch. >> >> I realize that having the code in place will not magically get it on >> all users machines, but I believe this is the minimum which needs to >> happen before we push this out and potentially breaks people screen >> rotation. >> >> I've had working on this on my TODO list for a long long time now, >> but -ENOTIME. If you have some time to work on this then that would >> be great. >> >> Regards, >> >> Hans >> >> >> >> >>> >>> Signed-off-by: Luís Ferreira >>> --- >>> drivers/iio/accel/kxcjk-1013.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c >>> index 7096e577b23f..9a5e445facc1 100644 >>> --- a/drivers/iio/accel/kxcjk-1013.c >>> +++ b/drivers/iio/accel/kxcjk-1013.c >>> @@ -1492,6 +1492,7 @@ static const struct acpi_device_id kx_acpi_match[] = { >>> {"KIOX0009", KXTJ21009}, >>> {"KIOX000A", KXCJ91008}, >>> {"KIOX010A", KXCJ91008}, /* KXCJ91008 inside the display of a 2-in-1 */ >>> + {"KIOX020A", KXCJ91008}, >>> {"KXTJ1009", KXTJ21009}, >>> {"KXJ2109", KXTJ21009}, >>> {"SMO8500", KXCJ91008}, >>>